From: Andreas Schwab <schwab@linux-m68k.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Amos Kong <akong@redhat.com>,
Linux/m68k <linux-m68k@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] mvme147: use correct order of ram pages
Date: Wed, 28 May 2014 11:39:20 +0200 [thread overview]
Message-ID: <mvmvbsqjl87.fsf@hawking.suse.de> (raw)
In-Reply-To: <CAMuHMdV-g35ijLgcE=sSM3eE+fCxC1WOiAX2PaWs0z4-+bDP+A@mail.gmail.com> (Geert Uytterhoeven's message of "Wed, 28 May 2014 09:51:39 +0200")
Geert Uytterhoeven <geert@linux-m68k.org> writes:
>> -/* We have 16834 bytes of RAM for the init block and buffers. This places
>> +/* We have 16384 bytes of RAM for the init block and buffers. This places
>> * an upper limit on the number of buffers we can use. NetBSD uses 8 Rx
>> * buffers and 2 Tx buffers.
>> */
>> +#define M147LANCE_RAM_SIZE 16384 /* 16K */
>> #define LANCE_LOG_TX_BUFFERS 1
>> #define LANCE_LOG_RX_BUFFERS 3
>
> BTW,I also find it fishy why the driver uses only 1+3 buffers, since more
> RAM is available.
It's 2^1+2^3.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2014-05-28 9:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 4:07 [PATCH] mvme147: use correct order of ram pages Amos Kong
2014-05-28 7:51 ` Geert Uytterhoeven
2014-05-28 9:39 ` Andreas Schwab [this message]
2014-05-28 13:58 ` Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmvbsqjl87.fsf@hawking.suse.de \
--to=schwab@linux-m68k.org \
--cc=akong@redhat.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox