Re: [alsa-devel] future of sounds/oss

Re: [alsa-devel] future of sounds/oss

[Geert Uytterhoeven]

Hi Iwai-san,

On Thu, May 11, 2017 at 10:21 PM, Takashi Iwai <tiwai@suse.de> wrote:
> From: Takashi Iwai <tiwai@suse.de>
> Subject: [PATCH] sound: Disable the build of OSS drivers
>
> OSS drivers are left as badly unmaintained, and now we're facing a
> problem to clean up the hackish set_fs() usage in their codes.  Since
> most of drivers have been covered by ALSA, and the others are dead old
> and inactive, let's leave them RIP.
>
> This patch is the first step: disable the build of OSS drivers.
> We'll eventually drop the whole codes and clean up later.
>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>  sound/Kconfig | 26 ++++++++++++++------------
>  1 file changed, 14 insertions(+), 12 deletions(-)
>
> diff --git a/sound/Kconfig b/sound/Kconfig
> index ee2e69a9ecd1..41eda578d08e 100644
> --- a/sound/Kconfig
> +++ b/sound/Kconfig
> @@ -54,7 +54,8 @@ config SOUND_OSS_CORE_PRECLAIM
>
>           If unsure, say Y.
>
> -source "sound/oss/dmasound/Kconfig"
> +### TO-BE-REMOVED
> +# source "sound/oss/dmasound/Kconfig"

Please note the dmasound drivers do not have ALSA equivalents.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [alsa-devel] future of sounds/oss

[Takashi Iwai]

On Fri, 12 May 2017 09:03:07 +0200,
Geert Uytterhoeven wrote:
> 
> Hi Iwai-san,
> 
> On Thu, May 11, 2017 at 10:21 PM, Takashi Iwai <tiwai@suse.de> wrote:
> > From: Takashi Iwai <tiwai@suse.de>
> > Subject: [PATCH] sound: Disable the build of OSS drivers
> >
> > OSS drivers are left as badly unmaintained, and now we're facing a
> > problem to clean up the hackish set_fs() usage in their codes.  Since
> > most of drivers have been covered by ALSA, and the others are dead old
> > and inactive, let's leave them RIP.
> >
> > This patch is the first step: disable the build of OSS drivers.
> > We'll eventually drop the whole codes and clean up later.
> >
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > ---
> >  sound/Kconfig | 26 ++++++++++++++------------
> >  1 file changed, 14 insertions(+), 12 deletions(-)
> >
> > diff --git a/sound/Kconfig b/sound/Kconfig
> > index ee2e69a9ecd1..41eda578d08e 100644
> > --- a/sound/Kconfig
> > +++ b/sound/Kconfig
> > @@ -54,7 +54,8 @@ config SOUND_OSS_CORE_PRECLAIM
> >
> >           If unsure, say Y.
> >
> > -source "sound/oss/dmasound/Kconfig"
> > +### TO-BE-REMOVED
> > +# source "sound/oss/dmasound/Kconfig"
> 
> Please note the dmasound drivers do not have ALSA equivalents.

These belong to the latter, "dead old and inactive" ones :)

Are these driver still used with the latest kernel?  If users are
willing to help, we can provide the port to ALSA drivers, too.


thanks,

Takashi

Re: [alsa-devel] future of sounds/oss

[Geert Uytterhoeven]

Hi Iwai-san,

On Fri, May 12, 2017 at 9:10 AM, Takashi Iwai <tiwai@suse.de> wrote:
> On Fri, 12 May 2017 09:03:07 +0200,
> Geert Uytterhoeven wrote:
>> On Thu, May 11, 2017 at 10:21 PM, Takashi Iwai <tiwai@suse.de> wrote:
>> > From: Takashi Iwai <tiwai@suse.de>
>> > Subject: [PATCH] sound: Disable the build of OSS drivers
>> >
>> > OSS drivers are left as badly unmaintained, and now we're facing a
>> > problem to clean up the hackish set_fs() usage in their codes.  Since
>> > most of drivers have been covered by ALSA, and the others are dead old
>> > and inactive, let's leave them RIP.
>> >
>> > This patch is the first step: disable the build of OSS drivers.
>> > We'll eventually drop the whole codes and clean up later.
>> >
>> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
>> > ---
>> >  sound/Kconfig | 26 ++++++++++++++------------
>> >  1 file changed, 14 insertions(+), 12 deletions(-)
>> >
>> > diff --git a/sound/Kconfig b/sound/Kconfig
>> > index ee2e69a9ecd1..41eda578d08e 100644
>> > --- a/sound/Kconfig
>> > +++ b/sound/Kconfig
>> > @@ -54,7 +54,8 @@ config SOUND_OSS_CORE_PRECLAIM
>> >
>> >           If unsure, say Y.
>> >
>> > -source "sound/oss/dmasound/Kconfig"
>> > +### TO-BE-REMOVED
>> > +# source "sound/oss/dmasound/Kconfig"
>>
>> Please note the dmasound drivers do not have ALSA equivalents.
>
> These belong to the latter, "dead old and inactive" ones :)
>
> Are these driver still used with the latest kernel?  If users are

I believe so.

> willing to help, we can provide the port to ALSA drivers, too.

That would be great, thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [alsa-devel] future of sounds/oss

[Takashi Iwai]

On Fri, 12 May 2017 09:17:35 +0200,
Geert Uytterhoeven wrote:
> 
> Hi Iwai-san,
> 
> On Fri, May 12, 2017 at 9:10 AM, Takashi Iwai <tiwai@suse.de> wrote:
> > On Fri, 12 May 2017 09:03:07 +0200,
> > Geert Uytterhoeven wrote:
> >> On Thu, May 11, 2017 at 10:21 PM, Takashi Iwai <tiwai@suse.de> wrote:
> >> > From: Takashi Iwai <tiwai@suse.de>
> >> > Subject: [PATCH] sound: Disable the build of OSS drivers
> >> >
> >> > OSS drivers are left as badly unmaintained, and now we're facing a
> >> > problem to clean up the hackish set_fs() usage in their codes.  Since
> >> > most of drivers have been covered by ALSA, and the others are dead old
> >> > and inactive, let's leave them RIP.
> >> >
> >> > This patch is the first step: disable the build of OSS drivers.
> >> > We'll eventually drop the whole codes and clean up later.
> >> >
> >> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> >> > ---
> >> >  sound/Kconfig | 26 ++++++++++++++------------
> >> >  1 file changed, 14 insertions(+), 12 deletions(-)
> >> >
> >> > diff --git a/sound/Kconfig b/sound/Kconfig
> >> > index ee2e69a9ecd1..41eda578d08e 100644
> >> > --- a/sound/Kconfig
> >> > +++ b/sound/Kconfig
> >> > @@ -54,7 +54,8 @@ config SOUND_OSS_CORE_PRECLAIM
> >> >
> >> >           If unsure, say Y.
> >> >
> >> > -source "sound/oss/dmasound/Kconfig"
> >> > +### TO-BE-REMOVED
> >> > +# source "sound/oss/dmasound/Kconfig"
> >>
> >> Please note the dmasound drivers do not have ALSA equivalents.
> >
> > These belong to the latter, "dead old and inactive" ones :)
> >
> > Are these driver still used with the latest kernel?  If users are
> 
> I believe so.
> 
> > willing to help, we can provide the port to ALSA drivers, too.
> 
> That would be great, thanks!

OK, we can go forward, then.

But, looking at the tree again, I noticed that ALSA isn't built yet at
all for m68k.  I don't remember why it's disabled.
Jaroslav, do you know the reason behind it?

And, dmasound is a completely different implementation from the other
OSS, thus it doesn't suffer from set_fs() hack.  That is, we may still
keep dmasound, while removing other OSS stuff.

Meanwhile we'll try to support ALSA on m64k and eventually target to
drop dmasound stuff.

Does it sound more feasible?


thanks,

Takashi

Re: [alsa-devel] future of sounds/oss

[Geert Uytterhoeven]

Hi Iwai-san,

On Fri, May 12, 2017 at 9:27 AM, Takashi Iwai <tiwai@suse.de> wrote:
> On Fri, 12 May 2017 09:17:35 +0200,
> Geert Uytterhoeven wrote:
>> On Fri, May 12, 2017 at 9:10 AM, Takashi Iwai <tiwai@suse.de> wrote:
>> > On Fri, 12 May 2017 09:03:07 +0200,
>> > Geert Uytterhoeven wrote:
>> >> On Thu, May 11, 2017 at 10:21 PM, Takashi Iwai <tiwai@suse.de> wrote:
>> >> > index ee2e69a9ecd1..41eda578d08e 100644
>> >> > --- a/sound/Kconfig
>> >> > +++ b/sound/Kconfig
>> >> > @@ -54,7 +54,8 @@ config SOUND_OSS_CORE_PRECLAIM
>> >> >
>> >> >           If unsure, say Y.
>> >> >
>> >> > -source "sound/oss/dmasound/Kconfig"
>> >> > +### TO-BE-REMOVED
>> >> > +# source "sound/oss/dmasound/Kconfig"
>> >>
>> >> Please note the dmasound drivers do not have ALSA equivalents.
>> >
>> > These belong to the latter, "dead old and inactive" ones :)
>> >
>> > Are these driver still used with the latest kernel?  If users are
>>
>> I believe so.
>>
>> > willing to help, we can provide the port to ALSA drivers, too.
>>
>> That would be great, thanks!
>
> OK, we can go forward, then.
>
> But, looking at the tree again, I noticed that ALSA isn't built yet at
> all for m68k.  I don't remember why it's disabled.
> Jaroslav, do you know the reason behind it?

Because ALSA doesn't have any drivers that can be used on m68k platforms?

> And, dmasound is a completely different implementation from the other
> OSS, thus it doesn't suffer from set_fs() hack.  That is, we may still
> keep dmasound, while removing other OSS stuff.

That's indeed good to know.

> Meanwhile we'll try to support ALSA on m64k and eventually target to
> drop dmasound stuff.
>
> Does it sound more feasible?

Yes, definitely in the short run ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [alsa-devel] future of sounds/oss

[Takashi Iwai]

On Fri, 12 May 2017 09:30:04 +0200,
Geert Uytterhoeven wrote:
> 
> Hi Iwai-san,
> 
> On Fri, May 12, 2017 at 9:27 AM, Takashi Iwai <tiwai@suse.de> wrote:
> > On Fri, 12 May 2017 09:17:35 +0200,
> > Geert Uytterhoeven wrote:
> >> On Fri, May 12, 2017 at 9:10 AM, Takashi Iwai <tiwai@suse.de> wrote:
> >> > On Fri, 12 May 2017 09:03:07 +0200,
> >> > Geert Uytterhoeven wrote:
> >> >> On Thu, May 11, 2017 at 10:21 PM, Takashi Iwai <tiwai@suse.de> wrote:
> >> >> > index ee2e69a9ecd1..41eda578d08e 100644
> >> >> > --- a/sound/Kconfig
> >> >> > +++ b/sound/Kconfig
> >> >> > @@ -54,7 +54,8 @@ config SOUND_OSS_CORE_PRECLAIM
> >> >> >
> >> >> >           If unsure, say Y.
> >> >> >
> >> >> > -source "sound/oss/dmasound/Kconfig"
> >> >> > +### TO-BE-REMOVED
> >> >> > +# source "sound/oss/dmasound/Kconfig"
> >> >>
> >> >> Please note the dmasound drivers do not have ALSA equivalents.
> >> >
> >> > These belong to the latter, "dead old and inactive" ones :)
> >> >
> >> > Are these driver still used with the latest kernel?  If users are
> >>
> >> I believe so.
> >>
> >> > willing to help, we can provide the port to ALSA drivers, too.
> >>
> >> That would be great, thanks!
> >
> > OK, we can go forward, then.
> >
> > But, looking at the tree again, I noticed that ALSA isn't built yet at
> > all for m68k.  I don't remember why it's disabled.
> > Jaroslav, do you know the reason behind it?
> 
> Because ALSA doesn't have any drivers that can be used on m68k platforms?

But we have virtual and generic drivers (such as UART support), so
there seems no reason to stop it.  Maybe the lack of proper MMU
support was the reason?  Let's try to cross-build...

> > And, dmasound is a completely different implementation from the other
> > OSS, thus it doesn't suffer from set_fs() hack.  That is, we may still
> > keep dmasound, while removing other OSS stuff.
> 
> That's indeed good to know.
> 
> > Meanwhile we'll try to support ALSA on m64k and eventually target to
> > drop dmasound stuff.
> >
> > Does it sound more feasible?
> 
> Yes, definitely in the short run ;-)

OK, below is the revised patch.  Now it's a really one-liner.


thanks,

Takashi

-- 8< --
From: Takashi Iwai <tiwai@suse.de>
Subject: [PATCH v3] sound: Disable the build of OSS drivers

OSS drivers are left as badly unmaintained, and now we're facing a
problem to clean up the hackish set_fs() usage in their codes.  Since
most of drivers have been covered by ALSA, and the others are dead old
and inactive, let's leave them RIP.

This patch is the first step: disable the build of OSS drivers.
We'll eventually drop the whole codes and clean up later.

Note that sound/oss/dmasound is still kept, since it's a completely
different implementation of OSS, and it doesn't suffer from set_fs()
hack.  Moreover, the build of ALSA is disabled on M68K by some reason,
thus disabling it shall result in a regression.  This one will be
disabled / removed once when we add the support in ALSA side.

Tested-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

v1->v2: Smaller changes, as Linus and Randy suggested.
	The first dmasound Kconfig inclusion is still commented out since
	it's shorter/simpler in the end.
v2->v3: Keep dmasound, as it's independent from other OSS
	implementations.

 sound/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/Kconfig b/sound/Kconfig
index ee2e69a9ecd1..6a215a8c0490 100644
--- a/sound/Kconfig
+++ b/sound/Kconfig
@@ -115,6 +115,7 @@ endif # SND
 menuconfig SOUND_PRIME
 	tristate "Open Sound System (DEPRECATED)"
 	select SOUND_OSS_CORE
+	depends on BROKEN
 	help
 	  Say 'Y' or 'M' to enable Open Sound System drivers.
 
-- 
2.12.2

Re: [alsa-devel] future of sounds/oss

[Geert Uytterhoeven]

Hi Iwai-san,

On Fri, May 12, 2017 at 10:01 AM, Takashi Iwai <tiwai@suse.de> wrote:
>> > But, looking at the tree again, I noticed that ALSA isn't built yet at
>> > all for m68k.  I don't remember why it's disabled.
>> > Jaroslav, do you know the reason behind it?
>>
>> Because ALSA doesn't have any drivers that can be used on m68k platforms?
>
> But we have virtual and generic drivers (such as UART support), so
> there seems no reason to stop it.  Maybe the lack of proper MMU

It seems to date back to the move of sound from arch/*/Kconfig
to sound/Kconfig. I guess at that time there was just no use for ALSO on
m68k.

> support was the reason?  Let's try to cross-build...

Building seems to work fine...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [alsa-devel] future of sounds/oss

[Takashi Iwai]

On Tue, 16 May 2017 09:45:04 +0200,
Geert Uytterhoeven wrote:
> 
> Hi Iwai-san,
> 
> On Fri, May 12, 2017 at 10:01 AM, Takashi Iwai <tiwai@suse.de> wrote:
> >> > But, looking at the tree again, I noticed that ALSA isn't built yet at
> >> > all for m68k.  I don't remember why it's disabled.
> >> > Jaroslav, do you know the reason behind it?
> >>
> >> Because ALSA doesn't have any drivers that can be used on m68k platforms?
> >
> > But we have virtual and generic drivers (such as UART support), so
> > there seems no reason to stop it.  Maybe the lack of proper MMU
> 
> It seems to date back to the move of sound from arch/*/Kconfig
> to sound/Kconfig. I guess at that time there was just no use for ALSO on
> m68k.
> 
> > support was the reason?  Let's try to cross-build...
> 
> Building seems to work fine...

Worked fine with my cross-build test, too.
OK, let's enable the build on 4.13.  The patch is attached below.


thanks,

Takashi

-- 8< --
From: Takashi Iwai <tiwai@suse.de>
Subject: [PATCH] ALSA: Enable build with m68k

By some reason in the ancient history, we disabled the build of ALSA
drivers for m68k.  Since we'd like to move sound/oss/dmasound stuff
into ALSA for the complete drop of the legacy OSS stuff, let's try to
start building with m68k.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/Kconfig b/sound/Kconfig
index ee2e69a9ecd1..6437e398b08e 100644
--- a/sound/Kconfig
+++ b/sound/Kconfig
@@ -56,7 +56,7 @@ config SOUND_OSS_CORE_PRECLAIM
 
 source "sound/oss/dmasound/Kconfig"
 
-if !M68K && !UML
+if !UML
 
 menuconfig SND
 	tristate "Advanced Linux Sound Architecture"
@@ -124,7 +124,7 @@ source "sound/oss/Kconfig"
 
 endif # SOUND_PRIME
 
-endif # !M68K
+endif # !UML
 
 endif # SOUND
 
-- 
2.12.2

Re: [alsa-devel] future of sounds/oss

[John Paul Adrian Glaubitz]

On Fri, May 12, 2017 at 09:27:56AM +0200, Takashi Iwai wrote:
> But, looking at the tree again, I noticed that ALSA isn't built yet at
> all for m68k.  I don't remember why it's disabled.
> Jaroslav, do you know the reason behind it?

Might also just be because the m68k port had been dead in Debian for a
while due the lack of TLS support in glibc on m68k. However, the port
is active again and in pretty good shape now.

I'm currently working on fixing debian-installer on m68k, so that
people can install the port without having to resort to things like
debootstrap.

> And, dmasound is a completely different implementation from the other
> OSS, thus it doesn't suffer from set_fs() hack.  That is, we may still
> keep dmasound, while removing other OSS stuff.

Thanks! Highly appreciated.

> Meanwhile we'll try to support ALSA on m64k and eventually target to
> drop dmasound stuff.

Ooooh, that would be awesome. If you need any testers on m68k, please
let us know. I have plenty of m68k hardware for testing.

> Does it sound more feasible?

No idea whether it's feasible. But it sounds awesome :).

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913