From: "Günther Noack" <gnoack3000@gmail.com>
To: Matthieu Buffet <matthieu@buffet.re>
Cc: "Alejandro Colomar" <alx@kernel.org>,
"Mickaël Salaün" <mic@digikod.net>,
linux-man@vger.kernel.org
Subject: Re: [PATCH v2 1/2] man/man2/landlock_add_rule.2: Clarify ephemeral port range
Date: Fri, 6 Nov 2026 22:24:11 +0100 [thread overview]
Message-ID: <20261106.4250707004c3@gnoack.org> (raw)
In-Reply-To: <20261102233932.29912-1-matthieu@buffet.re>
On Tue, Nov 03, 2026 at 12:39:31AM +0100, Matthieu Buffet wrote:
> Clarify that ephemeral port range can differ from system to system, and
> that an application can choose exactly which ephemeral port will be
> chosen next (as long as it is within the kernel-wide
> ip_local_port_range).
>
> Signed-off-by: Matthieu Buffet <matthieu@buffet.re>
> ---
> man/man2/landlock_add_rule.2 | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/man/man2/landlock_add_rule.2 b/man/man2/landlock_add_rule.2
> index 94bc63068935..253498bfa2cf 100644
> --- a/man/man2/landlock_add_rule.2
> +++ b/man/man2/landlock_add_rule.2
> @@ -109,9 +109,13 @@ is the network port in host endianness.
> It should be noted that port 0 passed to
> .BR bind (2)
> will bind to an available port from the ephemeral port range.
> -This can be configured in the
> +The range is configured globally in the
> .I /proc/sys/net/ipv4/ip_local_port_range
> -sysctl (also used for IPv6).
> +sysctl (also used for IPv6),
> +and can be further restricted per socket using
> +.BR setsockopt (2)
> +with
> +.BR IP_LOCAL_PORT_RANGE (2const).
> .IP
> A Landlock rule with port 0
> and the
>
> base-commit: c189a6b2e4dd2e74f3b360b24e489e27f4e45bad
> --
> 2.47.3
>
Reviewed-by: Günther Noack <gnoack3000@gmail.com>
I think Mickaël's Reviewed-by from [1] should also count since you
addressed the grammar nit from [2].
The high level remark from [2] still stands, please don't forget to
ideally update the kernel documentation in line with these changes, so
that it uses the same wording on both sides.
Thanks,
–Günther
[1] https://lore.kernel.org/all/20260929.hooQuaaf9An5@digikod.net/
[2] https://lore.kernel.org/all/20260926.6c13f561a21f@gnoack.org/
next prev parent reply other threads:[~2026-11-06 21:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 7:58 [PATCH 0/3] Add Landlock UDP support documentation Matthieu Buffet
2026-09-17 7:58 ` [PATCH 1/3] man/man2/landlock_add_rule.2: Clarify ephemeral port range Matthieu Buffet
2026-09-26 10:00 ` Günther Noack
2026-09-29 19:02 ` Mickaël Salaün
2026-09-17 7:58 ` [PATCH 2/3] man/man7/landlock.7: Document AF_UNSPEC behaviour and error codes Matthieu Buffet
2026-09-26 10:13 ` Günther Noack
2026-09-17 7:58 ` [PATCH 3/3] man/man7/landlock.7, man/man2/landlock_add_rule.2: Document UDP support Matthieu Buffet
2026-09-26 14:01 ` Günther Noack
2026-09-29 19:03 ` Mickaël Salaün
2026-09-29 19:02 ` [PATCH 0/3] Add Landlock UDP support documentation Mickaël Salaün
2026-10-30 19:24 ` Günther Noack
2026-11-02 23:37 ` Matthieu Buffet
2026-11-02 23:39 ` [PATCH v2 1/2] man/man2/landlock_add_rule.2: Clarify ephemeral port range Matthieu Buffet
2026-11-02 23:39 ` [PATCH v2 2/2] man/man?/landlock*.?: Document UDP support Matthieu Buffet
2026-11-06 22:02 ` Günther Noack
2026-11-07 11:15 ` Alejandro Colomar
2026-11-06 21:24 ` Günther Noack [this message]
2026-11-07 11:10 ` [PATCH v2 1/2] man/man2/landlock_add_rule.2: Clarify ephemeral port range Alejandro Colomar
2026-11-03 0:24 ` [PATCH 0/3] Add Landlock UDP support documentation Alejandro Colomar
2026-11-03 9:04 ` Matthieu Buffet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261106.4250707004c3@gnoack.org \
--to=gnoack3000@gmail.com \
--cc=alx@kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=matthieu@buffet.re \
--cc=mic@digikod.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox