From: Quentin Monnet <quentin@isovalent.com>
To: Jakub Wilk <jwilk@jwilk.net>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
bpf@vger.kernel.org, Alejandro Colomar <alx.manpages@gmail.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
linux-man@vger.kernel.org
Subject: Re: [PATCH bpf-next v2] bpf: Fix a few typos in BPF helpers documentation
Date: Thu, 25 Aug 2022 15:48:20 +0100 [thread overview]
Message-ID: <40a62a75-1548-88ff-e536-dcbf3350db01@isovalent.com> (raw)
In-Reply-To: <20220825142256.of3glbnwi77kgkzo@jwilk.net>
On 25/08/2022 15:22, Jakub Wilk wrote:
> * Quentin Monnet <quentin@isovalent.com>, 2022-08-25 12:02:
>> --- a/tools/include/uapi/linux/bpf.h
>> +++ b/tools/include/uapi/linux/bpf.h
>> @@ -79,7 +79,7 @@ struct bpf_insn {
>> /* Key of an a BPF_MAP_TYPE_LPM_TRIE entry */
>> struct bpf_lpm_trie_key {
>> __u32 prefixlen; /* up to 32 for AF_INET, 128 for AF_INET6 */
>> - __u8 data[0]; /* Arbitrary size */
>> + __u8 data[]; /* Arbitrary size */
>> };
>
> This hunk picks the change from 94dfc73e7cf4 ("treewide: uapi: Replace
> zero-length arrays with flexible-array members").
>
> A bit weird to see it in a spelling-fix patch though. Wouldn't it be
> better to put it in a separate one?
>
This has happened several times in the past, and the change is small
enough I thought it wouldn't matter much. I can send another version if
it's more convenient, though.
Quentin
next prev parent reply other threads:[~2022-08-25 14:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 11:02 [PATCH bpf-next v2] bpf: Fix a few typos in BPF helpers documentation Quentin Monnet
2022-08-25 14:22 ` Jakub Wilk
2022-08-25 14:48 ` Quentin Monnet [this message]
2022-08-25 14:57 ` Alexei Starovoitov
2022-08-25 15:23 ` Quentin Monnet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40a62a75-1548-88ff-e536-dcbf3350db01@isovalent.com \
--to=quentin@isovalent.com \
--cc=alx.manpages@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=jwilk@jwilk.net \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=sdf@google.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox