[PATCH 1/2] filesystems.5: fix link to userspace tooling for ncpfs

[PATCH 1/2] filesystems.5: fix link to userspace tooling for ncpfs

[Ahelenia Ziemiańska]

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

Corresponds to Linux commit 1b83df308f69a5a3cc59be03bd7fb23e4bcebd8e

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
---
 man5/filesystems.5 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man5/filesystems.5 b/man5/filesystems.5
index b44dba184..6ec2de9f0 100644
--- a/man5/filesystems.5
+++ b/man5/filesystems.5
@@ -158,7 +158,7 @@ Novell NetWare.
 To use
 .BR ncpfs ,
 you need special programs, which can be found at
-.UR ftp://linux01.gwdg.de\:/pub\:/ncpfs
+.UR ftp://ftp.gwdg.de\:/pub\:/linux\:/misc\:/ncpfs
 .UE .
 .TP
 .B nfs
-- 
2.20.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[PATCH 2/2] filesystems.5: note ncpfs removal from kernel

[Ahelenia Ziemiańska]

[-- Attachment #1: Type: text/plain, Size: 976 bytes --]

Relevant Linux commits:
 * moved to staging in 1bb8155080c652c4853e6228f8f0d262b3049699
   (describe: v4.15-rc1-129-g1bb8155080c6) in Nov 2017,
   described as "broken" and "obsolete"
 * purged in bd32895c750bcd2b511bf93917bf7ae723e3d0b6
   (describe: v4.17-rc3-1010-gbd32895c750b) in Jun 2018,
   "since no one has complained or even noticed it was gone"

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
---
 man5/filesystems.5 | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/man5/filesystems.5 b/man5/filesystems.5
index 6ec2de9f0..1eda05b22 100644
--- a/man5/filesystems.5
+++ b/man5/filesystems.5
@@ -160,6 +160,10 @@ To use
 you need special programs, which can be found at
 .UR ftp://ftp.gwdg.de\:/pub\:/linux\:/misc\:/ncpfs
 .UE .
+.IP
+The
+.B ncpfs
+filesystem was removed from the kernel in 4.17-rc4.
 .TP
 .B nfs
 is the network filesystem used to access disks located on remote computers.
-- 
2.20.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 2/2] filesystems.5: note ncpfs removal from kernel

[Alejandro Colomar (man-pages)]

Hi Ahelenia,

Thanks for the patch!

Could you remove the '-rc4' part from the version?
So that we show the first stable version where it was removed.

Thanks,

Alex


On 12/17/20 4:27 PM, Ahelenia Ziemiańska wrote:
> Relevant Linux commits:
>  * moved to staging in 1bb8155080c652c4853e6228f8f0d262b3049699
>    (describe: v4.15-rc1-129-g1bb8155080c6) in Nov 2017,
>    described as "broken" and "obsolete"
>  * purged in bd32895c750bcd2b511bf93917bf7ae723e3d0b6
>    (describe: v4.17-rc3-1010-gbd32895c750b) in Jun 2018,
>    "since no one has complained or even noticed it was gone"
> 
> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
> ---
>  man5/filesystems.5 | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/man5/filesystems.5 b/man5/filesystems.5
> index 6ec2de9f0..1eda05b22 100644
> --- a/man5/filesystems.5
> +++ b/man5/filesystems.5
> @@ -160,6 +160,10 @@ To use
>  you need special programs, which can be found at
>  .UR ftp://ftp.gwdg.de\:/pub\:/linux\:/misc\:/ncpfs
>  .UE .
> +.IP
> +The
> +.B ncpfs
> +filesystem was removed from the kernel in 4.17-rc4.
>  .TP
>  .B nfs
>  is the network filesystem used to access disks located on remote computers.
> 

-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es

Re: [PATCH 2/2] filesystems.5: note ncpfs removal from kernel

[Ahelenia Ziemiańska]

[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]

On Thu, Dec 17, 2020 at 05:23:06PM +0100, Alejandro Colomar (man-pages) wrote:
> Could you remove the '-rc4' part from the version?
> So that we show the first stable version where it was removed.
Sure thing, see updated scissor-patch below:

-- >8 --
Subject: [PATCH 2/2] filesystems.5: note ncpfs removal from kernel

Relevant Linux commits:
 * moved to staging in 1bb8155080c652c4853e6228f8f0d262b3049699
   (describe: v4.15-rc1-129-g1bb8155080c6) in Nov 2017,
   described as "broken" and "obsolete"
 * purged in bd32895c750bcd2b511bf93917bf7ae723e3d0b6
   (describe: v4.17-rc3-1010-gbd32895c750b) in Jun 2018,
   "since no one has complained or even noticed it was gone"

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
---
 man5/filesystems.5 | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/man5/filesystems.5 b/man5/filesystems.5
index 6ec2de9f0..1eda05b22 100644
--- a/man5/filesystems.5
+++ b/man5/filesystems.5
@@ -160,6 +160,10 @@ To use
 you need special programs, which can be found at
 .UR ftp://ftp.gwdg.de\:/pub\:/linux\:/misc\:/ncpfs
 .UE .
+.IP
+The
+.B ncpfs
+filesystem was removed from the kernel in 4.17.
 .TP
 .B nfs
 is the network filesystem used to access disks located on remote computers.
-- 
2.20.1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 2/2] filesystems.5: note ncpfs removal from kernel

[Alejandro Colomar (man-pages)]

Hi Ahelenia,

Please, could you append that into the first paragraph?
I feel 3 paragraphs is too much for a fs that has been already removed.

[
       ncpfs     is  a network filesystem that supports the NCP
                 protocol, used by Novell NetWare.  It was removed
                 from the kernel in 4.17.

                 To use ncpfs, you need special programs, which can
                 be found at ⟨ftp://linux01.gwdg.de/pub/ncpfs⟩.
]

Something like this.  This way, the "removed" notice is also closer to
the name.

Thanks,

Alex

P.S.: Sorry for not spotting this before :/

On 12/17/20 5:40 PM, Ahelenia Ziemiańska wrote:
> On Thu, Dec 17, 2020 at 05:23:06PM +0100, Alejandro Colomar (man-pages) wrote:
>> Could you remove the '-rc4' part from the version?
>> So that we show the first stable version where it was removed.
> Sure thing, see updated scissor-patch below:
> 
> -- >8 --
> Subject: [PATCH 2/2] filesystems.5: note ncpfs removal from kernel
> 
> Relevant Linux commits:
>  * moved to staging in 1bb8155080c652c4853e6228f8f0d262b3049699
>    (describe: v4.15-rc1-129-g1bb8155080c6) in Nov 2017,
>    described as "broken" and "obsolete"
>  * purged in bd32895c750bcd2b511bf93917bf7ae723e3d0b6
>    (describe: v4.17-rc3-1010-gbd32895c750b) in Jun 2018,
>    "since no one has complained or even noticed it was gone"
> 
> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
> ---
>  man5/filesystems.5 | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/man5/filesystems.5 b/man5/filesystems.5
> index 6ec2de9f0..1eda05b22 100644
> --- a/man5/filesystems.5
> +++ b/man5/filesystems.5
> @@ -160,6 +160,10 @@ To use
>  you need special programs, which can be found at
>  .UR ftp://ftp.gwdg.de\:/pub\:/linux\:/misc\:/ncpfs
>  .UE .
> +.IP
> +The
> +.B ncpfs
> +filesystem was removed from the kernel in 4.17.
>  .TP
>  .B nfs
>  is the network filesystem used to access disks located on remote computers.
> 

-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es

Re: [PATCH 2/2] filesystems.5: note ncpfs removal from kernel

[Ahelenia Ziemiańska]

[-- Attachment #1: Type: text/plain, Size: 1765 bytes --]

On Thu, Dec 17, 2020 at 05:56:00PM +0100, Alejandro Colomar (man-pages) wrote:
> Hi Ahelenia,
> 
> Please, could you append that into the first paragraph?
Sure, see updated scissor-patch below.

I also broke the line above on the comma, because the alternative would
be either
  is a network filesystem that supports the NCP protocol, used by
  Novell NetWare. It was removed from the kernel in 4.17.
which sucks for reasons I assume obvious, or
  is a network filesystem that supports the NCP protocol, used by
  Novell NetWare.
  It was removed from the kernel in 4.17.
which is three lines anyway.

-- >8 --
Subject: [PATCH 2/2] filesystems.5: note ncpfs removal from kernel

Relevant Linux commits:
 * moved to staging in 1bb8155080c652c4853e6228f8f0d262b3049699
   (describe: v4.15-rc1-129-g1bb8155080c6) in Nov 2017,
   described as "broken" and "obsolete"
 * purged in bd32895c750bcd2b511bf93917bf7ae723e3d0b6
   (describe: v4.17-rc3-1010-gbd32895c750b) in Jun 2018,
   "since no one has complained or even noticed it was gone"

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
---
 man5/filesystems.5 | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/man5/filesystems.5 b/man5/filesystems.5
index 6ec2de9f0..71be05230 100644
--- a/man5/filesystems.5
+++ b/man5/filesystems.5
@@ -152,8 +152,9 @@ filenames can be no longer than 8 characters, followed by an
 optional period and 3 character extension.
 .TP
 .B ncpfs
-is a network filesystem that supports the NCP protocol, used by
-Novell NetWare.
+is a network filesystem that supports the NCP protocol,
+used by Novell NetWare.
+It was was removed from the kernel in 4.17.
 .IP
 To use
 .BR ncpfs ,
-- 
2.20.1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 2/2] filesystems.5: note ncpfs removal from kernel

[Alejandro Colomar (man-pages)]

Hi Ahelenia,

On 12/17/20 6:59 PM, Ahelenia Ziemiańska wrote:
> On Thu, Dec 17, 2020 at 05:56:00PM +0100, Alejandro Colomar (man-pages) wrote:
>> Hi Ahelenia,
>>
>> Please, could you append that into the first paragraph?
> Sure, see updated scissor-patch below.
> 
> I also broke the line above on the comma, because the alternative would
> be either

Thanks!

>   is a network filesystem that supports the NCP protocol, used by
>   Novell NetWare. It was removed from the kernel in 4.17.
> which sucks for reasons I assume obvious, or
>   is a network filesystem that supports the NCP protocol, used by
>   Novell NetWare.
>   It was removed from the kernel in 4.17.
> which is three lines anyway.
> 
> -- >8 --
> Subject: [PATCH 2/2] filesystems.5: note ncpfs removal from kernel
> 
> Relevant Linux commits:
>  * moved to staging in 1bb8155080c652c4853e6228f8f0d262b3049699
>    (describe: v4.15-rc1-129-g1bb8155080c6) in Nov 2017,
>    described as "broken" and "obsolete"
>  * purged in bd32895c750bcd2b511bf93917bf7ae723e3d0b6
>    (describe: v4.17-rc3-1010-gbd32895c750b) in Jun 2018,
>    "since no one has complained or even noticed it was gone">
> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

Patch applied.
Thanks for the detailed commit msg!

Cheers,

Alex

> ---
>  man5/filesystems.5 | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/man5/filesystems.5 b/man5/filesystems.5
> index 6ec2de9f0..71be05230 100644
> --- a/man5/filesystems.5
> +++ b/man5/filesystems.5
> @@ -152,8 +152,9 @@ filenames can be no longer than 8 characters, followed by an
>  optional period and 3 character extension.
>  .TP
>  .B ncpfs
> -is a network filesystem that supports the NCP protocol, used by
> -Novell NetWare.
> +is a network filesystem that supports the NCP protocol,
> +used by Novell NetWare.
> +It was was removed from the kernel in 4.17.
>  .IP
>  To use
>  .BR ncpfs ,
> 

-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es

Re: [PATCH 1/2] filesystems.5: fix link to userspace tooling for ncpfs

[Alejandro Colomar (man-pages)]

On 12/17/20 4:27 PM, Ahelenia Ziemiańska wrote:
> Corresponds to Linux commit 1b83df308f69a5a3cc59be03bd7fb23e4bcebd8e
> 
> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

Ahelenia, patch applied.

Thanks,

Alex

> ---
>  man5/filesystems.5 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man5/filesystems.5 b/man5/filesystems.5
> index b44dba184..6ec2de9f0 100644
> --- a/man5/filesystems.5
> +++ b/man5/filesystems.5
> @@ -158,7 +158,7 @@ Novell NetWare.
>  To use
>  .BR ncpfs ,
>  you need special programs, which can be found at
> -.UR ftp://linux01.gwdg.de\:/pub\:/ncpfs
> +.UR ftp://ftp.gwdg.de\:/pub\:/linux\:/misc\:/ncpfs
>  .UE .
>  .TP
>  .B nfs
> 

-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es