Re: [PATCH v1] man/man2/quotactl.2: tfix

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1456 bytes --]

Hi Jan,

On 2026-05-18T12:20:50+0200, Jan Kara wrote:
> On Sat 16-05-26 19:12:08, Alejandro Colomar wrote:
> > It seems most likely that this was a typo, and that Q_XQUOTAON was
> > meant.
> > 
> > Fixes: 1eeddf25 (2010-06-16; "quotactl.2: Major updates")
> > Cc: Jan Kara <jack@suse.cz>
> > Cc: Petr Gajdos <pgajdos@suse.cz>
> > Cc: Jan Blunck <jblunck@novell.com>
> > Signed-off-by: Alejandro Colomar <alx@kernel.org>
> 
> Right. Thanks for the fix. Feel free to add:

I have more questions about quotactl(2).  In the operations that ignore
the 'id' argument, am I right to assume that QCMD() is unnecessary?  My
assumption is because if there's no user or group ID to be used, it also
doesn't make sense to specify whether we want to affect a user or a
group.

So, for example, Q_QUOTAOFF would have the following synopsis:

	int quotactl(Q_QUOTAOFF, const char *_Nullable special, 0, NULL);

While Q_QUOTAON would have the following one:

	int quotactl(QCMD(Q_QUOTAON, type), const char *_Nullable special,
		     int fmt, caddr_t quota_path);

Is that correct?

Also, I wonder why caddr_t was used at all, instead of void*.  It seems
to unnecessarily require a cast, which could have been avoided with
void*.  In quotactl_fd(), since we need to use syscall(2), which is
variadic, I'll document the correct pointer types, instead of caddr_t*.


Have a lovely day!
Alex

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]