Linux Manual Pages development
 help / color / mirror / Atom feed
* Subject: [PATCH 0/1] inotify.7: Fix typo in struct size calculation
@ 2026-09-05  7:44 Maxim Inozemtsev
  2026-09-05  7:45 ` Maxim Inozemtsev
  2026-09-10 23:17 ` [PATCH v2] man/man7/inotify.7: " Alejandro Colomar
  0 siblings, 2 replies; 5+ messages in thread
From: Maxim Inozemtsev @ 2026-09-05  7:44 UTC (permalink / raw)
  To: alx; +Cc: linux-man

The documentation explains how the size of each `inotify_event` structure
is computed using fields from the structure itself. However, it mistakenly
uses the term `size` instead of `len` at the end of the math expression.

Since `len` is the actual field name indicating the bytes in `name`, fix
`sizeof(struct inotify_event)+size` to `sizeof(struct inotify_event)+len`.

Maxim Inozemtsev (1):
  inotify.7: Fix typo in struct size calculation

 man/man7/inotify.7 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.55.0

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Subject: [PATCH 0/1] inotify.7: Fix typo in struct size calculation
  2026-09-05  7:44 Subject: [PATCH 0/1] inotify.7: Fix typo in struct size calculation Maxim Inozemtsev
@ 2026-09-05  7:45 ` Maxim Inozemtsev
  2026-09-10 23:17 ` [PATCH v2] man/man7/inotify.7: " Alejandro Colomar
  1 sibling, 0 replies; 5+ messages in thread
From: Maxim Inozemtsev @ 2026-09-05  7:45 UTC (permalink / raw)
  To: alx; +Cc: linux-man

From 9b0b60cfd59dc5b89c59ec255ef7da77c0dbaf25 Mon Sep 17 00:00:00 2001
From: Maxim Inozemtsev <milnadar@gmail.com>
Date: Fri, 4 Sep 2026 00:12:32 -0700
Subject: [PATCH 1/1] inotify.7: Fix typo in struct size calculation

---
 man/man7/inotify.7 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man/man7/inotify.7 b/man/man7/inotify.7
index 9575b82e7..675f86f4b 100644
--- a/man/man7/inotify.7
+++ b/man/man7/inotify.7
@@ -137,7 +137,7 @@ including the null bytes;
 the size of each
 .I inotify_event
 structure is thus
-.IR "sizeof(struct inotify_event)+size" .
+.IR "sizeof(struct inotify_event)+len" .
 .P
 The behavior when the buffer given to
 .BR read (2)
-- 
2.55.0


On Sat, Sep 5, 2026 at 12:44 AM Maxim Inozemtsev <milnadar@gmail.com> wrote:
>
> The documentation explains how the size of each `inotify_event` structure
> is computed using fields from the structure itself. However, it mistakenly
> uses the term `size` instead of `len` at the end of the math expression.
>
> Since `len` is the actual field name indicating the bytes in `name`, fix
> `sizeof(struct inotify_event)+size` to `sizeof(struct inotify_event)+len`.
>
> Maxim Inozemtsev (1):
>   inotify.7: Fix typo in struct size calculation
>
>  man/man7/inotify.7 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.55.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2] man/man7/inotify.7: Fix typo in struct size calculation
  2026-09-05  7:44 Subject: [PATCH 0/1] inotify.7: Fix typo in struct size calculation Maxim Inozemtsev
  2026-09-05  7:45 ` Maxim Inozemtsev
@ 2026-09-10 23:17 ` Alejandro Colomar
  2026-09-19  6:05   ` Maxim Inozemtsev
  1 sibling, 1 reply; 5+ messages in thread
From: Alejandro Colomar @ 2026-09-10 23:17 UTC (permalink / raw)
  To: linux-man; +Cc: Maxim Inozemtsev, Alejandro Colomar

[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]

From: Maxim Inozemtsev <milnadar@gmail.com>

Fixes: 18e7c4597c4e (2024-11-17; "man/: Terminology consistency reforms (n, size, length)")
Co-authored-by: Maxim Inozemtsev <milnadar@gmail.com>
Message-ID: <CAE8uRQ1WhW=5X-zCCi4g9y4s-rEYdmY_=2o4Re1thKyijV3RXw@mail.gmail.com>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
---

Hi Maxim,

I've slightly modified your patch, to be more correct, and show that
'len' isn't just a variable, but a structure member.

Do you like this patch?  If so, would you mind signing it?
<https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by>


Have a lovely night!
Alex

 man/man7/inotify.7 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man/man7/inotify.7 b/man/man7/inotify.7
index 9575b82e7ffb..dcdf95d0665c 100644
--- a/man/man7/inotify.7
+++ b/man/man7/inotify.7
@@ -137,7 +137,7 @@ .SS Reading events from an inotify file descriptor
 the size of each
 .I inotify_event
 structure is thus
-.IR "sizeof(struct inotify_event)+size" .
+.IR sizeof(struct\~inotify_event)\~+\~event.len .
 .P
 The behavior when the buffer given to
 .BR read (2)

base-commit: 93337ae940c227db2b4a6141268a41b222df4283
-- 
2.55.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] man/man7/inotify.7: Fix typo in struct size calculation
  2026-09-10 23:17 ` [PATCH v2] man/man7/inotify.7: " Alejandro Colomar
@ 2026-09-19  6:05   ` Maxim Inozemtsev
  2026-09-19 10:10     ` Alejandro Colomar
  0 siblings, 1 reply; 5+ messages in thread
From: Maxim Inozemtsev @ 2026-09-19  6:05 UTC (permalink / raw)
  To: Alejandro Colomar; +Cc: linux-man

I like your corrections.
Please see my sign-off for this patch below:

Signed-off by: Maxim Inozemtsev <milnadar@gmail.com>

Thank you,
Maxim

On Thu, Sep 10, 2026 at 4:17 PM Alejandro Colomar <alx@kernel.org> wrote:
>
> From: Maxim Inozemtsev <milnadar@gmail.com>
>
> Fixes: 18e7c4597c4e (2024-11-17; "man/: Terminology consistency reforms (n, size, length)")
> Co-authored-by: Maxim Inozemtsev <milnadar@gmail.com>
> Message-ID: <CAE8uRQ1WhW=5X-zCCi4g9y4s-rEYdmY_=2o4Re1thKyijV3RXw@mail.gmail.com>
> Signed-off-by: Alejandro Colomar <alx@kernel.org>
> ---
>
> Hi Maxim,
>
> I've slightly modified your patch, to be more correct, and show that
> 'len' isn't just a variable, but a structure member.
>
> Do you like this patch?  If so, would you mind signing it?
> <https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by>
>
>
> Have a lovely night!
> Alex
>
>  man/man7/inotify.7 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man/man7/inotify.7 b/man/man7/inotify.7
> index 9575b82e7ffb..dcdf95d0665c 100644
> --- a/man/man7/inotify.7
> +++ b/man/man7/inotify.7
> @@ -137,7 +137,7 @@ .SS Reading events from an inotify file descriptor
>  the size of each
>  .I inotify_event
>  structure is thus
> -.IR "sizeof(struct inotify_event)+size" .
> +.IR sizeof(struct\~inotify_event)\~+\~event.len .
>  .P
>  The behavior when the buffer given to
>  .BR read (2)
>
> base-commit: 93337ae940c227db2b4a6141268a41b222df4283
> --
> 2.55.0
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] man/man7/inotify.7: Fix typo in struct size calculation
  2026-09-19  6:05   ` Maxim Inozemtsev
@ 2026-09-19 10:10     ` Alejandro Colomar
  0 siblings, 0 replies; 5+ messages in thread
From: Alejandro Colomar @ 2026-09-19 10:10 UTC (permalink / raw)
  To: Maxim Inozemtsev; +Cc: linux-man

[-- Attachment #1: Type: text/plain, Size: 1997 bytes --]

Hi Maxim,

> Date: 2026-09-18 23:05:58-0700
> From: Maxim Inozemtsev <milnadar@gmail.com>
>
> I like your corrections.
> Please see my sign-off for this patch below:
> 
> Signed-off by: Maxim Inozemtsev <milnadar@gmail.com>

Thanks!

I had pushed the patch already some days ago, so I can't append your
signature, but still thanks!  I'll remain here in the list.  :)


Have a lovely day!
Alex

> 
> Thank you,
> Maxim
> 
> On Thu, Sep 10, 2026 at 4:17 PM Alejandro Colomar <alx@kernel.org> wrote:
> >
> > From: Maxim Inozemtsev <milnadar@gmail.com>
> >
> > Fixes: 18e7c4597c4e (2024-11-17; "man/: Terminology consistency reforms (n, size, length)")
> > Co-authored-by: Maxim Inozemtsev <milnadar@gmail.com>
> > Message-ID: <CAE8uRQ1WhW=5X-zCCi4g9y4s-rEYdmY_=2o4Re1thKyijV3RXw@mail.gmail.com>
> > Signed-off-by: Alejandro Colomar <alx@kernel.org>
> > ---
> >
> > Hi Maxim,
> >
> > I've slightly modified your patch, to be more correct, and show that
> > 'len' isn't just a variable, but a structure member.
> >
> > Do you like this patch?  If so, would you mind signing it?
> > <https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by>
> >
> >
> > Have a lovely night!
> > Alex
> >
> >  man/man7/inotify.7 | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/man/man7/inotify.7 b/man/man7/inotify.7
> > index 9575b82e7ffb..dcdf95d0665c 100644
> > --- a/man/man7/inotify.7
> > +++ b/man/man7/inotify.7
> > @@ -137,7 +137,7 @@ .SS Reading events from an inotify file descriptor
> >  the size of each
> >  .I inotify_event
> >  structure is thus
> > -.IR "sizeof(struct inotify_event)+size" .
> > +.IR sizeof(struct\~inotify_event)\~+\~event.len .
> >  .P
> >  The behavior when the buffer given to
> >  .BR read (2)
> >
> > base-commit: 93337ae940c227db2b4a6141268a41b222df4283
> > --
> > 2.55.0
> >
> 

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-09-19 10:10 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-05  7:44 Subject: [PATCH 0/1] inotify.7: Fix typo in struct size calculation Maxim Inozemtsev
2026-09-05  7:45 ` Maxim Inozemtsev
2026-09-10 23:17 ` [PATCH v2] man/man7/inotify.7: " Alejandro Colomar
2026-09-19  6:05   ` Maxim Inozemtsev
2026-09-19 10:10     ` Alejandro Colomar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox