Linux Manual Pages development
 help / color / mirror / Atom feed
From: Kuniyuki Iwashima <kuniyu@google.com>
To: "Günther Noack" <gnoack3000@gmail.com>
Cc: Alejandro Colomar <alx@kernel.org>, linux-man@vger.kernel.org
Subject: Re: [PATCH 4/8] man/man7/unix.7: Explain Abstract UDS scoping to the network namespace
Date: Tue, 27 Oct 2026 05:12:54 +0000	[thread overview]
Message-ID: <auAxv0HZ14Nz5xDi@google.com> (raw)
In-Reply-To: <20261026.dc0f52217f35@gnoack.org>

On Mon, 26 Oct 2026 22:11:56 +0100, Günther Noack wrote:
> Hello! Thanks for the review!
> 
> On Sat, Oct 24, 2026 at 05:39:52AM +0000, Kuniyuki Iwashima wrote:
> > On Wed, 21 Oct 2026 23:07:56 +0200, Günther Noack wrote:
> > > Point out that Abstract Unix Domain Sockets are visible within the
> > > current network namespace, unlike Named Unix Domain Sockets, where the
> > 
> > s/Named/pathname/.
> > 
> > pathname, unnamed, abstract are used in Address format section.
> 
> Thanks, fixed.
> 
> 
> > > remote socket is looked up through the mount namespace.
> > > 
> > > To avoid confusion, remove the word "namespace" from the subsequent
> > > paragraph, where it is used in a more colloquial form (there is no
> > > abstract socket namespace in the sense of namespaces(7)).
> > 
> > The change still uses "abstract socket namespace".
> 
> In the "Abstract Sockets" section, the word "namespace" is not used
> any more in the general sense, but only in the sense of a
> setns(2)/namespaces(7) namespace.
> 
> There are some places in the man page where the word "namespace" is
> still used colloquially, but these are not in the vicinity of this
> change and feel less prone to confusion.  Do you think I should update
> these all in the same commit?

I understand the "namespace" itself is a generic word but it
feels a bit odd as it most likely means CLONE_NEWXXX in Linux.

But fixing up all would be apparently boring, so I'll let you
decide, and leaving them as is is 100% fine ;)


> 
> 
> > > This is already described in network_namespaces(7) as well, but might
> > > be mentionworthy here too.
> > > 
> > > The lookup of Abtract addresses happens in __unix_find_socket_byname()
> > > in linux.git net/unix/af_unix.c, where it is looked up in the network
> > > namespace (struct net *net) in a hash table in that namespace:
> > > 
> > > 	sk_for_each(s, &net->unx.table.buckets[hash]) {
> > > 		// ...
> > > 	}
> > > 
> > > Cc: Kuniyuki Iwashima <kuniyu@google.com>
> > > Assisted-by: LLM
> > > Signed-off-by: Günther Noack <gnoack3000@gmail.com>
> > > ---
> > > 
> > > Notes:
> > >     Verified in code
> > > 
> > >  man/man7/unix.7 | 12 +++++++++++-
> > >  1 file changed, 11 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/man/man7/unix.7 b/man/man7/unix.7
> > > index 4c46b54206a5..232fdbf4c3cd 100644
> > > --- a/man/man7/unix.7
> > > +++ b/man/man7/unix.7
> > > @@ -257,7 +257,17 @@ has no effect on the accessibility of the socket.
> > >  Abstract sockets automatically disappear when all open references
> > >  to the socket are closed.
> > >  .P
> > > -The abstract socket namespace is a nonportable Linux extension.
> > > +Each network namespace has its own abstract socket namespace (see
> > > +.BR network_namespaces (7)):
> > 
> > Remove this sentence and...
> > 
> > 
> > > +a socket can connect or send to an abstract address
> > > +only if the socket bound to that address
> > > +is in the same network namespace.
> > 
> > add "(see network_namespaces (7))" here.
> 
> Good idea, that's shorter.
> 
> 
> > > +In contrast,
> > > +pathname sockets are not confined to a network namespace;
> > > +they can be reached from any network namespace
> > > +in which the socket file is accessible.
> > > +.P
> > > +Abstract sockets are a nonportable Linux extension.
> > >  .\"
> > >  .SS Socket options
> > >  For historical reasons, these socket options are specified with a
> > > -- 
> > > 2.56.0
> > > 
> 
> Thanks,
> –Günther

  reply	other threads:[~2026-10-27  5:12 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21 21:07 [PATCH 0/8] {unix,socket,bind}.7: General Unix Domain Socket fixes Günther Noack
2026-10-21 21:07 ` [PATCH 1/8] man/man7/socket.7: SO_PEEK_OFF: This option is no longer specific to unix(7) Günther Noack
2026-10-23 18:20   ` Alejandro Colomar
2026-10-26 20:48     ` Günther Noack
2026-10-24  5:27   ` Kuniyuki Iwashima
2026-10-21 21:07 ` [PATCH 2/8] man/man7/unix.7: SO_PEERCRED: Also works for SOCK_SEQPACKET Günther Noack
2026-10-24  5:28   ` Kuniyuki Iwashima
2026-10-21 21:07 ` [PATCH 3/8] man/man7/unix.7: SIOCINQ: Document behavior " Günther Noack
2026-10-24  5:34   ` Kuniyuki Iwashima
2026-10-26 20:59     ` Günther Noack
2026-10-21 21:07 ` [PATCH 4/8] man/man7/unix.7: Explain Abstract UDS scoping to the network namespace Günther Noack
2026-10-24  5:39   ` Kuniyuki Iwashima
2026-10-26 21:11     ` Günther Noack
2026-10-27  5:12       ` Kuniyuki Iwashima [this message]
2026-10-27  7:58         ` Günther Noack
2026-10-21 21:07 ` [PATCH 5/8] man/man7/unix.7: SOCK_RAW is accepted as an alias for SOCK_DGRAM Günther Noack
2026-10-24  5:44   ` Kuniyuki Iwashima
2026-10-26 21:13     ` Günther Noack
2026-10-21 21:07 ` [PATCH 6/8] man/man7/unix.7: ERRORS: EPROTONOSUPPORT: Protocol 0 is also accepted Günther Noack
2026-10-24  5:47   ` Kuniyuki Iwashima
2026-10-26 21:15     ` Günther Noack
2026-10-21 21:07 ` [PATCH 7/8] man/man2/bind.2: ERRORS: EACCES: Write permission on the directory is required Günther Noack
2026-10-24  5:56   ` Kuniyuki Iwashima
2026-10-24  5:58     ` Kuniyuki Iwashima
2026-10-26 21:16       ` Günther Noack
2026-10-21 21:08 ` [PATCH 8/8] man/man7/unix.7: ERRORS: Document EACCES, EAGAIN, EMSGSIZE, ENOSPC, and EPERM Günther Noack
2026-10-24  6:03   ` Kuniyuki Iwashima
2026-10-26 21:27     ` Günther Noack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auAxv0HZ14Nz5xDi@google.com \
    --to=kuniyu@google.com \
    --cc=alx@kernel.org \
    --cc=gnoack3000@gmail.com \
    --cc=linux-man@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox