Re: [PATCH v4 2/4] man/man5/tunables.conf: Document system-wide tunables config

[DJ Delorie <dj@redhat.com>]

Alejandro Colomar <alx@kernel.org> writes:
> A few minor comments below.

I'll defer a v5 until we finish discussing...

>> +The file may also contain
>> +.IR filters ,
>> +which limit the tunables following it,
>> +up to the end of the file
>> +(or end of the included file,
>> +or start of a new included file)
>
> I'd append within the parentheses:
> 	, whichever comes first

"first"?  Or "next"?

>> +or a line with only
>> +.B []
>> +on it.
>
> So, this is like an end-all-filters directive, right?
>
> I wonder something: Does a filter end previous filters, or do they
> compound until a [] ends them all?

There is only ever one filter active at a time.  It stops being the
active filter when another filter is encountered, or the current file
ends, or an include directive.  An empty filter spec (i.e. "[]") is a "no
filters" filter.  It acts as a "new filter" for the purpose of ending
the previous filter, but does not specify a new filter, so no new filter
is active after that.

If you can get that into five words or less, you win ;-)

>> +The syntax is:
>> +.P
>> +.in +4n
>> +.EX
>> +.RI [ filter : pattern ]
>
> Since '[', ':', and ']' are literal, let's put them in bold.  Thus, BI.

Done.