From: Tvrtko Ursulin <tursulin@ursulin.net>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
sumit.semwal@linaro.org
Cc: dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH 1/2] dma-buf/dma_fence_array: remove unused functionality v3
Date: Wed, 22 Apr 2026 11:49:56 +0100 [thread overview]
Message-ID: <096a34ce-fb73-4d56-81b4-aa6a0342c322@ursulin.net> (raw)
In-Reply-To: <20260422103012.1647-1-christian.koenig@amd.com>
On 22/04/2026 11:30, Christian König wrote:
> Amdgpu was the only user of the signal on any feature and we dropped
> that use case recently, so we can remove that functionality.
>
> v2: update num_pending only after the fence is signaled
> v3: separate out simplifying dma_fence_array implementation
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/dma-buf/dma-fence-array.c | 13 ++++---------
> drivers/dma-buf/dma-fence-unwrap.c | 3 +--
> drivers/dma-buf/dma-resv.c | 3 +--
> drivers/dma-buf/st-dma-fence-unwrap.c | 2 +-
> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 3 +--
> drivers/gpu/drm/xe/xe_sync.c | 2 +-
> drivers/gpu/drm/xe/xe_vm.c | 4 ++--
> include/linux/dma-fence-array.h | 6 ++----
> 8 files changed, 13 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/dma-buf/dma-fence-array.c b/drivers/dma-buf/dma-fence-array.c
> index 089f69469524..5e10e8df372f 100644
> --- a/drivers/dma-buf/dma-fence-array.c
> +++ b/drivers/dma-buf/dma-fence-array.c
> @@ -190,15 +190,13 @@ EXPORT_SYMBOL(dma_fence_array_alloc);
> * @fences: [in] array containing the fences
> * @context: [in] fence context to use
> * @seqno: [in] sequence number to use
> - * @signal_on_any: [in] signal on any fence in the array
> *
> * Implementation of @dma_fence_array_create without allocation. Useful to init
> * a preallocated dma fence array in the path of reclaim or dma fence signaling.
> */
> void dma_fence_array_init(struct dma_fence_array *array,
> int num_fences, struct dma_fence **fences,
> - u64 context, unsigned seqno,
> - bool signal_on_any)
> + u64 context, unsigned seqno)
> {
> static struct lock_class_key dma_fence_array_lock_key;
>
> @@ -222,7 +220,7 @@ void dma_fence_array_init(struct dma_fence_array *array,
> */
> lockdep_set_class(&array->base.inline_lock, &dma_fence_array_lock_key);
>
> - atomic_set(&array->num_pending, signal_on_any ? 1 : num_fences);
> + atomic_set(&array->num_pending, num_fences);
> array->fences = fences;
>
> array->base.error = PENDING_ERROR;
> @@ -249,7 +247,6 @@ EXPORT_SYMBOL(dma_fence_array_init);
> * @fences: [in] array containing the fences
> * @context: [in] fence context to use
> * @seqno: [in] sequence number to use
> - * @signal_on_any: [in] signal on any fence in the array
> *
> * Allocate a dma_fence_array object and initialize the base fence with
> * dma_fence_init().
> @@ -264,8 +261,7 @@ EXPORT_SYMBOL(dma_fence_array_init);
> */
> struct dma_fence_array *dma_fence_array_create(int num_fences,
> struct dma_fence **fences,
> - u64 context, unsigned seqno,
> - bool signal_on_any)
> + u64 context, unsigned seqno)
> {
> struct dma_fence_array *array;
>
> @@ -273,8 +269,7 @@ struct dma_fence_array *dma_fence_array_create(int num_fences,
> if (!array)
> return NULL;
>
> - dma_fence_array_init(array, num_fences, fences,
> - context, seqno, signal_on_any);
> + dma_fence_array_init(array, num_fences, fences, context, seqno);
>
> return array;
> }
> diff --git a/drivers/dma-buf/dma-fence-unwrap.c b/drivers/dma-buf/dma-fence-unwrap.c
> index 07fe9bf45aea..53bb40e70b27 100644
> --- a/drivers/dma-buf/dma-fence-unwrap.c
> +++ b/drivers/dma-buf/dma-fence-unwrap.c
> @@ -180,8 +180,7 @@ struct dma_fence *__dma_fence_unwrap_merge(unsigned int num_fences,
>
> if (count > 1) {
> result = dma_fence_array_create(count, array,
> - dma_fence_context_alloc(1),
> - 1, false);
> + dma_fence_context_alloc(1), 1);
> if (!result) {
> for (i = 0; i < count; i++)
> dma_fence_put(array[i]);
> diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c
> index ce9e6c04897f..39a92d9f2413 100644
> --- a/drivers/dma-buf/dma-resv.c
> +++ b/drivers/dma-buf/dma-resv.c
> @@ -648,8 +648,7 @@ int dma_resv_get_singleton(struct dma_resv *obj, enum dma_resv_usage usage,
> }
>
> array = dma_fence_array_create(count, fences,
> - dma_fence_context_alloc(1),
> - 1, false);
> + dma_fence_context_alloc(1), 1);
> if (!array) {
> while (count--)
> dma_fence_put(fences[count]);
> diff --git a/drivers/dma-buf/st-dma-fence-unwrap.c b/drivers/dma-buf/st-dma-fence-unwrap.c
> index 51c87869b7b8..4e7ee25372ba 100644
> --- a/drivers/dma-buf/st-dma-fence-unwrap.c
> +++ b/drivers/dma-buf/st-dma-fence-unwrap.c
> @@ -64,7 +64,7 @@ static struct dma_fence *mock_array(unsigned int num_fences, ...)
>
> array = dma_fence_array_create(num_fences, fences,
> dma_fence_context_alloc(1),
> - 1, false);
> + 1);
> if (!array)
> goto error_free;
> return &array->base;
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> index 942f4eed817f..4a1a9031f9db 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> @@ -3205,8 +3205,7 @@ eb_composite_fence_create(struct i915_execbuffer *eb, int out_fence_fd)
> fence_array = dma_fence_array_create(eb->num_batches,
> fences,
> eb->context->parallel.fence_context,
> - eb->context->parallel.seqno++,
> - false);
> + eb->context->parallel.seqno++);
> if (!fence_array) {
> kfree(fences);
> return ERR_PTR(-ENOMEM);
> diff --git a/drivers/gpu/drm/xe/xe_sync.c b/drivers/gpu/drm/xe/xe_sync.c
> index 24d6d9af20d6..37866768d64c 100644
> --- a/drivers/gpu/drm/xe/xe_sync.c
> +++ b/drivers/gpu/drm/xe/xe_sync.c
> @@ -376,7 +376,7 @@ xe_sync_in_fence_get(struct xe_sync_entry *sync, int num_sync,
> xe_assert(vm->xe, current_fence == num_fence);
> cf = dma_fence_array_create(num_fence, fences,
> dma_fence_context_alloc(1),
> - 1, false);
> + 1);
> if (!cf)
> goto err_out;
>
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index 56e2db50bb36..8f472911469d 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -3370,7 +3370,7 @@ static struct dma_fence *ops_execute(struct xe_vm *vm,
> goto err_trace;
> }
>
> - cf = dma_fence_array_alloc(n_fence);
> + cf = dma_fence_array_alloc();
Patch splitting mistake here.
The rest LGTM. So with this hunk dropped:
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Regards,
Tvrtko
> if (!cf) {
> fence = ERR_PTR(-ENOMEM);
> goto err_out;
> @@ -3414,7 +3414,7 @@ static struct dma_fence *ops_execute(struct xe_vm *vm,
>
> xe_assert(vm->xe, current_fence == n_fence);
> dma_fence_array_init(cf, n_fence, fences, dma_fence_context_alloc(1),
> - 1, false);
> + 1);
> fence = &cf->base;
>
> for_each_tile(tile, vm->xe, id) {
> diff --git a/include/linux/dma-fence-array.h b/include/linux/dma-fence-array.h
> index 370b3d2bba37..1b1d87579c38 100644
> --- a/include/linux/dma-fence-array.h
> +++ b/include/linux/dma-fence-array.h
> @@ -81,13 +81,11 @@ to_dma_fence_array(struct dma_fence *fence)
> struct dma_fence_array *dma_fence_array_alloc(int num_fences);
> void dma_fence_array_init(struct dma_fence_array *array,
> int num_fences, struct dma_fence **fences,
> - u64 context, unsigned seqno,
> - bool signal_on_any);
> + u64 context, unsigned seqno);
>
> struct dma_fence_array *dma_fence_array_create(int num_fences,
> struct dma_fence **fences,
> - u64 context, unsigned seqno,
> - bool signal_on_any);
> + u64 context, unsigned seqno);
>
> bool dma_fence_match_context(struct dma_fence *fence, u64 context);
>
next prev parent reply other threads:[~2026-04-22 10:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 10:30 [PATCH 1/2] dma-buf/dma_fence_array: remove unused functionality v3 Christian König
2026-04-22 10:30 ` [PATCH 2/2] dma-buf/dma_fence_array: optimize handling Christian König
2026-04-22 11:37 ` Tvrtko Ursulin
2026-05-04 14:55 ` Christian König
2026-05-04 15:55 ` Tvrtko Ursulin
2026-04-22 10:49 ` Tvrtko Ursulin [this message]
2026-05-04 14:46 ` [PATCH 1/2] dma-buf/dma_fence_array: remove unused functionality v3 Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=096a34ce-fb73-4d56-81b4-aa6a0342c322@ursulin.net \
--to=tursulin@ursulin.net \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox