Re: [PATCH 1/2] dma-buf/dma_fence_array: remove unused functionality v3

["Christian König" <christian.koenig@amd.com>]

On 4/22/26 12:49, Tvrtko Ursulin wrote:
> 
> On 22/04/2026 11:30, Christian König wrote:
...
>>   diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
>> index 56e2db50bb36..8f472911469d 100644
>> --- a/drivers/gpu/drm/xe/xe_vm.c
>> +++ b/drivers/gpu/drm/xe/xe_vm.c
>> @@ -3370,7 +3370,7 @@ static struct dma_fence *ops_execute(struct xe_vm *vm,
>>           goto err_trace;
>>       }
>>   -    cf = dma_fence_array_alloc(n_fence);
>> +    cf = dma_fence_array_alloc();
> 
> Patch splitting mistake here.

Ah, thanks for pointing this out.

> The rest LGTM. So with this hunk dropped:
> 
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>

I double checked the patch once more, compile tested it and then pushed the result.

Thanks,
Christian.

> 
> Regards,
> 
> Tvrtko
> 
>>       if (!cf) {
>>           fence = ERR_PTR(-ENOMEM);
>>           goto err_out;
>> @@ -3414,7 +3414,7 @@ static struct dma_fence *ops_execute(struct xe_vm *vm,
>>         xe_assert(vm->xe, current_fence == n_fence);
>>       dma_fence_array_init(cf, n_fence, fences, dma_fence_context_alloc(1),
>> -                 1, false);
>> +                 1);
>>       fence = &cf->base;
>>         for_each_tile(tile, vm->xe, id) {
>> diff --git a/include/linux/dma-fence-array.h b/include/linux/dma-fence-array.h
>> index 370b3d2bba37..1b1d87579c38 100644
>> --- a/include/linux/dma-fence-array.h
>> +++ b/include/linux/dma-fence-array.h
>> @@ -81,13 +81,11 @@ to_dma_fence_array(struct dma_fence *fence)
>>   struct dma_fence_array *dma_fence_array_alloc(int num_fences);
>>   void dma_fence_array_init(struct dma_fence_array *array,
>>                 int num_fences, struct dma_fence **fences,
>> -              u64 context, unsigned seqno,
>> -              bool signal_on_any);
>> +              u64 context, unsigned seqno);
>>     struct dma_fence_array *dma_fence_array_create(int num_fences,
>>                              struct dma_fence **fences,
>> -                           u64 context, unsigned seqno,
>> -                           bool signal_on_any);
>> +                           u64 context, unsigned seqno);
>>     bool dma_fence_match_context(struct dma_fence *fence, u64 context);
>>   
>