From: "Christian König" <christian.koenig@amd.com>
To: Andrew Davis <afd@ti.com>, Gerd Hoffmann <kraxel@redhat.com>,
Sumit Semwal <sumit.semwal@linaro.org>,
Paul Cercueil <paul@crapouillou.net>,
Vivek Kasireddy <vivek.kasireddy@intel.com>,
Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] udmabuf: Sync to attached devices
Date: Fri, 15 Aug 2025 11:41:17 +0200 [thread overview]
Message-ID: <0b963b02-dec0-4bf5-aea9-dbe3050716ee@amd.com> (raw)
In-Reply-To: <20250814161049.678672-1-afd@ti.com>
On 14.08.25 18:10, Andrew Davis wrote:
> Hello all,
>
> This series makes it so the udmabuf will sync the backing buffer
> with the set of attached devices as required for DMA-BUFs when
> doing {begin,end}_cpu_access.
Yeah the reason why we didn't do that is that this doesn't even work 100% reliable in theory. So this patchset here might make your use case work but is a bit questionable in general.
udmabuf is about turning a file descriptor created by memfd_create() into a DMA-buf. Mapping that memory can happen through the memfd as well and so it is perfectly valid to skip the DMA-buf begin_access and end_access callbacks.
Additional to that when CONFIG_DMABUF_DEBUG is enabled the DMA-buf code mangles the page addresses in the sg table to prevent importers from abusing it. That makes dma_sync_sgtable_for_cpu() and dma_sync_sgtable_for_device() on the exporter side crash.
That's the reason why DMA-buf heaps uses a copy of the sg table for calling dma_sync_sgtable_for_cpu()/dma_sync_sgtable_for_device().
It's basically a hack and should be removed, but for this we need to change all clients which is tons of work.
Regards,
Christian.
>
> Thanks
> Andrew
>
> Changes for v2:
> - fix attachment table use-after-free
> - rebased on v6.17-rc1
>
> Andrew Davis (3):
> udmabuf: Keep track current device mappings
> udmabuf: Sync buffer mappings for attached devices
> udmabuf: Use module_misc_device() to register this device
>
> drivers/dma-buf/udmabuf.c | 133 +++++++++++++++++++-------------------
> 1 file changed, 67 insertions(+), 66 deletions(-)
>
next prev parent reply other threads:[~2025-08-15 9:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 16:10 [PATCH v2 0/3] udmabuf: Sync to attached devices Andrew Davis
2025-08-14 16:10 ` [PATCH v2 1/3] udmabuf: Keep track current device mappings Andrew Davis
2025-08-14 16:10 ` [PATCH v2 2/3] udmabuf: Sync buffer mappings for attached devices Andrew Davis
2025-08-14 16:10 ` [PATCH v2 3/3] udmabuf: Use module_misc_device() to register this device Andrew Davis
2025-08-15 9:41 ` Christian König [this message]
2025-08-15 19:40 ` [PATCH v2 0/3] udmabuf: Sync to attached devices Andrew Davis
2025-08-18 10:58 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b963b02-dec0-4bf5-aea9-dbe3050716ee@amd.com \
--to=christian.koenig@amd.com \
--cc=afd@ti.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=sumit.semwal@linaro.org \
--cc=vivek.kasireddy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox