From: Andrew Davis <afd@ti.com>
To: "Gerd Hoffmann" <kraxel@redhat.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"Paul Cercueil" <paul@crapouillou.net>,
"Vivek Kasireddy" <vivek.kasireddy@intel.com>,
"Daniel Vetter" <daniel@ffwll.ch>
Cc: <dri-devel@lists.freedesktop.org>, <linux-media@vger.kernel.org>,
<linaro-mm-sig@lists.linaro.org>, <linux-kernel@vger.kernel.org>,
Andrew Davis <afd@ti.com>
Subject: [PATCH v2 1/3] udmabuf: Keep track current device mappings
Date: Thu, 14 Aug 2025 11:10:47 -0500 [thread overview]
Message-ID: <20250814161049.678672-2-afd@ti.com> (raw)
In-Reply-To: <20250814161049.678672-1-afd@ti.com>
When a device attaches to and maps our buffer we need to keep track
of this mapping/device. This is needed for synchronization with these
devices when beginning and ending CPU access for instance. Add a list
that tracks device mappings as part of {map,unmap}_udmabuf().
Signed-off-by: Andrew Davis <afd@ti.com>
---
drivers/dma-buf/udmabuf.c | 45 +++++++++++++++++++++++++++++++++++++--
1 file changed, 43 insertions(+), 2 deletions(-)
diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
index 40399c26e6be6..cc5c1cc42c7f2 100644
--- a/drivers/dma-buf/udmabuf.c
+++ b/drivers/dma-buf/udmabuf.c
@@ -42,6 +42,14 @@ struct udmabuf {
struct sg_table *sg;
struct miscdevice *device;
pgoff_t *offsets;
+ struct list_head attachments;
+ struct mutex lock; /* for attachments list */
+};
+
+struct udmabuf_attachment {
+ struct device *dev;
+ struct sg_table *table;
+ struct list_head list;
};
static vm_fault_t udmabuf_vm_fault(struct vm_fault *vmf)
@@ -185,14 +193,44 @@ static void put_sg_table(struct device *dev, struct sg_table *sg,
static struct sg_table *map_udmabuf(struct dma_buf_attachment *at,
enum dma_data_direction direction)
{
- return get_sg_table(at->dev, at->dmabuf, direction);
+ struct udmabuf *ubuf = at->dmabuf->priv;
+ struct udmabuf_attachment *a;
+ struct sg_table *table;
+
+ a = kzalloc(sizeof(*a), GFP_KERNEL);
+ if (!a)
+ return ERR_PTR(-ENOMEM);
+
+ table = get_sg_table(at->dev, at->dmabuf, direction);
+ if (IS_ERR(table)) {
+ kfree(a);
+ return table;
+ }
+
+ a->dev = at->dev;
+ a->table = table;
+
+ mutex_lock(&ubuf->lock);
+ list_add(&a->list, &ubuf->attachments);
+ mutex_unlock(&ubuf->lock);
+
+ return a->table;
}
static void unmap_udmabuf(struct dma_buf_attachment *at,
struct sg_table *sg,
enum dma_data_direction direction)
{
- return put_sg_table(at->dev, sg, direction);
+ struct udmabuf_attachment *a = at->priv;
+ struct udmabuf *ubuf = at->dmabuf->priv;
+
+ mutex_lock(&ubuf->lock);
+ list_del(&a->list);
+ mutex_unlock(&ubuf->lock);
+
+ put_sg_table(at->dev, sg, direction);
+
+ kfree(a);
}
static void unpin_all_folios(struct udmabuf *ubuf)
@@ -384,6 +422,9 @@ static long udmabuf_create(struct miscdevice *device,
if (!ubuf)
return -ENOMEM;
+ INIT_LIST_HEAD(&ubuf->attachments);
+ mutex_init(&ubuf->lock);
+
pglimit = ((u64)size_limit_mb * 1024 * 1024) >> PAGE_SHIFT;
for (i = 0; i < head->count; i++) {
pgoff_t subpgcnt;
--
2.39.2
next prev parent reply other threads:[~2025-08-14 16:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 16:10 [PATCH v2 0/3] udmabuf: Sync to attached devices Andrew Davis
2025-08-14 16:10 ` Andrew Davis [this message]
2025-08-14 16:10 ` [PATCH v2 2/3] udmabuf: Sync buffer mappings for " Andrew Davis
2025-08-14 16:10 ` [PATCH v2 3/3] udmabuf: Use module_misc_device() to register this device Andrew Davis
2025-08-15 9:41 ` [PATCH v2 0/3] udmabuf: Sync to attached devices Christian König
2025-08-15 19:40 ` Andrew Davis
2025-08-18 10:58 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250814161049.678672-2-afd@ti.com \
--to=afd@ti.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=sumit.semwal@linaro.org \
--cc=vivek.kasireddy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox