public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Kamil Debski <k.debski@samsung.com>
To: 'ayaka' <ayaka@soulik.info>, linux-media@vger.kernel.org
Cc: kyungmin.park@samsung.com, jtp.park@samsung.com, m.chehab@samsung.com
Subject: RE: [PATCH] s5p-mfc: correct the formats info for encoder
Date: Wed, 22 Oct 2014 13:46:22 +0200	[thread overview]
Message-ID: <0c7e01cfeded$cdd8c000$698a4000$%debski@samsung.com> (raw)
In-Reply-To: <1406132104-6430-2-git-send-email-ayaka@soulik.info>

Hi Ayaka,

Could you resend this patch with your sign-off?

Best wishes,
-- 
Kamil Debski
Samsung R&D Institute Poland


> -----Original Message-----
> From: ayaka [mailto:ayaka@soulik.info]
> Sent: Wednesday, July 23, 2014 6:15 PM
> To: linux-media@vger.kernel.org
> Cc: kyungmin.park@samsung.com; k.debski@samsung.com;
> jtp.park@samsung.com; m.chehab@samsung.com; ayaka
> Subject: [PATCH] s5p-mfc: correct the formats info for encoder
> 
> The NV12M is supported by all the version of MFC, so it is better to
> use it as default OUTPUT format.
> MFC v5 doesn't support NV21, I have tested it, for the SEC doc it is
> not supported either.
> ---
>  drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> index d26b248..4ea3796 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> @@ -32,7 +32,7 @@
>  #include "s5p_mfc_intr.h"
>  #include "s5p_mfc_opr.h"
> 
> -#define DEF_SRC_FMT_ENC	V4L2_PIX_FMT_NV12MT
> +#define DEF_SRC_FMT_ENC	V4L2_PIX_FMT_NV12M
>  #define DEF_DST_FMT_ENC	V4L2_PIX_FMT_H264
> 
>  static struct s5p_mfc_fmt formats[] = { @@ -67,8 +67,7 @@ static
> struct s5p_mfc_fmt formats[] = {
>  		.codec_mode	= S5P_MFC_CODEC_NONE,
>  		.type		= MFC_FMT_RAW,
>  		.num_planes	= 2,
> -		.versions	= MFC_V5_BIT | MFC_V6_BIT | MFC_V7_BIT |
> -								MFC_V8_BIT,
> +		.versions	= MFC_V6_BIT | MFC_V7_BIT | MFC_V8_BIT,
>  	},
>  	{
>  		.name		= "H264 Encoded Stream",
> --
> 1.9.3


  parent reply	other threads:[~2014-10-22 11:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-23 16:15 [PATCH] correct formats info in s5p-mfc encoder ayaka
2014-07-23 16:15 ` [PATCH] s5p-mfc: correct the formats info for encoder ayaka
2014-09-22 16:28   ` Kamil Debski
2014-09-22 16:50     ` ayaka
2014-10-22 11:46   ` Kamil Debski [this message]
2014-10-22 14:07     ` ayaka
2014-10-22 14:07       ` ayaka
  -- strict thread matches above, loose matches on Subject: below --
2014-10-22 18:03 ayaka
2014-10-22 18:03 ` ayaka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='0c7e01cfeded$cdd8c000$698a4000$%debski@samsung.com' \
    --to=k.debski@samsung.com \
    --cc=ayaka@soulik.info \
    --cc=jtp.park@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox