RE: [PATCH] s5p-mfc: correct the formats info for encoder

[Kamil Debski <k.debski@samsung.com>]

Hi Ayaka,

Sorry for such a late reply - I just noticed this patch.

> From: ayaka [mailto:ayaka@soulik.info]
> Sent: Wednesday, July 23, 2014 6:15 PM
> To: linux-media@vger.kernel.org
> Cc: kyungmin.park@samsung.com; k.debski@samsung.com;
> jtp.park@samsung.com; m.chehab@samsung.com; ayaka
> Subject: [PATCH] s5p-mfc: correct the formats info for encoder
> 
> The NV12M is supported by all the version of MFC, so it is better to
> use it as default OUTPUT format.
> MFC v5 doesn't support NV21, I have tested it, for the SEC doc it is
> not supported either.

A proper Sign-off is missing here.

According to the documentation of MFC v5 I have non-tiled format is
supported. Which documentation were you looking at?

>From my documentation:
++++++++++++++
ENC_MAP_FOR_CUR	0xC51C	
Memory structure setting register of the current frame.	R/W	0x00000000

Bits	Name	Description	Reset Value
[31:2]	RESERVED	Reserved	0
[1:0]	ENC_MAP_FOR_CUR	Memory structure of the current frame
0 : Linear mode
3 : 64x32 tiled mode	0
++++++++++++++

Best wishes,
-- 
Kamil Debski
Samsung R&D Institute Poland

> ---
>  drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> index d26b248..4ea3796 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> @@ -32,7 +32,7 @@
>  #include "s5p_mfc_intr.h"
>  #include "s5p_mfc_opr.h"
> 
> -#define DEF_SRC_FMT_ENC	V4L2_PIX_FMT_NV12MT
> +#define DEF_SRC_FMT_ENC	V4L2_PIX_FMT_NV12M
>  #define DEF_DST_FMT_ENC	V4L2_PIX_FMT_H264
> 
>  static struct s5p_mfc_fmt formats[] = { @@ -67,8 +67,7 @@ static
> struct s5p_mfc_fmt formats[] = {
>  		.codec_mode	= S5P_MFC_CODEC_NONE,
>  		.type		= MFC_FMT_RAW,
>  		.num_planes	= 2,
> -		.versions	= MFC_V5_BIT | MFC_V6_BIT | MFC_V7_BIT |
> -								MFC_V8_BIT,
> +		.versions	= MFC_V6_BIT | MFC_V7_BIT | MFC_V8_BIT,
>  	},
>  	{
>  		.name		= "H264 Encoded Stream",
> --
> 1.9.3