[PATCH] [media] lnbh25: fix lnbh25_attach inline wrapper

[PATCH] [media] lnbh25: fix lnbh25_attach inline wrapper

[Arnd Bergmann]

The 'static inline' version of lnbh25_attach() has an incorrect
prototype which results in a build error when
CONFIG_DVB_LNBH25 is disabled:

In file included from /git/arm-soc/drivers/media/pci/netup_unidvb/netup_unidvb_core.c:36:0:
/git/arm-soc/drivers/media/dvb-frontends/lnbh25.h:46:86: error: unknown type name 'dvb_frontend'

This changes the code to have the correct prototype.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: e025273b86fb ("[media] lnbh25: LNBH25 SEC controller driver")
---
Found on ARM randconfig builds


diff --git a/drivers/media/dvb-frontends/lnbh25.h b/drivers/media/dvb-frontends/lnbh25.h
index 69f30e21f6b3..1f329ef05acc 100644
--- a/drivers/media/dvb-frontends/lnbh25.h
+++ b/drivers/media/dvb-frontends/lnbh25.h
@@ -43,7 +43,7 @@ struct dvb_frontend *lnbh25_attach(
 	struct lnbh25_config *cfg,
 	struct i2c_adapter *i2c);
 #else
-static inline dvb_frontend *lnbh25_attach(
+static inline struct dvb_frontend *lnbh25_attach(
 	struct dvb_frontend *fe,
 	struct lnbh25_config *cfg,
 	struct i2c_adapter *i2c)

Re: [PATCH] [media] lnbh25: fix lnbh25_attach inline wrapper

[Javier Martinez Canillas]

Hello Arnd,

On Fri, Oct 16, 2015 at 10:32 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The 'static inline' version of lnbh25_attach() has an incorrect
> prototype which results in a build error when
> CONFIG_DVB_LNBH25 is disabled:
>
> In file included from /git/arm-soc/drivers/media/pci/netup_unidvb/netup_unidvb_core.c:36:0:
> /git/arm-soc/drivers/media/dvb-frontends/lnbh25.h:46:86: error: unknown type name 'dvb_frontend'
>
> This changes the code to have the correct prototype.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: e025273b86fb ("[media] lnbh25: LNBH25 SEC controller driver")
> ---

Same for this patch, the same change is already in the media fixes branch [0].

[0]: http://git.linuxtv.org/cgit.cgi/media_tree.git/commit/?h=fixes&id=b36a55cf298127a285806c52d8777c49548f3785

Best regards,
Javier

Re: [PATCH] [media] lnbh25: fix lnbh25_attach inline wrapper

[Arnd Bergmann]

On Friday 16 October 2015 23:45:46 Javier Martinez Canillas wrote:
> 
> On Fri, Oct 16, 2015 at 10:32 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > The 'static inline' version of lnbh25_attach() has an incorrect
> > prototype which results in a build error when
> > CONFIG_DVB_LNBH25 is disabled:
> >
> > In file included from /git/arm-soc/drivers/media/pci/netup_unidvb/netup_unidvb_core.c:36:0:
> > /git/arm-soc/drivers/media/dvb-frontends/lnbh25.h:46:86: error: unknown type name 'dvb_frontend'
> >
> > This changes the code to have the correct prototype.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: e025273b86fb ("[media] lnbh25: LNBH25 SEC controller driver")
> > ---
> 
> Same for this patch, the same change is already in the media fixes branch [0].
> 
> [0]: http://git.linuxtv.org/cgit.cgi/media_tree.git/commit/?h=fixes&id=b36a55cf298127a285806c52d8777c49548f3785

Ah, I see. The patches must have crossed then, it was still broken in linux-next
this morning.

	Arnd

Re: [PATCH] [media] lnbh25: fix lnbh25_attach inline wrapper

[Javier Martinez Canillas]

Hello Arnd,

On Fri, Oct 16, 2015 at 11:49 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 16 October 2015 23:45:46 Javier Martinez Canillas wrote:
>>
>> On Fri, Oct 16, 2015 at 10:32 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>> > The 'static inline' version of lnbh25_attach() has an incorrect
>> > prototype which results in a build error when
>> > CONFIG_DVB_LNBH25 is disabled:
>> >
>> > In file included from /git/arm-soc/drivers/media/pci/netup_unidvb/netup_unidvb_core.c:36:0:
>> > /git/arm-soc/drivers/media/dvb-frontends/lnbh25.h:46:86: error: unknown type name 'dvb_frontend'
>> >
>> > This changes the code to have the correct prototype.
>> >
>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> > Fixes: e025273b86fb ("[media] lnbh25: LNBH25 SEC controller driver")
>> > ---
>>
>> Same for this patch, the same change is already in the media fixes branch [0].
>>
>> [0]: http://git.linuxtv.org/cgit.cgi/media_tree.git/commit/?h=fixes&id=b36a55cf298127a285806c52d8777c49548f3785
>
> Ah, I see. The patches must have crossed then, it was still broken in linux-next
> this morning.
>

Well, I don't see that branch listed in
http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Next/Trees

>         Arnd

Best regards,
Javier