From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, hverkuil@xs4all.nl
Subject: Re: [v4l-utils 1/1] media-ctl: Fix bad long option crash
Date: Tue, 17 Nov 2015 15:11:50 +0200 [thread overview]
Message-ID: <10125299.Wyb64Yx7LA@avalon> (raw)
In-Reply-To: <1447760458-8327-1-git-send-email-sakari.ailus@linux.intel.com>
Hi Sakari,
Thank you for the patch.
On Tuesday 17 November 2015 13:40:58 Sakari Ailus wrote:
> The long options array has to be followed by an all-zero entry. There was
> none.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> utils/media-ctl/options.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/utils/media-ctl/options.c b/utils/media-ctl/options.c
> index ffaffcd..2751e6e 100644
> --- a/utils/media-ctl/options.c
> +++ b/utils/media-ctl/options.c
> @@ -97,6 +97,7 @@ static struct option opts[] = {
> {"print-topology", 0, 0, 'p'},
> {"reset", 0, 0, 'r'},
> {"verbose", 0, 0, 'v'},
> + { },
> };
>
> int parse_cmdline(int argc, char **argv)
--
Regards,
Laurent Pinchart
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2015-11-17 13:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 11:40 [v4l-utils 1/1] media-ctl: Fix bad long option crash Sakari Ailus
2015-11-17 13:11 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10125299.Wyb64Yx7LA@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox