* [v4l-utils 1/1] media-ctl: Fix bad long option crash
@ 2015-11-17 11:40 Sakari Ailus
2015-11-17 13:11 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Sakari Ailus @ 2015-11-17 11:40 UTC (permalink / raw)
To: linux-media; +Cc: hverkuil, laurent.pinchart
The long options array has to be followed by an all-zero entry. There was
none.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
utils/media-ctl/options.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/utils/media-ctl/options.c b/utils/media-ctl/options.c
index ffaffcd..2751e6e 100644
--- a/utils/media-ctl/options.c
+++ b/utils/media-ctl/options.c
@@ -97,6 +97,7 @@ static struct option opts[] = {
{"print-topology", 0, 0, 'p'},
{"reset", 0, 0, 'r'},
{"verbose", 0, 0, 'v'},
+ { },
};
int parse_cmdline(int argc, char **argv)
--
2.1.0.231.g7484e3b
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [v4l-utils 1/1] media-ctl: Fix bad long option crash
2015-11-17 11:40 [v4l-utils 1/1] media-ctl: Fix bad long option crash Sakari Ailus
@ 2015-11-17 13:11 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2015-11-17 13:11 UTC (permalink / raw)
To: Sakari Ailus; +Cc: linux-media, hverkuil
Hi Sakari,
Thank you for the patch.
On Tuesday 17 November 2015 13:40:58 Sakari Ailus wrote:
> The long options array has to be followed by an all-zero entry. There was
> none.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> utils/media-ctl/options.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/utils/media-ctl/options.c b/utils/media-ctl/options.c
> index ffaffcd..2751e6e 100644
> --- a/utils/media-ctl/options.c
> +++ b/utils/media-ctl/options.c
> @@ -97,6 +97,7 @@ static struct option opts[] = {
> {"print-topology", 0, 0, 'p'},
> {"reset", 0, 0, 'r'},
> {"verbose", 0, 0, 'v'},
> + { },
> };
>
> int parse_cmdline(int argc, char **argv)
--
Regards,
Laurent Pinchart
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-17 13:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-17 11:40 [v4l-utils 1/1] media-ctl: Fix bad long option crash Sakari Ailus
2015-11-17 13:11 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox