Re: [PATCH] support for medion dvb stick 1660:1921

Re: [PATCH] support for medion dvb stick 1660:1921

[Stéphane Elmaleh]

Hi Patrick

thank you for your help, I understand my mistake.
Here is the new patch, I hope this one is right.

regards
Stéphane

diff -r b576509ea6d2 linux/drivers/media/dvb/dvb-usb/dib0700_devices.c
--- a/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c Wed May 19
19:34:33 2010 -0300
+++ b/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c Tue Jun 01
20:28:13 2010 +0200
@@ -2091,6 +2091,7 @@
        { USB_DEVICE(USB_VID_PINNACLE,  USB_PID_PINNACLE_PCTV282E) },
        { USB_DEVICE(USB_VID_DIBCOM,    USB_PID_DIBCOM_STK8096GP) },
        { USB_DEVICE(USB_VID_ELGATO,
USB_PID_ELGATO_EYETV_DIVERSITY) },
+       { USB_DEVICE(USB_VID_MEDION,    USB_PID_MEDION_STICK_CTX_1921) },
        { 0 }           /* Terminating entry */
 };
 MODULE_DEVICE_TABLE(usb, dib0700_usb_id_table);
@@ -2606,10 +2607,14 @@
                        },
                },
 
-               .num_device_descs = 2,
+               .num_device_descs = 3,
                .devices = {
                        {   "DiBcom STK7770P reference design",
                                { &dib0700_usb_id_table[59], NULL },
+                               { NULL },
+                       },
+                       {   "Medion Stick ctx 1921",
+                               { &dib0700_usb_id_table[69], NULL },
                                { NULL },
                        },
                        {   "Terratec Cinergy T USB XXS (HD)/ T3",
diff -r b576509ea6d2 linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
--- a/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h     Wed May 19
19:34:33
2010 -0300
+++ b/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h     Tue Jun 01
20:28:13
2010 +0200
@@ -303,4 +303,5 @@
 #define USB_PID_TERRATEC_DVBS2CI_V2                    0x10ac
 #define USB_PID_TECHNISAT_USB2_HDCI_V1                 0x0001
 #define USB_PID_TECHNISAT_USB2_HDCI_V2                 0x0002
+#define USB_PID_MEDION_STICK_CTX_1921                  0x1921
 #endif

[PATCH] support for medion dvb stick 1660:1921

[Stéphane Elmaleh]

Hello,
I'm not sure of doing this the right way since I'm not a programmer.



diff -r b576509ea6d2 linux/drivers/media/dvb/dvb-usb/dib0700_devices.c
--- a/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c	Wed May 19 19:34:33 
2010 -0300
+++ b/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c	Mon May 31 00:34:44 
2010 +0200
@@ -2083,6 +2083,7 @@
 	{ USB_DEVICE(USB_VID_PCTV,	USB_PID_PINNACLE_PCTV282E) },
 	{ USB_DEVICE(USB_VID_DIBCOM,	USB_PID_DIBCOM_STK7770P) },
 /* 60 */{ USB_DEVICE(USB_VID_TERRATEC,	USB_PID_TERRATEC_CINERGY_T_XXS_2) },
+	{ USB_DEVICE(USB_VID_MEDION,	USB_PID_MEDION_STICK_CTX_1921) },
 	{ USB_DEVICE(USB_VID_DIBCOM,    USB_PID_DIBCOM_STK807XPVR) },
 	{ USB_DEVICE(USB_VID_DIBCOM,    USB_PID_DIBCOM_STK807XP) },
 	{ USB_DEVICE(USB_VID_PIXELVIEW, USB_PID_PIXELVIEW_SBTVD) },
@@ -2606,10 +2607,14 @@
 			},
 		},
 
-		.num_device_descs = 2,
+		.num_device_descs = 3,
 		.devices = {
 			{   "DiBcom STK7770P reference design",
 				{ &dib0700_usb_id_table[59], NULL },
+				{ NULL },
+			},
+			{   "Medion Stick ctx 1921",
+				{ &dib0700_usb_id_table[61], NULL },
 				{ NULL },
 			},
 			{   "Terratec Cinergy T USB XXS (HD)/ T3",
diff -r b576509ea6d2 linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
--- a/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h	Wed May 19 19:34:33 
2010 -0300
+++ b/linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h	Mon May 31 00:34:44 
2010 +0200
@@ -303,4 +303,5 @@
 #define USB_PID_TERRATEC_DVBS2CI_V2			0x10ac
 #define USB_PID_TECHNISAT_USB2_HDCI_V1			0x0001
 #define USB_PID_TECHNISAT_USB2_HDCI_V2			0x0002
+#define USB_PID_MEDION_STICK_CTX_1921			0x1921
 #endif

Re: [PATCH] support for medion dvb stick 1660:1921

[Patrick Boettcher]

Hi Stephane,

On Sun, 30 May 2010, St?phane Elmaleh wrote:
> Hello,
> I'm not sure of doing this the right way since I'm not a programmer.

Thanks for submitting the patch.

> diff -r b576509ea6d2 linux/drivers/media/dvb/dvb-usb/dib0700_devices.c
> --- a/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c	Wed May 19 19:34:33
> 2010 -0300
> +++ b/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c	Mon May 31 00:34:44
> 2010 +0200
> @@ -2083,6 +2083,7 @@
> 	{ USB_DEVICE(USB_VID_PCTV,	USB_PID_PINNACLE_PCTV282E) },
> 	{ USB_DEVICE(USB_VID_DIBCOM,	USB_PID_DIBCOM_STK7770P) },
> /* 60 */{ USB_DEVICE(USB_VID_TERRATEC,	USB_PID_TERRATEC_CINERGY_T_XXS_2) },
> +	{ USB_DEVICE(USB_VID_MEDION,	USB_PID_MEDION_STICK_CTX_1921) },
> 	{ USB_DEVICE(USB_VID_DIBCOM,    USB_PID_DIBCOM_STK807XPVR) },
> 	{ USB_DEVICE(USB_VID_DIBCOM,    USB_PID_DIBCOM_STK807XP) },
> 	{ USB_DEVICE(USB_VID_PIXELVIEW, USB_PID_PIXELVIEW_SBTVD) }

Could you please move your inserted line to the end of this PID/VID-table? 
How it is done now will change the indices used for all other 
PID/VID-entries which will break all the references to it.


> @@ -2606,10 +2607,14 @@
> 			},
> 		},
>
> -		.num_device_descs = 2,
> +		.num_device_descs = 3,
> 		.devices = {
> 			{   "DiBcom STK7770P reference design",
> 				{ &dib0700_usb_id_table[59], NULL },
> +				{ NULL },
> +			},
> +			{   "Medion Stick ctx 1921",
> +				{ &dib0700_usb_id_table[61], NULL },

If moved to the end of the table you have to adapt the 61 here to the 
real value.

Please resent the patch afterwards.

thanks,
Patrick.

--

Patrick Boettcher - Kernel Labs
http://www.kernellabs.com/