From: Andy Walls <awalls@md.metrocast.net>
To: Tejun Heo <tj@kernel.org>
Cc: torvalds@linux-foundation.org, mingo@elte.hu,
linux-kernel@vger.kernel.org, jeff@garzik.org,
akpm@linux-foundation.org, rusty@rustcorp.com.au,
cl@linux-foundation.org, dhowells@redhat.com,
arjan@linux.intel.com, oleg@redhat.com, axboe@kernel.dk,
fweisbec@gmail.com, dwalker@codeaurora.org,
stefanr@s5r6.in-berlin.de, florian@mickler.org,
andi@firstfloor.org, mst@redhat.com, randy.dunlap@oracle.com,
ivtv-devel@ivtvdriver.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 02/35] ivtv: use kthread_worker instead of workqueue
Date: Mon, 05 Jul 2010 13:11:00 -0400 [thread overview]
Message-ID: <1278349860.2229.9.camel@localhost> (raw)
In-Reply-To: <1277759063-24607-3-git-send-email-tj@kernel.org>
On Mon, 2010-06-28 at 23:03 +0200, Tejun Heo wrote:
> Upcoming workqueue updates will no longer guarantee fixed workqueue to
> worker kthread association, so giving RT priority to the irq worker
> won't work. Use kthread_worker which guarantees specific kthread
> association instead. This also makes setting the priority cleaner.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Andy Walls <awalls@md.metrocast.net>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: ivtv-devel@ivtvdriver.org
> Cc: linux-media@vger.kernel.org
Assuming the new kthread_worker implementation is OK, this change for
ivtv looks good.
Reviewed-by: Andy Walls <awalls@md.metrocast.net>
Acked-by: Andy Walls <awalls@md.metrocast.net>
Regards,
Andy
> drivers/media/video/ivtv/ivtv-driver.c | 26 ++++++++++++++++----------
> drivers/media/video/ivtv/ivtv-driver.h | 8 ++++----
> drivers/media/video/ivtv/ivtv-irq.c | 15 +++------------
> drivers/media/video/ivtv/ivtv-irq.h | 2 +-
> 4 files changed, 24 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/media/video/ivtv/ivtv-driver.c b/drivers/media/video/ivtv/ivtv-driver.c
> index 1b79475..49e0b1c 100644
> --- a/drivers/media/video/ivtv/ivtv-driver.c
> +++ b/drivers/media/video/ivtv/ivtv-driver.c
next prev parent reply other threads:[~2010-07-05 17:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1277759063-24607-1-git-send-email-tj@kernel.org>
2010-06-28 21:03 ` [PATCH 02/35] ivtv: use kthread_worker instead of workqueue Tejun Heo
2010-07-05 17:11 ` Andy Walls [this message]
2010-07-06 7:01 ` Tejun Heo
2010-07-09 13:15 ` Andy Walls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278349860.2229.9.camel@localhost \
--to=awalls@md.metrocast.net \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=arjan@linux.intel.com \
--cc=axboe@kernel.dk \
--cc=cl@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=dwalker@codeaurora.org \
--cc=florian@mickler.org \
--cc=fweisbec@gmail.com \
--cc=ivtv-devel@ivtvdriver.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mst@redhat.com \
--cc=oleg@redhat.com \
--cc=randy.dunlap@oracle.com \
--cc=rusty@rustcorp.com.au \
--cc=stefanr@s5r6.in-berlin.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox