[PATCH] IX2505V: i2c transfer error code ignored

[PATCH] IX2505V: i2c transfer error code ignored

[Matthias Schwarzott]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

Hello Malcolm!

It seems that ix2505v driver ignores a i2c error in ix2505v_read_status_reg.
This looks like a typing error using (ret = 1) instead of correct (ret == 1).

The attached patch fixes this.

Regards
Matthias

[-- Attachment #2: ix2505-error-code-ignored.patch --]
[-- Type: text/x-patch, Size: 527 bytes --]

diff --git a/drivers/media/dvb/frontends/ix2505v.c b/drivers/media/dvb/frontends/ix2505v.c
index 55f2eba..6360c68 100644
--- a/drivers/media/dvb/frontends/ix2505v.c
+++ b/drivers/media/dvb/frontends/ix2505v.c
@@ -72,7 +72,7 @@ static int ix2505v_read_status_reg(struct ix2505v_state *state)
 	ret = i2c_transfer(state->i2c, msg, 1);
 	deb_i2c("Read %s ", __func__);
 
-	return (ret = 1) ? (int) b2[0] : -1;
+	return (ret == 1) ? (int) b2[0] : -1;
 }
 
 static int ix2505v_write(struct ix2505v_state *state, u8 buf[], u8 count)

Re: IX2505V: i2c transfer error code ignored

[Malcolm Priestley]

On Sun, 2010-11-07 at 14:57 +0100, Matthias Schwarzott wrote:
> Hello Malcolm!
> 
> It seems that ix2505v driver ignores a i2c error in ix2505v_read_status_reg.
> This looks like a typing error using (ret = 1) instead of correct (ret == 1).
> 
> The attached patch fixes this.

Hi Matthias,

Thanks for picking that up.

Acked-by: Malcolm Priestley <tvboxspy@gmail.com>

Regards


Malcolm

Re: IX2505V: i2c transfer error code ignored

[Matthias Schwarzott]

On Sunday 07 November 2010, Malcolm Priestley wrote:
> On Sun, 2010-11-07 at 14:57 +0100, Matthias Schwarzott wrote:
> > Hello Malcolm!
> > 
> > It seems that ix2505v driver ignores a i2c error in
> > ix2505v_read_status_reg. This looks like a typing error using (ret = 1)
> > instead of correct (ret == 1).
> > 
> > The attached patch fixes this.
> 
> Hi Matthias,
> 
> Thanks for picking that up.
> 
> Acked-by: Malcolm Priestley <tvboxspy@gmail.com>
> 

I forgot the SOB, so here it is:
Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>

Regards
Matthias