From: "Matti J. Aaltonen" <matti.j.aaltonen@nokia.com>
To: ext Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH 8/8] [media] saa7134: Kworld SBTVD: make both analog and digital to work
Date: Mon, 17 Jan 2011 16:14:26 +0200 [thread overview]
Message-ID: <1295273667.25951.41.camel@masi.mnp.nokia.com> (raw)
In-Reply-To: <20110115160424.4b474921@pedra>
On Sat, 2011-01-15 at 16:04 -0200, ext Mauro Carvalho Chehab wrote:
> There are some weird bugs at tda8290/tda18271 initialization, as it
> insits do do analog initialization during DVB frontend attach:
>
> diff --git a/drivers/media/common/tuners/tda8290.c b/drivers/media/common/tuners/tda8290.c
> index 419d064..bc6a677 100644
> --- a/drivers/media/common/tuners/tda8290.c
> +++ b/drivers/media/common/tuners/tda8290.c
> @@ -232,6 +232,7 @@ static void tda8290_set_params(struct dvb_frontend *fe,
> tuner_i2c_xfer_send(&priv->i2c_props, pll_bw_nom, 2);
> }
>
> +
> tda8290_i2c_bridge(fe, 1);
Don't add a second empty line here...
Cheers,
Matti
prev parent reply other threads:[~2011-01-17 14:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1295114145.git.mchehab@redhat.com>
2011-01-15 18:04 ` [PATCH 1/8] [media] tda8290: Make all read operations atomic Mauro Carvalho Chehab
2011-01-15 18:04 ` [PATCH 2/8] [media] tda8290: Fix a bug if no tuner is detected Mauro Carvalho Chehab
2011-01-15 18:04 ` [PATCH 3/8] [media] tda8290: Turn tda829x on before touching at the I2C gate Mauro Carvalho Chehab
2011-01-15 18:04 ` [PATCH 6/8] [media] saa7134: Fix analog mode for Kworld SBTVD Mauro Carvalho Chehab
2011-01-15 18:04 ` [PATCH 4/8] [media] mb86a20s: Fix i2c read/write error messages Mauro Carvalho Chehab
2011-01-15 18:04 ` [PATCH 5/8] [media] mb86a20s: Be sure that device is initialized before starting DVB Mauro Carvalho Chehab
2011-01-15 18:04 ` [PATCH 7/8] [media] saa7134: Fix digital mode on Kworld SBTVD Mauro Carvalho Chehab
2011-01-15 18:04 ` [PATCH 8/8] [media] saa7134: Kworld SBTVD: make both analog and digital to work Mauro Carvalho Chehab
2011-01-17 14:14 ` Matti J. Aaltonen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295273667.25951.41.camel@masi.mnp.nokia.com \
--to=matti.j.aaltonen@nokia.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox