From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: unlisted-recipients:; (no To-header on input)@casper.infradead.org
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: [PATCH 3/8] [media] tda8290: Turn tda829x on before touching at the I2C gate
Date: Sat, 15 Jan 2011 16:04:20 -0200 [thread overview]
Message-ID: <20110115160420.0028499c@pedra> (raw)
In-Reply-To: <cover.1295114145.git.mchehab@redhat.com>
On Kworld SBTVD, tda8295-c1 starts in power off mode. It needs
to be powered, otherwise, the I2C gate control command won't work.
Cc: Michael Krufky <mkrufky@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
diff --git a/drivers/media/common/tuners/tda8290.c b/drivers/media/common/tuners/tda8290.c
index 11ea4e0..419d064 100644
--- a/drivers/media/common/tuners/tda8290.c
+++ b/drivers/media/common/tuners/tda8290.c
@@ -754,11 +754,10 @@ struct dvb_frontend *tda829x_attach(struct dvb_frontend *fe,
sizeof(struct analog_demod_ops));
}
- if ((!(cfg) || (TDA829X_PROBE_TUNER == cfg->probe_tuner)) &&
- (tda829x_find_tuner(fe) < 0)) {
- memset(&fe->ops.analog_ops, 0, sizeof(struct analog_demod_ops));
-
- goto fail;
+ if (!(cfg) || (TDA829X_PROBE_TUNER == cfg->probe_tuner)) {
+ tda8295_power(fe, 1);
+ if (tda829x_find_tuner(fe) < 0)
+ goto fail;
}
switch (priv->ver) {
@@ -803,6 +802,8 @@ struct dvb_frontend *tda829x_attach(struct dvb_frontend *fe,
return fe;
fail:
+ memset(&fe->ops.analog_ops, 0, sizeof(struct analog_demod_ops));
+
tda829x_release(fe);
return NULL;
}
--
1.7.1
next prev parent reply other threads:[~2011-01-15 16:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1295114145.git.mchehab@redhat.com>
2011-01-15 18:04 ` [PATCH 1/8] [media] tda8290: Make all read operations atomic Mauro Carvalho Chehab
2011-01-15 18:04 ` [PATCH 2/8] [media] tda8290: Fix a bug if no tuner is detected Mauro Carvalho Chehab
2011-01-15 18:04 ` Mauro Carvalho Chehab [this message]
2011-01-15 18:04 ` [PATCH 6/8] [media] saa7134: Fix analog mode for Kworld SBTVD Mauro Carvalho Chehab
2011-01-15 18:04 ` [PATCH 4/8] [media] mb86a20s: Fix i2c read/write error messages Mauro Carvalho Chehab
2011-01-15 18:04 ` [PATCH 7/8] [media] saa7134: Fix digital mode on Kworld SBTVD Mauro Carvalho Chehab
2011-01-15 18:04 ` [PATCH 5/8] [media] mb86a20s: Be sure that device is initialized before starting DVB Mauro Carvalho Chehab
2011-01-15 18:04 ` [PATCH 8/8] [media] saa7134: Kworld SBTVD: make both analog and digital to work Mauro Carvalho Chehab
2011-01-17 14:14 ` Matti J. Aaltonen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110115160420.0028499c@pedra \
--to=mchehab@redhat.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox