* [PATCH] s2255drv: atomic submit urb in completion handler
@ 2011-04-02 0:21 Pete Eberlein
0 siblings, 0 replies; only message in thread
From: Pete Eberlein @ 2011-04-02 0:21 UTC (permalink / raw)
To: linux-media@vger.kernel.org; +Cc: linux-dev
An usb_submit_urb should be atomic in a completion handler. This fixes
"BUG: scheduling while atomic" messages.
Signed-off-by: Pete Eberlein <pete@sensoray.com>
diff --git a/drivers/media/video/s2255drv.c b/drivers/media/video/s2255drv.c
index f5a46c4..85c3158 100644
--- a/drivers/media/video/s2255drv.c
+++ b/drivers/media/video/s2255drv.c
@@ -2406,7 +2406,7 @@ static void read_pipe_completion(struct urb *purb)
read_pipe_completion, pipe_info);
if (pipe_info->state != 0) {
- if (usb_submit_urb(pipe_info->stream_urb, GFP_KERNEL)) {
+ if (usb_submit_urb(pipe_info->stream_urb, GFP_ATOMIC)) {
dev_err(&dev->udev->dev, "error submitting urb\n");
}
} else {
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-04-02 0:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-02 0:21 [PATCH] s2255drv: atomic submit urb in completion handler Pete Eberlein
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox