From: Prabhakar Lad <prabhakar.csengg@gmail.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>,
LMML <linux-media@vger.kernel.org>,
DLOS <davinci-linux-open-source@linux.davincidsp.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Subject: [PATCH v4 02/11] media: davinci: vpif: Convert to devm_* api
Date: Mon, 17 Jun 2013 20:50:42 +0530 [thread overview]
Message-ID: <1371482451-18314-3-git-send-email-prabhakar.csengg@gmail.com> (raw)
In-Reply-To: <1371482451-18314-1-git-send-email-prabhakar.csengg@gmail.com>
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Use devm_ioremap_resource instead of reques_mem_region()/ioremap().
This ensures more consistent error values and simplifies error paths.
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/media/platform/davinci/vpif.c | 27 ++++-----------------------
1 file changed, 4 insertions(+), 23 deletions(-)
diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c
index 761c825..164c1b7 100644
--- a/drivers/media/platform/davinci/vpif.c
+++ b/drivers/media/platform/davinci/vpif.c
@@ -37,8 +37,6 @@ MODULE_LICENSE("GPL");
#define VPIF_CH2_MAX_MODES (15)
#define VPIF_CH3_MAX_MODES (02)
-static resource_size_t res_len;
-static struct resource *res;
spinlock_t vpif_lock;
void __iomem *vpif_base;
@@ -421,23 +419,12 @@ EXPORT_SYMBOL(vpif_channel_getfid);
static int vpif_probe(struct platform_device *pdev)
{
- int status = 0;
+ static struct resource *res;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- return -ENOENT;
-
- res_len = resource_size(res);
-
- res = request_mem_region(res->start, res_len, res->name);
- if (!res)
- return -EBUSY;
-
- vpif_base = ioremap(res->start, res_len);
- if (!vpif_base) {
- status = -EBUSY;
- goto fail;
- }
+ vpif_base = devm_ioremap_resource(&pdev->dev, res);
+ if (IS_ERR(vpif_base))
+ return PTR_ERR(vpif_base);
pm_runtime_enable(&pdev->dev);
pm_runtime_get(&pdev->dev);
@@ -445,17 +432,11 @@ static int vpif_probe(struct platform_device *pdev)
spin_lock_init(&vpif_lock);
dev_info(&pdev->dev, "vpif probe success\n");
return 0;
-
-fail:
- release_mem_region(res->start, res_len);
- return status;
}
static int vpif_remove(struct platform_device *pdev)
{
pm_runtime_disable(&pdev->dev);
- iounmap(vpif_base);
- release_mem_region(res->start, res_len);
return 0;
}
--
1.7.9.5
next prev parent reply other threads:[~2013-06-17 15:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 15:20 [PATCH v4 00/11] media: davinci: vpif driver cleanup Prabhakar Lad
2013-06-17 15:20 ` [PATCH v4 01/11] media: davinci: vpif: remove unwanted header mach/hardware.h and sort the includes alphabetically Prabhakar Lad
2013-06-17 15:20 ` Prabhakar Lad [this message]
2013-06-17 15:20 ` [PATCH v4 03/11] media: davinci: vpif: remove unnecessary braces around defines Prabhakar Lad
2013-06-17 15:20 ` [PATCH v4 04/11] media: davinci: vpif_capture: move the freeing of irq and global variables to remove() Prabhakar Lad
2013-06-17 15:20 ` [PATCH v4 05/11] media: davinci: vpif_capture: use module_platform_driver() Prabhakar Lad
2013-06-17 15:20 ` [PATCH v4 06/11] media: davinci: vpif_capture: Convert to devm_* api Prabhakar Lad
2013-06-17 15:20 ` [PATCH v4 07/11] media: davinci: vpif_capture: remove unnecessary loop for IRQ resource Prabhakar Lad
2013-06-17 15:20 ` [PATCH v4 08/11] media: davinci: vpif_display: move the freeing of irq and global variables to remove() Prabhakar Lad
2013-06-17 15:20 ` [PATCH v4 09/11] media: davinci: vpif_display: use module_platform_driver() Prabhakar Lad
2013-06-17 15:20 ` [PATCH v4 10/11] media: davinci: vpif_display: Convert to devm_* api Prabhakar Lad
2013-06-17 15:20 ` [PATCH v4 11/11] media: davinci: vpif_display: remove unnecessary loop for IRQ resource Prabhakar Lad
2013-06-17 17:20 ` [PATCH v4 00/11] media: davinci: vpif driver cleanup Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371482451-18314-3-git-send-email-prabhakar.csengg@gmail.com \
--to=prabhakar.csengg@gmail.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox