From: Prabhakar Lad <prabhakar.csengg@gmail.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>,
LMML <linux-media@vger.kernel.org>,
DLOS <davinci-linux-open-source@linux.davincidsp.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Subject: [PATCH v4 07/11] media: davinci: vpif_capture: remove unnecessary loop for IRQ resource
Date: Mon, 17 Jun 2013 20:50:47 +0530 [thread overview]
Message-ID: <1371482451-18314-8-git-send-email-prabhakar.csengg@gmail.com> (raw)
In-Reply-To: <1371482451-18314-1-git-send-email-prabhakar.csengg@gmail.com>
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
For vpif capture driver each IRQ resource contains a single IRQ
so drop the second loop.
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
drivers/media/platform/davinci/vpif_capture.c | 17 +++++++----------
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c
index a4e0eab..5514175 100644
--- a/drivers/media/platform/davinci/vpif_capture.c
+++ b/drivers/media/platform/davinci/vpif_capture.c
@@ -2015,16 +2015,13 @@ static __init int vpif_probe(struct platform_device *pdev)
}
while ((res = platform_get_resource(pdev, IORESOURCE_IRQ, res_idx))) {
- for (i = res->start; i <= res->end; i++) {
- err = devm_request_irq(&pdev->dev, i, vpif_channel_isr,
- IRQF_SHARED, "VPIF_Capture",
- (void *)(&vpif_obj.dev[res_idx]->
- channel_id));
- if (err) {
- err = -EINVAL;
- goto vpif_unregister;
-
- }
+ err = devm_request_irq(&pdev->dev, res->start, vpif_channel_isr,
+ IRQF_SHARED, "VPIF_Capture",
+ (void *)(&vpif_obj.dev[res_idx]->
+ channel_id));
+ if (err) {
+ err = -EINVAL;
+ goto vpif_unregister;
}
res_idx++;
}
--
1.7.9.5
next prev parent reply other threads:[~2013-06-17 15:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 15:20 [PATCH v4 00/11] media: davinci: vpif driver cleanup Prabhakar Lad
2013-06-17 15:20 ` [PATCH v4 01/11] media: davinci: vpif: remove unwanted header mach/hardware.h and sort the includes alphabetically Prabhakar Lad
2013-06-17 15:20 ` [PATCH v4 02/11] media: davinci: vpif: Convert to devm_* api Prabhakar Lad
2013-06-17 15:20 ` [PATCH v4 03/11] media: davinci: vpif: remove unnecessary braces around defines Prabhakar Lad
2013-06-17 15:20 ` [PATCH v4 04/11] media: davinci: vpif_capture: move the freeing of irq and global variables to remove() Prabhakar Lad
2013-06-17 15:20 ` [PATCH v4 05/11] media: davinci: vpif_capture: use module_platform_driver() Prabhakar Lad
2013-06-17 15:20 ` [PATCH v4 06/11] media: davinci: vpif_capture: Convert to devm_* api Prabhakar Lad
2013-06-17 15:20 ` Prabhakar Lad [this message]
2013-06-17 15:20 ` [PATCH v4 08/11] media: davinci: vpif_display: move the freeing of irq and global variables to remove() Prabhakar Lad
2013-06-17 15:20 ` [PATCH v4 09/11] media: davinci: vpif_display: use module_platform_driver() Prabhakar Lad
2013-06-17 15:20 ` [PATCH v4 10/11] media: davinci: vpif_display: Convert to devm_* api Prabhakar Lad
2013-06-17 15:20 ` [PATCH v4 11/11] media: davinci: vpif_display: remove unnecessary loop for IRQ resource Prabhakar Lad
2013-06-17 17:20 ` [PATCH v4 00/11] media: davinci: vpif driver cleanup Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371482451-18314-8-git-send-email-prabhakar.csengg@gmail.com \
--to=prabhakar.csengg@gmail.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox