* [PATCH] tvp5150: Fix device ID kernel log message
@ 2014-05-26 19:28 Laurent Pinchart
2014-07-17 11:29 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Laurent Pinchart @ 2014-05-26 19:28 UTC (permalink / raw)
To: linux-media; +Cc: Mauro Carvalho Chehab
The driver mistakenly prints the ROM version instead of the device ID to
the kernel log when detecting the chip. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/media/i2c/tvp5150.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index a912125..937e48b 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
@@ -1148,10 +1148,10 @@ static int tvp5150_probe(struct i2c_client *c,
/* Is TVP5150A */
if (tvp5150_id[2] == 3 || tvp5150_id[3] == 0x21) {
v4l2_info(sd, "tvp%02x%02xa detected.\n",
- tvp5150_id[2], tvp5150_id[3]);
+ tvp5150_id[0], tvp5150_id[1]);
} else {
v4l2_info(sd, "*** unknown tvp%02x%02x chip detected.\n",
- tvp5150_id[2], tvp5150_id[3]);
+ tvp5150_id[0], tvp5150_id[1]);
v4l2_info(sd, "*** Rom ver is %d.%d\n",
tvp5150_id[2], tvp5150_id[3]);
}
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tvp5150: Fix device ID kernel log message
2014-05-26 19:28 [PATCH] tvp5150: Fix device ID kernel log message Laurent Pinchart
@ 2014-07-17 11:29 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2014-07-17 11:29 UTC (permalink / raw)
To: linux-media; +Cc: Mauro Carvalho Chehab
Hi Mauro,
Ping ?
On Monday 26 May 2014 21:28:31 Laurent Pinchart wrote:
> The driver mistakenly prints the ROM version instead of the device ID to
> the kernel log when detecting the chip. Fix it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/tvp5150.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
> index a912125..937e48b 100644
> --- a/drivers/media/i2c/tvp5150.c
> +++ b/drivers/media/i2c/tvp5150.c
> @@ -1148,10 +1148,10 @@ static int tvp5150_probe(struct i2c_client *c,
> /* Is TVP5150A */
> if (tvp5150_id[2] == 3 || tvp5150_id[3] == 0x21) {
> v4l2_info(sd, "tvp%02x%02xa detected.\n",
> - tvp5150_id[2], tvp5150_id[3]);
> + tvp5150_id[0], tvp5150_id[1]);
> } else {
> v4l2_info(sd, "*** unknown tvp%02x%02x chip detected.\n",
> - tvp5150_id[2], tvp5150_id[3]);
> + tvp5150_id[0], tvp5150_id[1]);
> v4l2_info(sd, "*** Rom ver is %d.%d\n",
> tvp5150_id[2], tvp5150_id[3]);
> }
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-17 11:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-26 19:28 [PATCH] tvp5150: Fix device ID kernel log message Laurent Pinchart
2014-07-17 11:29 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox