* [PATCH] staging drivers fixed coding style error
@ 2017-07-13 14:17 smklearn
2017-07-13 14:25 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: smklearn @ 2017-07-13 14:17 UTC (permalink / raw)
To: mchehab, gregkh, alan; +Cc: linux-media, devel, linux-kernel, smklearn
Fixed coding style error flagged checkpatch.pl:
- ERROR: space prohibited after that open parenthesis '('
- WARNING: Block comments use * on subsequent lines
Signed-off-by: Shy More <smklearn@gmail.com>
Output after fixing coding style issues:
$KERN/scripts/checkpatch.pl -f
./media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c
total: 0 errors, 0 warnings, 141 lines checked
---
.../css2400/runtime/isys/src/ibuf_ctrl_rmgr.c | 26 +++++++++++-----------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c
index 76d9142..856fb6e 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c
@@ -14,18 +14,18 @@
*/
#else
/**
-Support for Intel Camera Imaging ISP subsystem.
-Copyright (c) 2010 - 2015, Intel Corporation.
-
-This program is free software; you can redistribute it and/or modify it
-under the terms and conditions of the GNU General Public License,
-version 2, as published by the Free Software Foundation.
-
-This program is distributed in the hope it will be useful, but WITHOUT
-ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
-FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
-more details.
-*/
+ * Support for Intel Camera Imaging ISP subsystem.
+ * Copyright (c) 2010 - 2015, Intel Corporation.
+
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+
+ * This program is distributed in the hope it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
+ * more details.
+ */
#endif
#include "system_global.h"
@@ -131,7 +131,7 @@ void ia_css_isys_ibuf_rmgr_release(
for (i = 0; i < ibuf_rsrc.num_allocated; i++) {
handle = getHandle(i);
if ((handle->start_addr == *start_addr)
- && ( true == handle->active)) {
+ && (true == handle->active)) {
handle->active = false;
ibuf_rsrc.num_active--;
break;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging drivers fixed coding style error
2017-07-13 14:17 [PATCH] staging drivers fixed coding style error smklearn
@ 2017-07-13 14:25 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-07-13 14:25 UTC (permalink / raw)
To: smklearn; +Cc: mchehab, alan, linux-media, devel, linux-kernel
On Thu, Jul 13, 2017 at 07:17:56AM -0700, smklearn wrote:
> Fixed coding style error flagged checkpatch.pl:
> - ERROR: space prohibited after that open parenthesis '('
> - WARNING: Block comments use * on subsequent lines
>
> Signed-off-by: Shy More <smklearn@gmail.com>
>
> Output after fixing coding style issues:
>
> $KERN/scripts/checkpatch.pl -f
> ./media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c
>
> total: 0 errors, 0 warnings, 141 lines checked
Please don't put anything below the Signed-off-by: line, you will note
that all other commits are written that way.
Also, your subject: needs a lot of work, again, look at other commits
for the driver you are modifying to get it right.
good luck!
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-13 14:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-13 14:17 [PATCH] staging drivers fixed coding style error smklearn
2017-07-13 14:25 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox