* [PATCH] Staging: media: omap4iss: Use WARN_ON() instead of BUG_ON().
@ 2017-09-08 14:08 Srishti Sharma
2017-09-08 14:10 ` [Outreachy kernel] " Julia Lawall
2017-09-08 14:38 ` Dan Carpenter
0 siblings, 2 replies; 5+ messages in thread
From: Srishti Sharma @ 2017-09-08 14:08 UTC (permalink / raw)
To: gregkh
Cc: laurent.pinchart, mchehab, linux-media, devel, linux-kernel,
outreachy-kernel, Srishti Sharma
Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel.
Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
---
drivers/staging/media/omap4iss/iss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
index c26c99fd..b1036ba 100644
--- a/drivers/staging/media/omap4iss/iss.c
+++ b/drivers/staging/media/omap4iss/iss.c
@@ -893,7 +893,7 @@ void omap4iss_put(struct iss_device *iss)
return;
mutex_lock(&iss->iss_mutex);
- BUG_ON(iss->ref_count == 0);
+ WARN_ON(iss->ref_count == 0);
if (--iss->ref_count == 0) {
iss_disable_interrupts(iss);
/* Reset the ISS if an entity has failed to stop. This is the
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Outreachy kernel] [PATCH] Staging: media: omap4iss: Use WARN_ON() instead of BUG_ON().
2017-09-08 14:08 [PATCH] Staging: media: omap4iss: Use WARN_ON() instead of BUG_ON() Srishti Sharma
@ 2017-09-08 14:10 ` Julia Lawall
2017-09-08 14:17 ` Srishti Sharma
2017-09-08 14:38 ` Dan Carpenter
1 sibling, 1 reply; 5+ messages in thread
From: Julia Lawall @ 2017-09-08 14:10 UTC (permalink / raw)
To: Srishti Sharma
Cc: gregkh, laurent.pinchart, mchehab, linux-media, devel,
linux-kernel, outreachy-kernel
On Fri, 8 Sep 2017, Srishti Sharma wrote:
> Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel.
>
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
> ---
> drivers/staging/media/omap4iss/iss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
> index c26c99fd..b1036ba 100644
> --- a/drivers/staging/media/omap4iss/iss.c
> +++ b/drivers/staging/media/omap4iss/iss.c
> @@ -893,7 +893,7 @@ void omap4iss_put(struct iss_device *iss)
> return;
>
> mutex_lock(&iss->iss_mutex);
> - BUG_ON(iss->ref_count == 0);
> + WARN_ON(iss->ref_count == 0);
> if (--iss->ref_count == 0) {
Won't this then infinite loop?
julia
> iss_disable_interrupts(iss);
> /* Reset the ISS if an entity has failed to stop. This is the
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504879698-5855-1-git-send-email-srishtishar%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Outreachy kernel] [PATCH] Staging: media: omap4iss: Use WARN_ON() instead of BUG_ON().
2017-09-08 14:10 ` [Outreachy kernel] " Julia Lawall
@ 2017-09-08 14:17 ` Srishti Sharma
0 siblings, 0 replies; 5+ messages in thread
From: Srishti Sharma @ 2017-09-08 14:17 UTC (permalink / raw)
To: Julia Lawall
Cc: Greg KH, laurent.pinchart, mchehab, linux-media, devel,
Linux kernel mailing list, outreachy-kernel
On Fri, Sep 8, 2017 at 7:40 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Fri, 8 Sep 2017, Srishti Sharma wrote:
>
>> Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel.
>>
>> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
>> ---
>> drivers/staging/media/omap4iss/iss.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
>> index c26c99fd..b1036ba 100644
>> --- a/drivers/staging/media/omap4iss/iss.c
>> +++ b/drivers/staging/media/omap4iss/iss.c
>> @@ -893,7 +893,7 @@ void omap4iss_put(struct iss_device *iss)
>> return;
>>
>> mutex_lock(&iss->iss_mutex);
>> - BUG_ON(iss->ref_count == 0);
>> + WARN_ON(iss->ref_count == 0);
>> if (--iss->ref_count == 0) {
>
> Won't this then infinite loop?
Oh.. yes ! It would, sorry . Please drop this patch .
Regards,
Srishti
>
> julia
>
>> iss_disable_interrupts(iss);
>> /* Reset the ISS if an entity has failed to stop. This is the
>> --
>> 2.7.4
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504879698-5855-1-git-send-email-srishtishar%40gmail.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: media: omap4iss: Use WARN_ON() instead of BUG_ON().
2017-09-08 14:08 [PATCH] Staging: media: omap4iss: Use WARN_ON() instead of BUG_ON() Srishti Sharma
2017-09-08 14:10 ` [Outreachy kernel] " Julia Lawall
@ 2017-09-08 14:38 ` Dan Carpenter
2017-09-08 14:59 ` Srishti Sharma
1 sibling, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2017-09-08 14:38 UTC (permalink / raw)
To: Srishti Sharma
Cc: gregkh, devel, linux-kernel, outreachy-kernel, laurent.pinchart,
mchehab, linux-media
On Fri, Sep 08, 2017 at 07:38:18PM +0530, Srishti Sharma wrote:
> Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel.
>
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
> ---
> drivers/staging/media/omap4iss/iss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
> index c26c99fd..b1036ba 100644
> --- a/drivers/staging/media/omap4iss/iss.c
> +++ b/drivers/staging/media/omap4iss/iss.c
> @@ -893,7 +893,7 @@ void omap4iss_put(struct iss_device *iss)
> return;
>
> mutex_lock(&iss->iss_mutex);
> - BUG_ON(iss->ref_count == 0);
> + WARN_ON(iss->ref_count == 0);
ref_counting bugs often have a security aspect. BUG_ON() is probably
safer here. Better to crash than to lose all your bitcoin.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: media: omap4iss: Use WARN_ON() instead of BUG_ON().
2017-09-08 14:38 ` Dan Carpenter
@ 2017-09-08 14:59 ` Srishti Sharma
0 siblings, 0 replies; 5+ messages in thread
From: Srishti Sharma @ 2017-09-08 14:59 UTC (permalink / raw)
To: Dan Carpenter
Cc: Greg KH, devel, Linux kernel mailing list, outreachy-kernel,
laurent.pinchart, mchehab, linux-media
On Fri, Sep 8, 2017 at 8:08 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Fri, Sep 08, 2017 at 07:38:18PM +0530, Srishti Sharma wrote:
>> Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel.
>>
>> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
>> ---
>> drivers/staging/media/omap4iss/iss.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
>> index c26c99fd..b1036ba 100644
>> --- a/drivers/staging/media/omap4iss/iss.c
>> +++ b/drivers/staging/media/omap4iss/iss.c
>> @@ -893,7 +893,7 @@ void omap4iss_put(struct iss_device *iss)
>> return;
>>
>> mutex_lock(&iss->iss_mutex);
>> - BUG_ON(iss->ref_count == 0);
>> + WARN_ON(iss->ref_count == 0);
>
> ref_counting bugs often have a security aspect. BUG_ON() is probably
> safer here. Better to crash than to lose all your bitcoin.
Okay, Thanks for this.
Regards,
Srishti
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-09-08 14:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-08 14:08 [PATCH] Staging: media: omap4iss: Use WARN_ON() instead of BUG_ON() Srishti Sharma
2017-09-08 14:10 ` [Outreachy kernel] " Julia Lawall
2017-09-08 14:17 ` Srishti Sharma
2017-09-08 14:38 ` Dan Carpenter
2017-09-08 14:59 ` Srishti Sharma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox