* [PATCH] media: imx: Fix VDIC CSI1 selection
@ 2017-09-18 23:08 Tim Harvey
2017-09-18 23:07 ` Steve Longerbeam
0 siblings, 1 reply; 2+ messages in thread
From: Tim Harvey @ 2017-09-18 23:08 UTC (permalink / raw)
To: Steve Longerbeam, Philipp Zabel, Mauro Carvalho Chehab
Cc: linux-media, linux-kernel
When using VDIC with CSI1, make sure to select the correct CSI in
IPU_CONF.
Fixes: f0d9c8924e2c3376 ("[media] media: imx: Add IC subdev drivers")
Suggested-by: Marek Vasut <marex@denx.de>
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
drivers/staging/media/imx/imx-ic-prp.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/imx/imx-ic-prp.c b/drivers/staging/media/imx/imx-ic-prp.c
index c2bb5ef..9e41987 100644
--- a/drivers/staging/media/imx/imx-ic-prp.c
+++ b/drivers/staging/media/imx/imx-ic-prp.c
@@ -320,9 +320,10 @@ static int prp_link_validate(struct v4l2_subdev *sd,
* the ->PRPENC link cannot be enabled if the source
* is the VDIC
*/
- if (priv->sink_sd_prpenc)
+ if (priv->sink_sd_prpenc) {
ret = -EINVAL;
- goto out;
+ goto out;
+ }
} else {
/* the source is a CSI */
if (!csi) {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] media: imx: Fix VDIC CSI1 selection
2017-09-18 23:08 [PATCH] media: imx: Fix VDIC CSI1 selection Tim Harvey
@ 2017-09-18 23:07 ` Steve Longerbeam
0 siblings, 0 replies; 2+ messages in thread
From: Steve Longerbeam @ 2017-09-18 23:07 UTC (permalink / raw)
To: Tim Harvey, Philipp Zabel, Mauro Carvalho Chehab
Cc: linux-media, linux-kernel
Thanks Tim for catching this error.
Acked-by: Steve Longerbeam <steve_longerbeam@mentor.com>
On 09/18/2017 04:08 PM, Tim Harvey wrote:
> When using VDIC with CSI1, make sure to select the correct CSI in
> IPU_CONF.
>
> Fixes: f0d9c8924e2c3376 ("[media] media: imx: Add IC subdev drivers")
> Suggested-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
> drivers/staging/media/imx/imx-ic-prp.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx-ic-prp.c b/drivers/staging/media/imx/imx-ic-prp.c
> index c2bb5ef..9e41987 100644
> --- a/drivers/staging/media/imx/imx-ic-prp.c
> +++ b/drivers/staging/media/imx/imx-ic-prp.c
> @@ -320,9 +320,10 @@ static int prp_link_validate(struct v4l2_subdev *sd,
> * the ->PRPENC link cannot be enabled if the source
> * is the VDIC
> */
> - if (priv->sink_sd_prpenc)
> + if (priv->sink_sd_prpenc) {
> ret = -EINVAL;
> - goto out;
> + goto out;
> + }
> } else {
> /* the source is a CSI */
> if (!csi) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-18 23:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-18 23:08 [PATCH] media: imx: Fix VDIC CSI1 selection Tim Harvey
2017-09-18 23:07 ` Steve Longerbeam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox