public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-media@vger.kernel.org
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Subject: Re: [PATCH] media: v4l2: mem2mem: Fix typos in v4l2_m2m_dev documentation
Date: Tue, 15 Mar 2022 11:04:43 +0000	[thread overview]
Message-ID: <164734228302.856468.1265300057896019550@Monstersaurus> (raw)
In-Reply-To: <20220315102245.15031-1-laurent.pinchart@ideasonboard.com>

Hi Laurent,

Quoting Laurent Pinchart (2022-03-15 10:22:45)
> The v4l2_m2m_dev structure documentation incorrectly references the
> v4l2_m2m_unregister_media_controller() function when it actually means
> v4l2_m2m_register_media_controller(). Fix it.
> 

Eeep, that's a bit of an ooops.

Patch looks good.

I guess Doc-only means no fixes tag required?

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  drivers/media/v4l2-core/v4l2-mem2mem.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c b/drivers/media/v4l2-core/v4l2-mem2mem.c
> index e2654b422334..ed1280adf7ff 100644
> --- a/drivers/media/v4l2-core/v4l2-mem2mem.c
> +++ b/drivers/media/v4l2-core/v4l2-mem2mem.c
> @@ -68,16 +68,16 @@ static const char * const m2m_entity_name[] = {
>   * struct v4l2_m2m_dev - per-device context
>   * @source:            &struct media_entity pointer with the source entity
>   *                     Used only when the M2M device is registered via
> - *                     v4l2_m2m_unregister_media_controller().
> + *                     v4l2_m2m_register_media_controller().
>   * @source_pad:                &struct media_pad with the source pad.
>   *                     Used only when the M2M device is registered via
> - *                     v4l2_m2m_unregister_media_controller().
> + *                     v4l2_m2m_register_media_controller().
>   * @sink:              &struct media_entity pointer with the sink entity
>   *                     Used only when the M2M device is registered via
> - *                     v4l2_m2m_unregister_media_controller().
> + *                     v4l2_m2m_register_media_controller().
>   * @sink_pad:          &struct media_pad with the sink pad.
>   *                     Used only when the M2M device is registered via
> - *                     v4l2_m2m_unregister_media_controller().
> + *                     v4l2_m2m_register_media_controller().
>   * @proc:              &struct media_entity pointer with the M2M device itself.
>   * @proc_pads:         &struct media_pad with the @proc pads.
>   *                     Used only when the M2M device is registered via
> -- 
> Regards,
> 
> Laurent Pinchart
>

      reply	other threads:[~2022-03-15 11:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-15 10:22 [PATCH] media: v4l2: mem2mem: Fix typos in v4l2_m2m_dev documentation Laurent Pinchart
2022-03-15 11:04 ` Kieran Bingham [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=164734228302.856468.1265300057896019550@Monstersaurus \
    --to=kieran.bingham@ideasonboard.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox