* [PATCH] media: v4l2: mem2mem: Fix typos in v4l2_m2m_dev documentation
@ 2022-03-15 10:22 Laurent Pinchart
2022-03-15 11:04 ` Kieran Bingham
0 siblings, 1 reply; 2+ messages in thread
From: Laurent Pinchart @ 2022-03-15 10:22 UTC (permalink / raw)
To: linux-media; +Cc: Hans Verkuil
The v4l2_m2m_dev structure documentation incorrectly references the
v4l2_m2m_unregister_media_controller() function when it actually means
v4l2_m2m_register_media_controller(). Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/media/v4l2-core/v4l2-mem2mem.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c b/drivers/media/v4l2-core/v4l2-mem2mem.c
index e2654b422334..ed1280adf7ff 100644
--- a/drivers/media/v4l2-core/v4l2-mem2mem.c
+++ b/drivers/media/v4l2-core/v4l2-mem2mem.c
@@ -68,16 +68,16 @@ static const char * const m2m_entity_name[] = {
* struct v4l2_m2m_dev - per-device context
* @source: &struct media_entity pointer with the source entity
* Used only when the M2M device is registered via
- * v4l2_m2m_unregister_media_controller().
+ * v4l2_m2m_register_media_controller().
* @source_pad: &struct media_pad with the source pad.
* Used only when the M2M device is registered via
- * v4l2_m2m_unregister_media_controller().
+ * v4l2_m2m_register_media_controller().
* @sink: &struct media_entity pointer with the sink entity
* Used only when the M2M device is registered via
- * v4l2_m2m_unregister_media_controller().
+ * v4l2_m2m_register_media_controller().
* @sink_pad: &struct media_pad with the sink pad.
* Used only when the M2M device is registered via
- * v4l2_m2m_unregister_media_controller().
+ * v4l2_m2m_register_media_controller().
* @proc: &struct media_entity pointer with the M2M device itself.
* @proc_pads: &struct media_pad with the @proc pads.
* Used only when the M2M device is registered via
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: v4l2: mem2mem: Fix typos in v4l2_m2m_dev documentation
2022-03-15 10:22 [PATCH] media: v4l2: mem2mem: Fix typos in v4l2_m2m_dev documentation Laurent Pinchart
@ 2022-03-15 11:04 ` Kieran Bingham
0 siblings, 0 replies; 2+ messages in thread
From: Kieran Bingham @ 2022-03-15 11:04 UTC (permalink / raw)
To: Laurent Pinchart, linux-media; +Cc: Hans Verkuil
Hi Laurent,
Quoting Laurent Pinchart (2022-03-15 10:22:45)
> The v4l2_m2m_dev structure documentation incorrectly references the
> v4l2_m2m_unregister_media_controller() function when it actually means
> v4l2_m2m_register_media_controller(). Fix it.
>
Eeep, that's a bit of an ooops.
Patch looks good.
I guess Doc-only means no fixes tag required?
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/v4l2-core/v4l2-mem2mem.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c b/drivers/media/v4l2-core/v4l2-mem2mem.c
> index e2654b422334..ed1280adf7ff 100644
> --- a/drivers/media/v4l2-core/v4l2-mem2mem.c
> +++ b/drivers/media/v4l2-core/v4l2-mem2mem.c
> @@ -68,16 +68,16 @@ static const char * const m2m_entity_name[] = {
> * struct v4l2_m2m_dev - per-device context
> * @source: &struct media_entity pointer with the source entity
> * Used only when the M2M device is registered via
> - * v4l2_m2m_unregister_media_controller().
> + * v4l2_m2m_register_media_controller().
> * @source_pad: &struct media_pad with the source pad.
> * Used only when the M2M device is registered via
> - * v4l2_m2m_unregister_media_controller().
> + * v4l2_m2m_register_media_controller().
> * @sink: &struct media_entity pointer with the sink entity
> * Used only when the M2M device is registered via
> - * v4l2_m2m_unregister_media_controller().
> + * v4l2_m2m_register_media_controller().
> * @sink_pad: &struct media_pad with the sink pad.
> * Used only when the M2M device is registered via
> - * v4l2_m2m_unregister_media_controller().
> + * v4l2_m2m_register_media_controller().
> * @proc: &struct media_entity pointer with the M2M device itself.
> * @proc_pads: &struct media_pad with the @proc pads.
> * Used only when the M2M device is registered via
> --
> Regards,
>
> Laurent Pinchart
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-15 11:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-15 10:22 [PATCH] media: v4l2: mem2mem: Fix typos in v4l2_m2m_dev documentation Laurent Pinchart
2022-03-15 11:04 ` Kieran Bingham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox