From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Simon Horman <horms@verge.net.au>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Nobuhiro Iwamatsu <iwamatsu@nigauri.org>,
Nobuhiro Iwamatsu <iwamatsu@debian.org>
Subject: Re: [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header
Date: Wed, 23 May 2018 11:37:47 +0300 [thread overview]
Message-ID: <1905091.9toDD4m9Wz@avalon> (raw)
In-Reply-To: <20180523083324.vvtadkkoz6ti5qi7@verge.net.au>
Hi Simon,
On Wednesday, 23 May 2018 11:33:26 EEST Simon Horman wrote:
> On Tue, May 22, 2018 at 01:04:56PM +0200, Geert Uytterhoeven wrote:
> > On Tue, May 22, 2018 at 11:05 AM, Simon Horman <horms@verge.net.au> wrote:
> >>> --- a/drivers/media/platform/vsp1/vsp1_regs.h
> >>> +++ b/drivers/media/platform/vsp1/vsp1_regs.h
> >>> @@ -1,4 +1,4 @@
> >>> -/* SPDX-License-Identifier: GPL-2.0 */
> >>> +/* SPDX-License-Identifier: GPL-2.0+ */
> >>
> >> While you are changing this line, I believe the correct format is
> >> to use a '//' comment.
> >>
> >> i.e.:
> >>
> >> // SPDX-License-Identifier: GPL-2.0+
> >
> > Not for C header files, only for C source files.
>
> Wow!
Yes, it's a mess :-( The rationale is that the assembler doesn't support C++-
style comments, so we need to use C-style comments in header files. We should
really have standardized usage of C-style comments everywhere, it makes no
sense to me.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2018-05-23 8:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-20 7:24 [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header Laurent Pinchart
2018-05-20 23:00 ` Nobuhiro Iwamatsu
2018-05-22 9:05 ` Simon Horman
2018-05-22 11:04 ` Geert Uytterhoeven
2018-05-23 8:33 ` Simon Horman
2018-05-23 8:37 ` Laurent Pinchart [this message]
2018-05-23 9:09 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1905091.9toDD4m9Wz@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=iwamatsu@debian.org \
--cc=iwamatsu@nigauri.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox