* [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header @ 2018-05-20 7:24 Laurent Pinchart 2018-05-20 23:00 ` Nobuhiro Iwamatsu 2018-05-22 9:05 ` Simon Horman 0 siblings, 2 replies; 7+ messages in thread From: Laurent Pinchart @ 2018-05-20 7:24 UTC (permalink / raw) To: linux-media, linux-renesas-soc; +Cc: Nobuhiro Iwamatsu, Nobuhiro Iwamatsu All source files of the vsp1 driver are licensed under the GPLv2+ except for vsp1_regs.h which is licensed under GPLv2. This is caused by a bad copy&paste that dates back from the initial version of the driver. Fix it. Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com> Acked-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Acked-by: Sergei Shtylyov<sergei.shtylyov@cogentembedded.com> Acked-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- Iwamatsu-san, While working on the VSP1 driver I noticed that all source files are licensed under the GPLv2+ except for vsp1_regs.h which is licensed under GPLv2. I'd like to fix this inconsistency. As you have contributed to that file, could you please provide your explicit ack if you agree to this change ? --- drivers/media/platform/vsp1/vsp1_regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/vsp1/vsp1_regs.h b/drivers/media/platform/vsp1/vsp1_regs.h index 0d249ff9f564..e82661216c1d 100644 --- a/drivers/media/platform/vsp1/vsp1_regs.h +++ b/drivers/media/platform/vsp1/vsp1_regs.h @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0 */ +/* SPDX-License-Identifier: GPL-2.0+ */ /* * vsp1_regs.h -- R-Car VSP1 Registers Definitions * -- Regards, Laurent Pinchart ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header 2018-05-20 7:24 [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header Laurent Pinchart @ 2018-05-20 23:00 ` Nobuhiro Iwamatsu 2018-05-22 9:05 ` Simon Horman 1 sibling, 0 replies; 7+ messages in thread From: Nobuhiro Iwamatsu @ 2018-05-20 23:00 UTC (permalink / raw) To: Laurent Pinchart; +Cc: linux-media, linux-renesas-soc Hi, 2018-05-20 16:24 GMT+09:00 Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>: > All source files of the vsp1 driver are licensed under the GPLv2+ except > for vsp1_regs.h which is licensed under GPLv2. This is caused by a bad > copy&paste that dates back from the initial version of the driver. Fix > it. > > Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com> > Acked-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > Acked-by: Sergei Shtylyov<sergei.shtylyov@cogentembedded.com> > Acked-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > Iwamatsu-san, > > While working on the VSP1 driver I noticed that all source files are > licensed under the GPLv2+ except for vsp1_regs.h which is licensed under > GPLv2. I'd like to fix this inconsistency. As you have contributed to > that file, could you please provide your explicit ack if you agree to > this change ? Yes, I agree with this change. Acked-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org> > --- > drivers/media/platform/vsp1/vsp1_regs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/vsp1/vsp1_regs.h b/drivers/media/platform/vsp1/vsp1_regs.h > index 0d249ff9f564..e82661216c1d 100644 > --- a/drivers/media/platform/vsp1/vsp1_regs.h > +++ b/drivers/media/platform/vsp1/vsp1_regs.h > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: GPL-2.0 */ > +/* SPDX-License-Identifier: GPL-2.0+ */ > /* > * vsp1_regs.h -- R-Car VSP1 Registers Definitions > * > -- > Regards, > > Laurent Pinchart > Best regards, Nobuhiro -- Nobuhiro Iwamatsu iwamatsu at {nigauri.org / debian.org} GPG ID: 40AD1FA6 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header 2018-05-20 7:24 [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header Laurent Pinchart 2018-05-20 23:00 ` Nobuhiro Iwamatsu @ 2018-05-22 9:05 ` Simon Horman 2018-05-22 11:04 ` Geert Uytterhoeven 1 sibling, 1 reply; 7+ messages in thread From: Simon Horman @ 2018-05-22 9:05 UTC (permalink / raw) To: Laurent Pinchart Cc: linux-media, linux-renesas-soc, Nobuhiro Iwamatsu, Nobuhiro Iwamatsu On Sun, May 20, 2018 at 10:24:37AM +0300, Laurent Pinchart wrote: > All source files of the vsp1 driver are licensed under the GPLv2+ except > for vsp1_regs.h which is licensed under GPLv2. This is caused by a bad > copy&paste that dates back from the initial version of the driver. Fix > it. > > Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com> > Acked-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > Acked-by: Sergei Shtylyov<sergei.shtylyov@cogentembedded.com> > Acked-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > Iwamatsu-san, > > While working on the VSP1 driver I noticed that all source files are > licensed under the GPLv2+ except for vsp1_regs.h which is licensed under > GPLv2. I'd like to fix this inconsistency. As you have contributed to > that file, could you please provide your explicit ack if you agree to > this change ? > --- > drivers/media/platform/vsp1/vsp1_regs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/vsp1/vsp1_regs.h b/drivers/media/platform/vsp1/vsp1_regs.h > index 0d249ff9f564..e82661216c1d 100644 > --- a/drivers/media/platform/vsp1/vsp1_regs.h > +++ b/drivers/media/platform/vsp1/vsp1_regs.h > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: GPL-2.0 */ > +/* SPDX-License-Identifier: GPL-2.0+ */ While you are changing this line, I believe the correct format is to use a '//' comment. i.e.: // SPDX-License-Identifier: GPL-2.0+ > /* > * vsp1_regs.h -- R-Car VSP1 Registers Definitions > * > -- > Regards, > > Laurent Pinchart > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header 2018-05-22 9:05 ` Simon Horman @ 2018-05-22 11:04 ` Geert Uytterhoeven 2018-05-23 8:33 ` Simon Horman 0 siblings, 1 reply; 7+ messages in thread From: Geert Uytterhoeven @ 2018-05-22 11:04 UTC (permalink / raw) To: Simon Horman Cc: Laurent Pinchart, Linux Media Mailing List, Linux-Renesas, Nobuhiro Iwamatsu, Nobuhiro Iwamatsu Hi Simon, On Tue, May 22, 2018 at 11:05 AM, Simon Horman <horms@verge.net.au> wrote: >> --- a/drivers/media/platform/vsp1/vsp1_regs.h >> +++ b/drivers/media/platform/vsp1/vsp1_regs.h >> @@ -1,4 +1,4 @@ >> -/* SPDX-License-Identifier: GPL-2.0 */ >> +/* SPDX-License-Identifier: GPL-2.0+ */ > > While you are changing this line, I believe the correct format is > to use a '//' comment. > > i.e.: > > // SPDX-License-Identifier: GPL-2.0+ Not for C header files, only for C source files. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header 2018-05-22 11:04 ` Geert Uytterhoeven @ 2018-05-23 8:33 ` Simon Horman 2018-05-23 8:37 ` Laurent Pinchart 0 siblings, 1 reply; 7+ messages in thread From: Simon Horman @ 2018-05-23 8:33 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Laurent Pinchart, Linux Media Mailing List, Linux-Renesas, Nobuhiro Iwamatsu, Nobuhiro Iwamatsu On Tue, May 22, 2018 at 01:04:56PM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Tue, May 22, 2018 at 11:05 AM, Simon Horman <horms@verge.net.au> wrote: > >> --- a/drivers/media/platform/vsp1/vsp1_regs.h > >> +++ b/drivers/media/platform/vsp1/vsp1_regs.h > >> @@ -1,4 +1,4 @@ > >> -/* SPDX-License-Identifier: GPL-2.0 */ > >> +/* SPDX-License-Identifier: GPL-2.0+ */ > > > > While you are changing this line, I believe the correct format is > > to use a '//' comment. > > > > i.e.: > > > > // SPDX-License-Identifier: GPL-2.0+ > > Not for C header files, only for C source files. Wow! ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header 2018-05-23 8:33 ` Simon Horman @ 2018-05-23 8:37 ` Laurent Pinchart 2018-05-23 9:09 ` Simon Horman 0 siblings, 1 reply; 7+ messages in thread From: Laurent Pinchart @ 2018-05-23 8:37 UTC (permalink / raw) To: Simon Horman Cc: Geert Uytterhoeven, Laurent Pinchart, Linux Media Mailing List, Linux-Renesas, Nobuhiro Iwamatsu, Nobuhiro Iwamatsu Hi Simon, On Wednesday, 23 May 2018 11:33:26 EEST Simon Horman wrote: > On Tue, May 22, 2018 at 01:04:56PM +0200, Geert Uytterhoeven wrote: > > On Tue, May 22, 2018 at 11:05 AM, Simon Horman <horms@verge.net.au> wrote: > >>> --- a/drivers/media/platform/vsp1/vsp1_regs.h > >>> +++ b/drivers/media/platform/vsp1/vsp1_regs.h > >>> @@ -1,4 +1,4 @@ > >>> -/* SPDX-License-Identifier: GPL-2.0 */ > >>> +/* SPDX-License-Identifier: GPL-2.0+ */ > >> > >> While you are changing this line, I believe the correct format is > >> to use a '//' comment. > >> > >> i.e.: > >> > >> // SPDX-License-Identifier: GPL-2.0+ > > > > Not for C header files, only for C source files. > > Wow! Yes, it's a mess :-( The rationale is that the assembler doesn't support C++- style comments, so we need to use C-style comments in header files. We should really have standardized usage of C-style comments everywhere, it makes no sense to me. -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header 2018-05-23 8:37 ` Laurent Pinchart @ 2018-05-23 9:09 ` Simon Horman 0 siblings, 0 replies; 7+ messages in thread From: Simon Horman @ 2018-05-23 9:09 UTC (permalink / raw) To: Laurent Pinchart Cc: Geert Uytterhoeven, Laurent Pinchart, Linux Media Mailing List, Linux-Renesas, Nobuhiro Iwamatsu, Nobuhiro Iwamatsu On Wed, May 23, 2018 at 11:37:47AM +0300, Laurent Pinchart wrote: > Hi Simon, > > On Wednesday, 23 May 2018 11:33:26 EEST Simon Horman wrote: > > On Tue, May 22, 2018 at 01:04:56PM +0200, Geert Uytterhoeven wrote: > > > On Tue, May 22, 2018 at 11:05 AM, Simon Horman <horms@verge.net.au> wrote: > > >>> --- a/drivers/media/platform/vsp1/vsp1_regs.h > > >>> +++ b/drivers/media/platform/vsp1/vsp1_regs.h > > >>> @@ -1,4 +1,4 @@ > > >>> -/* SPDX-License-Identifier: GPL-2.0 */ > > >>> +/* SPDX-License-Identifier: GPL-2.0+ */ > > >> > > >> While you are changing this line, I believe the correct format is > > >> to use a '//' comment. > > >> > > >> i.e.: > > >> > > >> // SPDX-License-Identifier: GPL-2.0+ > > > > > > Not for C header files, only for C source files. > > > > Wow! > > Yes, it's a mess :-( The rationale is that the assembler doesn't support C++- > style comments, so we need to use C-style comments in header files. We should > really have standardized usage of C-style comments everywhere, it makes no > sense to me. I'm reading this email while standing on my head and things make much more sense :) ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-05-23 9:10 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-05-20 7:24 [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header Laurent Pinchart 2018-05-20 23:00 ` Nobuhiro Iwamatsu 2018-05-22 9:05 ` Simon Horman 2018-05-22 11:04 ` Geert Uytterhoeven 2018-05-23 8:33 ` Simon Horman 2018-05-23 8:37 ` Laurent Pinchart 2018-05-23 9:09 ` Simon Horman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox