* [PATCH] pvrusb2: Drop client_register/unregister stubs
@ 2009-04-04 21:13 Jean Delvare
2009-04-04 23:32 ` Mike Isely
0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2009-04-04 21:13 UTC (permalink / raw)
To: Mike Isely; +Cc: LMML
The client_register and client_unregister methods are optional so
there is no point in defining stub ones. Especially when these methods
are likely to be removed soon.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
linux/drivers/media/video/pvrusb2/pvrusb2-i2c-core.c | 12 ------------
1 file changed, 12 deletions(-)
--- v4l-dvb.orig/linux/drivers/media/video/pvrusb2/pvrusb2-i2c-core.c 2009-04-04 13:58:40.000000000 +0200
+++ v4l-dvb/linux/drivers/media/video/pvrusb2/pvrusb2-i2c-core.c 2009-04-04 22:12:21.000000000 +0200
@@ -595,16 +595,6 @@ static u32 pvr2_i2c_functionality(struct
return I2C_FUNC_SMBUS_EMUL | I2C_FUNC_I2C;
}
-static int pvr2_i2c_attach_inform(struct i2c_client *client)
-{
- return 0;
-}
-
-static int pvr2_i2c_detach_inform(struct i2c_client *client)
-{
- return 0;
-}
-
static struct i2c_algorithm pvr2_i2c_algo_template = {
.master_xfer = pvr2_i2c_xfer,
.functionality = pvr2_i2c_functionality,
@@ -617,8 +607,6 @@ static struct i2c_adapter pvr2_i2c_adap_
.owner = THIS_MODULE,
.class = 0,
.id = I2C_HW_B_BT848,
- .client_register = pvr2_i2c_attach_inform,
- .client_unregister = pvr2_i2c_detach_inform,
};
--
Jean Delvare
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] pvrusb2: Drop client_register/unregister stubs
2009-04-04 21:13 [PATCH] pvrusb2: Drop client_register/unregister stubs Jean Delvare
@ 2009-04-04 23:32 ` Mike Isely
0 siblings, 0 replies; 2+ messages in thread
From: Mike Isely @ 2009-04-04 23:32 UTC (permalink / raw)
To: Jean Delvare; +Cc: LMML, Mike Isely at pobox
Acked-by: Mike Isely <isely@pobox.com>
On Sat, 4 Apr 2009, Jean Delvare wrote:
> The client_register and client_unregister methods are optional so
> there is no point in defining stub ones. Especially when these methods
> are likely to be removed soon.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> ---
> linux/drivers/media/video/pvrusb2/pvrusb2-i2c-core.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> --- v4l-dvb.orig/linux/drivers/media/video/pvrusb2/pvrusb2-i2c-core.c 2009-04-04 13:58:40.000000000 +0200
> +++ v4l-dvb/linux/drivers/media/video/pvrusb2/pvrusb2-i2c-core.c 2009-04-04 22:12:21.000000000 +0200
> @@ -595,16 +595,6 @@ static u32 pvr2_i2c_functionality(struct
> return I2C_FUNC_SMBUS_EMUL | I2C_FUNC_I2C;
> }
>
> -static int pvr2_i2c_attach_inform(struct i2c_client *client)
> -{
> - return 0;
> -}
> -
> -static int pvr2_i2c_detach_inform(struct i2c_client *client)
> -{
> - return 0;
> -}
> -
> static struct i2c_algorithm pvr2_i2c_algo_template = {
> .master_xfer = pvr2_i2c_xfer,
> .functionality = pvr2_i2c_functionality,
> @@ -617,8 +607,6 @@ static struct i2c_adapter pvr2_i2c_adap_
> .owner = THIS_MODULE,
> .class = 0,
> .id = I2C_HW_B_BT848,
> - .client_register = pvr2_i2c_attach_inform,
> - .client_unregister = pvr2_i2c_detach_inform,
> };
>
>
>
>
--
Mike Isely
isely @ pobox (dot) com
PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-04 23:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-04 21:13 [PATCH] pvrusb2: Drop client_register/unregister stubs Jean Delvare
2009-04-04 23:32 ` Mike Isely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox