From: Jean Delvare <khali@linux-fr.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
linux-media@vger.kernel.org, Janne Grunau <j@jannau.net>,
Jarod Wilson <jarod@redhat.com>
Subject: Re: [GIT PATCHES FOR 2.6.37] Remove v4l2-i2c-drv.h and most of i2c-id.h
Date: Thu, 23 Sep 2010 11:44:20 +0200 [thread overview]
Message-ID: <20100923114420.746a605f@endymion.delvare> (raw)
In-Reply-To: <201009230814.43504.hverkuil@xs4all.nl>
Hi Hans,
On Thu, 23 Sep 2010 08:14:43 +0200, Hans Verkuil wrote:
> Jean, I did a grep of who is still including i2c-id.h (excluding media drivers):
>
> drivers/gpu/drm/nouveau/nouveau_i2c.h:#include <linux/i2c-id.h>
> drivers/gpu/drm/radeon/radeon_mode.h:#include <linux/i2c-id.h>
> drivers/gpu/drm/i915/intel_drv.h:#include <linux/i2c-id.h>
> drivers/gpu/drm/i915/intel_i2c.c:#include <linux/i2c-id.h>
> drivers/video/i810/i810.h:#include <linux/i2c-id.h>
> drivers/video/intelfb/intelfb_i2c.c:#include <linux/i2c-id.h>
> drivers/video/savage/savagefb.h:#include <linux/i2c-id.h>
> drivers/video/aty/radeon_i2c.c:#include <linux/i2c-id.h>
> drivers/i2c/busses/i2c-s3c2410.c:#include <linux/i2c-id.h>
> drivers/i2c/busses/i2c-pxa.c:#include <linux/i2c-id.h>
> drivers/i2c/busses/i2c-ibm_iic.c:#include <linux/i2c-id.h>
I additionally have drivers/i2c/busses/i2c-nuc900.c.
> AFAIK none of these actually need this include. It's probably a good idea for
> you to remove together with
Will do, thanks for suggesting.
> this obsolete I2C_HW_B_RIVA:
>
> drivers/video/riva/rivafb-i2c.c: chan->adapter.id = I2C_HW_B_RIVA;
I'll have to wait for your cleanup to hit upstream before I can remove
that one.
--
Jean Delvare
next prev parent reply other threads:[~2010-09-23 9:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 20:00 [GIT PATCHES FOR 2.6.37] Remove v4l2-i2c-drv.h and most of i2c-id.h Hans Verkuil
2010-09-16 10:39 ` Janne Grunau
2010-09-16 13:30 ` Jean Delvare
2010-09-22 22:15 ` Mauro Carvalho Chehab
2010-09-23 5:56 ` Hans Verkuil
2010-09-23 4:18 ` Mauro Carvalho Chehab
2010-09-23 6:14 ` Hans Verkuil
2010-09-23 9:44 ` Jean Delvare [this message]
2010-09-23 9:59 ` Hans Verkuil
2010-09-23 11:21 ` Jean Delvare
2010-09-25 6:09 ` Mauro Carvalho Chehab
2010-09-26 20:47 ` Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100923114420.746a605f@endymion.delvare \
--to=khali@linux-fr.org \
--cc=hverkuil@xs4all.nl \
--cc=j@jannau.net \
--cc=jarod@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox