From: Jean Delvare <khali@linux-fr.org>
To: "Hans Verkuil" <hverkuil@xs4all.nl>
Cc: "Mauro Carvalho Chehab" <mchehab@redhat.com>,
linux-media@vger.kernel.org, "Janne Grunau" <j@jannau.net>,
"Jarod Wilson" <jarod@redhat.com>
Subject: Re: [GIT PATCHES FOR 2.6.37] Remove v4l2-i2c-drv.h and most of i2c-id.h
Date: Thu, 23 Sep 2010 13:21:10 +0200 [thread overview]
Message-ID: <20100923132110.69f6aab8@endymion.delvare> (raw)
In-Reply-To: <a7c1e59279e4144dc224cc7978d3708c.squirrel@webmail.xs4all.nl>
On Thu, 23 Sep 2010 11:59:55 +0200, Hans Verkuil wrote:
> > On Thu, 23 Sep 2010 08:14:43 +0200, Hans Verkuil wrote:
> >> this obsolete I2C_HW_B_RIVA:
> >>
> >> drivers/video/riva/rivafb-i2c.c: chan->adapter.id
> >> = I2C_HW_B_RIVA;
> >
> > I'll have to wait for your cleanup to hit upstream before I can remove
> > that one.
>
> No need to wait. All that happens if this is removed is that the bogus
> initialization function in tvaudio is no longer doing anything. And when
> my patch is merged, then that function is removed completely.
Sure, but I still think it's easier to let you merge your changes
first. After that, I can kill the whole thing without a thinking and
without the need to explain why it is safe to do - because it will be
totally obvious then.
Thanks a lot for your work!
--
Jean Delvare
next prev parent reply other threads:[~2010-09-23 11:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 20:00 [GIT PATCHES FOR 2.6.37] Remove v4l2-i2c-drv.h and most of i2c-id.h Hans Verkuil
2010-09-16 10:39 ` Janne Grunau
2010-09-16 13:30 ` Jean Delvare
2010-09-22 22:15 ` Mauro Carvalho Chehab
2010-09-23 5:56 ` Hans Verkuil
2010-09-23 4:18 ` Mauro Carvalho Chehab
2010-09-23 6:14 ` Hans Verkuil
2010-09-23 9:44 ` Jean Delvare
2010-09-23 9:59 ` Hans Verkuil
2010-09-23 11:21 ` Jean Delvare [this message]
2010-09-25 6:09 ` Mauro Carvalho Chehab
2010-09-26 20:47 ` Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100923132110.69f6aab8@endymion.delvare \
--to=khali@linux-fr.org \
--cc=hverkuil@xs4all.nl \
--cc=j@jannau.net \
--cc=jarod@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox