Linux Media Controller development
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: unlisted-recipients:; (no To-header on input)@casper.infradead.org
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: [PATCH 5/8] [media] gspca: Fix a warning for using len before filling it
Date: Mon, 27 Dec 2010 14:22:45 -0200	[thread overview]
Message-ID: <20101227142245.6db00c9a@gaivota> (raw)
In-Reply-To: <cover.1293466891.git.mchehab@redhat.com>

The check for status errors is now before the check for len. That's
ok. However, the error printk's for the status error prints the URB
length. This generates this error:

drivers/media/video/gspca/gspca.c: In function ‘fill_frame’:
drivers/media/video/gspca/gspca.c:305:9: warning: ‘len’ may be used uninitialized in this function

The fix is as simple as moving the len init to happen before the checks.

Cc: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

diff --git a/drivers/media/video/gspca/gspca.c b/drivers/media/video/gspca/gspca.c
index 92b5dfb..80b31eb 100644
--- a/drivers/media/video/gspca/gspca.c
+++ b/drivers/media/video/gspca/gspca.c
@@ -318,6 +318,7 @@ static void fill_frame(struct gspca_dev *gspca_dev,
 	}
 	pkt_scan = gspca_dev->sd_desc->pkt_scan;
 	for (i = 0; i < urb->number_of_packets; i++) {
+		len = urb->iso_frame_desc[i].actual_length;
 
 		/* check the packet status and length */
 		st = urb->iso_frame_desc[i].status;
@@ -327,7 +328,6 @@ static void fill_frame(struct gspca_dev *gspca_dev,
 			gspca_dev->last_packet_type = DISCARD_PACKET;
 			continue;
 		}
-		len = urb->iso_frame_desc[i].actual_length;
 		if (len == 0) {
 			if (gspca_dev->empty_packet == 0)
 				gspca_dev->empty_packet = 1;
-- 
1.7.3.4



  parent reply	other threads:[~2010-12-27 16:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1293466891.git.mchehab@redhat.com>
2010-12-27 16:22 ` [PATCH 8/8] [media] streamzap: Fix a compilation warning when compiled builtin Mauro Carvalho Chehab
2010-12-27 16:22 ` [PATCH 7/8] [media] af9013: Fix a compilation warning Mauro Carvalho Chehab
2010-12-27 16:22 ` [PATCH 6/8] [media] stv090x: Fix some compilation warnings Mauro Carvalho Chehab
2010-12-27 16:22 ` Mauro Carvalho Chehab [this message]
2010-12-27 16:22 ` [PATCH 4/8] [media] dib7000m/dib7000p: Add support for TRANSMISSION_MODE_4K Mauro Carvalho Chehab
2010-12-27 16:22 ` [PATCH 3/8] [media] lirc_zilog: Fix a warning Mauro Carvalho Chehab
2010-12-27 16:22 ` [PATCH 2/8] [media] radio-wl1273: Fix two warnings Mauro Carvalho Chehab
2010-12-27 16:22 ` [PATCH 1/8] [media] dmxdev: Fix a compilation warning due to a bad type Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101227142245.6db00c9a@gaivota \
    --to=mchehab@redhat.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox