Linux Media Controller development
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: unlisted-recipients:; (no To-header on input)@casper.infradead.org
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: [PATCH 2/8] [media] radio-wl1273: Fix two warnings
Date: Mon, 27 Dec 2010 14:22:48 -0200	[thread overview]
Message-ID: <20101227142248.584002fb@gaivota> (raw)
In-Reply-To: <cover.1293466891.git.mchehab@redhat.com>

drivers/media/radio/radio-wl1273.c: In function ‘wl1273_fm_upload_firmware_patch’:
drivers/media/radio/radio-wl1273.c:675:2: warning: ‘n’ may be used uninitialized in this function
drivers/media/radio/radio-wl1273.c:675:2: warning: ‘i’ may be used uninitialized in this function

Those vars are never initialized, and the debug message makes no sense, as it
will show just two random values.

Cc: Matti J. Aaltonen <matti.j.aaltonen@nokia.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

diff --git a/drivers/media/radio/radio-wl1273.c b/drivers/media/radio/radio-wl1273.c
index 1813790..dd6bd36 100644
--- a/drivers/media/radio/radio-wl1273.c
+++ b/drivers/media/radio/radio-wl1273.c
@@ -645,7 +645,7 @@ static int wl1273_fm_upload_firmware_patch(struct wl1273_device *radio)
 	const char *fw_name = "radio-wl1273-fw.bin";
 	struct device *dev = radio->dev;
 	__u8 *ptr;
-	int i, n, r;
+	int r;
 
 	dev_dbg(dev, "%s:\n", __func__);
 
@@ -672,7 +672,6 @@ static int wl1273_fm_upload_firmware_patch(struct wl1273_device *radio)
 	/* ignore possible error here */
 	wl1273_fm_write_cmd(core, WL1273_RESET, 0);
 
-	dev_dbg(dev, "n: %d, i: %d\n", n, i);
 	dev_dbg(dev, "%s - download OK, r: %d\n", __func__, r);
 out:
 	release_firmware(fw_p);
-- 
1.7.3.4



  parent reply	other threads:[~2010-12-27 16:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1293466891.git.mchehab@redhat.com>
2010-12-27 16:22 ` [PATCH 8/8] [media] streamzap: Fix a compilation warning when compiled builtin Mauro Carvalho Chehab
2010-12-27 16:22 ` [PATCH 7/8] [media] af9013: Fix a compilation warning Mauro Carvalho Chehab
2010-12-27 16:22 ` [PATCH 6/8] [media] stv090x: Fix some compilation warnings Mauro Carvalho Chehab
2010-12-27 16:22 ` [PATCH 5/8] [media] gspca: Fix a warning for using len before filling it Mauro Carvalho Chehab
2010-12-27 16:22 ` [PATCH 4/8] [media] dib7000m/dib7000p: Add support for TRANSMISSION_MODE_4K Mauro Carvalho Chehab
2010-12-27 16:22 ` [PATCH 3/8] [media] lirc_zilog: Fix a warning Mauro Carvalho Chehab
2010-12-27 16:22 ` Mauro Carvalho Chehab [this message]
2010-12-27 16:22 ` [PATCH 1/8] [media] dmxdev: Fix a compilation warning due to a bad type Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101227142248.584002fb@gaivota \
    --to=mchehab@redhat.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox