[PATCH] FM1216ME_MK3 AUX byte for FM mode

public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH] FM1216ME_MK3 AUX byte for FM mode
@ 2009-04-23  5:40 Dmitri Belimov
  2011-09-18 12:44 ` Mauro Carvalho Chehab
  0 siblings, 1 reply; 5+ messages in thread
From: Dmitri Belimov @ 2009-04-23  5:40 UTC (permalink / raw)
  To: linux-media, video4linux-list

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]

Hi All

Write AUX byte to FM1216ME_MK3 when FM mode, better sensitivity. It can be
usefull for other tuners.

diff -r 00a84f86671d linux/drivers/media/common/tuners/tuner-simple.c
--- a/linux/drivers/media/common/tuners/tuner-simple.c	Mon Apr 20 22:07:44 2009 +0000
+++ b/linux/drivers/media/common/tuners/tuner-simple.c	Thu Apr 23 10:26:54 2009 +1000
@@ -751,6 +751,17 @@
 	if (4 != rc)
 		tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc);
 
+	/* Write AUX byte */
+	switch (priv->type) {
+	case TUNER_PHILIPS_FM1216ME_MK3:
+		buffer[2] = 0x98;
+		buffer[3] = 0x20; /* set TOP AGC */
+		rc = tuner_i2c_xfer_send(&priv->i2c_props, buffer, 4);
+		if (4 != rc)
+			tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc);
+		break;
+	}
+
 	return 0;
 }
 
Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov <d.belimov@gmail.com>


With my best regards, Dmitry.

[-- Attachment #2: behold_mk3_fm.patch --]
[-- Type: text/x-patch, Size: 726 bytes --]

diff -r 00a84f86671d linux/drivers/media/common/tuners/tuner-simple.c
--- a/linux/drivers/media/common/tuners/tuner-simple.c	Mon Apr 20 22:07:44 2009 +0000
+++ b/linux/drivers/media/common/tuners/tuner-simple.c	Thu Apr 23 10:26:54 2009 +1000
@@ -751,6 +751,17 @@
 	if (4 != rc)
 		tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc);
 
+	/* Write AUX byte */
+	switch (priv->type) {
+	case TUNER_PHILIPS_FM1216ME_MK3:
+		buffer[2] = 0x98;
+		buffer[3] = 0x20; /* set TOP AGC */
+		rc = tuner_i2c_xfer_send(&priv->i2c_props, buffer, 4);
+		if (4 != rc)
+			tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc);
+		break;
+	}
+
 	return 0;
 }
 
Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov <d.belimov@gmail.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] FM1216ME_MK3 AUX byte for FM mode
  2009-04-23  5:40 [PATCH] FM1216ME_MK3 AUX byte for FM mode Dmitri Belimov
@ 2011-09-18 12:44 ` Mauro Carvalho Chehab
  2011-09-20  7:46   ` Dmitri Belimov
                     ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Mauro Carvalho Chehab @ 2011-09-18 12:44 UTC (permalink / raw)
  To: Dmitri Belimov; +Cc: linux-media

Hi Dmitri,

Em 23-04-2009 02:40, Dmitri Belimov escreveu:
> Hi All
> 
> Write AUX byte to FM1216ME_MK3 when FM mode, better sensitivity. It can be
> usefull for other tuners.

Hmm... Found this patch. It were never applied, but it may make some sense
to apply it.

Could you please double-check if this patch is still valid, and, if so, re-send it
to me?

Thanks!
Mauro


> 
> diff -r 00a84f86671d linux/drivers/media/common/tuners/tuner-simple.c
> --- a/linux/drivers/media/common/tuners/tuner-simple.c	Mon Apr 20 22:07:44 2009 +0000
> +++ b/linux/drivers/media/common/tuners/tuner-simple.c	Thu Apr 23 10:26:54 2009 +1000
> @@ -751,6 +751,17 @@
>  	if (4 != rc)
>  		tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc);
>  
> +	/* Write AUX byte */
> +	switch (priv->type) {
> +	case TUNER_PHILIPS_FM1216ME_MK3:
> +		buffer[2] = 0x98;
> +		buffer[3] = 0x20; /* set TOP AGC */
> +		rc = tuner_i2c_xfer_send(&priv->i2c_props, buffer, 4);
> +		if (4 != rc)
> +			tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc);
> +		break;
> +	}
> +
>  	return 0;
>  }
>  
> Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov <d.belimov@gmail.com>
> 
> 
> With my best regards, Dmitry.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] FM1216ME_MK3 AUX byte for FM mode
  2011-09-18 12:44 ` Mauro Carvalho Chehab
@ 2011-09-20  7:46   ` Dmitri Belimov
  2011-09-28  4:43   ` Dmitri Belimov
  2011-10-27  5:54   ` Dmitri Belimov
  2 siblings, 0 replies; 5+ messages in thread
From: Dmitri Belimov @ 2011-09-20  7:46 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: linux-media

Hi Mauro

Sure. I'll do it ASAP

With my best regards, Dmitry.

> Hi Dmitri,
> 
> Em 23-04-2009 02:40, Dmitri Belimov escreveu:
> > Hi All
> > 
> > Write AUX byte to FM1216ME_MK3 when FM mode, better sensitivity. It
> > can be usefull for other tuners.
> 
> Hmm... Found this patch. It were never applied, but it may make some
> sense to apply it.
> 
> Could you please double-check if this patch is still valid, and, if
> so, re-send it to me?
> 
> Thanks!
> Mauro
> 
> 
> > 
> > diff -r 00a84f86671d
> > linux/drivers/media/common/tuners/tuner-simple.c ---
> > a/linux/drivers/media/common/tuners/tuner-simple.c	Mon Apr
> > 20 22:07:44 2009 +0000 +++
> > b/linux/drivers/media/common/tuners/tuner-simple.c	Thu Apr
> > 23 10:26:54 2009 +1000 @@ -751,6 +751,17 @@ if (4 != rc)
> > tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc); 
> > +	/* Write AUX byte */
> > +	switch (priv->type) {
> > +	case TUNER_PHILIPS_FM1216ME_MK3:
> > +		buffer[2] = 0x98;
> > +		buffer[3] = 0x20; /* set TOP AGC */
> > +		rc = tuner_i2c_xfer_send(&priv->i2c_props, buffer,
> > 4);
> > +		if (4 != rc)
> > +			tuner_warn("i2c i/o error: rc == %d
> > (should be 4)\n", rc);
> > +		break;
> > +	}
> > +
> >  	return 0;
> >  }
> >  
> > Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov
> > <d.belimov@gmail.com>
> > 
> > 
> > With my best regards, Dmitry.
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] FM1216ME_MK3 AUX byte for FM mode
  2011-09-18 12:44 ` Mauro Carvalho Chehab
  2011-09-20  7:46   ` Dmitri Belimov
@ 2011-09-28  4:43   ` Dmitri Belimov
  2011-10-27  5:54   ` Dmitri Belimov
  2 siblings, 0 replies; 5+ messages in thread
From: Dmitri Belimov @ 2011-09-28  4:43 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: linux-media

[-- Attachment #1: Type: text/plain, Size: 1456 bytes --]

Hi Mauro

Need apply this patch. I test it for compile only right now I haven't TV cards with 1216ME_MK3.
I was send ask on our forum for test.

With my best regards, Dmitry.

> Hi Dmitri,
> 
> Em 23-04-2009 02:40, Dmitri Belimov escreveu:
> > Hi All
> > 
> > Write AUX byte to FM1216ME_MK3 when FM mode, better sensitivity. It
> > can be usefull for other tuners.
> 
> Hmm... Found this patch. It were never applied, but it may make some
> sense to apply it.
> 
> Could you please double-check if this patch is still valid, and, if
> so, re-send it to me?
> 
> Thanks!
> Mauro
> 
> 
> > 
> > diff -r 00a84f86671d
> > linux/drivers/media/common/tuners/tuner-simple.c ---
> > a/linux/drivers/media/common/tuners/tuner-simple.c	Mon Apr
> > 20 22:07:44 2009 +0000 +++
> > b/linux/drivers/media/common/tuners/tuner-simple.c	Thu Apr
> > 23 10:26:54 2009 +1000 @@ -751,6 +751,17 @@ if (4 != rc)
> > tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc); 
> > +	/* Write AUX byte */
> > +	switch (priv->type) {
> > +	case TUNER_PHILIPS_FM1216ME_MK3:
> > +		buffer[2] = 0x98;
> > +		buffer[3] = 0x20; /* set TOP AGC */
> > +		rc = tuner_i2c_xfer_send(&priv->i2c_props, buffer,
> > 4);
> > +		if (4 != rc)
> > +			tuner_warn("i2c i/o error: rc == %d
> > (should be 4)\n", rc);
> > +		break;
> > +	}
> > +
> >  	return 0;
> >  }
> >  
> > Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov
> > <d.belimov@gmail.com>
> > 
> > 
> > With my best regards, Dmitry.
> 

[-- Attachment #2: me_mk3_fm.patch --]
[-- Type: text/x-patch, Size: 772 bytes --]

diff --git a/drivers/media/common/tuners/tuner-simple.c b/drivers/media/common/tuners/tuner-simple.c
index f8ee29e..4092200 100644
--- a/drivers/media/common/tuners/tuner-simple.c
+++ b/drivers/media/common/tuners/tuner-simple.c
@@ -751,6 +751,17 @@ static int simple_set_radio_freq(struct dvb_frontend *fe,
 	if (4 != rc)
 		tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc);
 
+	/* Write AUX byte */
+	switch (priv->type) {
+	case TUNER_PHILIPS_FM1216ME_MK3:
+		buffer[2] = 0x98;
+		buffer[3] = 0x20; /* set TOP AGC */
+		rc = tuner_i2c_xfer_send(&priv->i2c_props, buffer, 4);
+		if (4 != rc)
+			tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc);
+		break;
+	}
+
 	return 0;
 }
 

Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov <d.belimov@gmail.com>

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] FM1216ME_MK3 AUX byte for FM mode
  2011-09-18 12:44 ` Mauro Carvalho Chehab
  2011-09-20  7:46   ` Dmitri Belimov
  2011-09-28  4:43   ` Dmitri Belimov
@ 2011-10-27  5:54   ` Dmitri Belimov
  2 siblings, 0 replies; 5+ messages in thread
From: Dmitri Belimov @ 2011-10-27  5:54 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: linux-media

[-- Attachment #1: Type: text/plain, Size: 1390 bytes --]

Hi Mauro

I found TV card and test this patch. Audio is better. Please apply.

With my best regards, Dmitry.

> Hi Dmitri,
> 
> Em 23-04-2009 02:40, Dmitri Belimov escreveu:
> > Hi All
> > 
> > Write AUX byte to FM1216ME_MK3 when FM mode, better sensitivity. It
> > can be usefull for other tuners.
> 
> Hmm... Found this patch. It were never applied, but it may make some
> sense to apply it.
> 
> Could you please double-check if this patch is still valid, and, if
> so, re-send it to me?
> 
> Thanks!
> Mauro
> 
> 
> > 
> > diff -r 00a84f86671d
> > linux/drivers/media/common/tuners/tuner-simple.c ---
> > a/linux/drivers/media/common/tuners/tuner-simple.c	Mon Apr
> > 20 22:07:44 2009 +0000 +++
> > b/linux/drivers/media/common/tuners/tuner-simple.c	Thu Apr
> > 23 10:26:54 2009 +1000 @@ -751,6 +751,17 @@ if (4 != rc)
> > tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc); 
> > +	/* Write AUX byte */
> > +	switch (priv->type) {
> > +	case TUNER_PHILIPS_FM1216ME_MK3:
> > +		buffer[2] = 0x98;
> > +		buffer[3] = 0x20; /* set TOP AGC */
> > +		rc = tuner_i2c_xfer_send(&priv->i2c_props, buffer,
> > 4);
> > +		if (4 != rc)
> > +			tuner_warn("i2c i/o error: rc == %d
> > (should be 4)\n", rc);
> > +		break;
> > +	}
> > +
> >  	return 0;
> >  }
> >  
> > Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov
> > <d.belimov@gmail.com>
> > 
> > 
> > With my best regards, Dmitry.
> 

[-- Attachment #2: me_mk3_fm.patch --]
[-- Type: text/x-patch, Size: 772 bytes --]

diff --git a/drivers/media/common/tuners/tuner-simple.c b/drivers/media/common/tuners/tuner-simple.c
index f8ee29e..4092200 100644
--- a/drivers/media/common/tuners/tuner-simple.c
+++ b/drivers/media/common/tuners/tuner-simple.c
@@ -751,6 +751,17 @@ static int simple_set_radio_freq(struct dvb_frontend *fe,
 	if (4 != rc)
 		tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc);
 
+	/* Write AUX byte */
+	switch (priv->type) {
+	case TUNER_PHILIPS_FM1216ME_MK3:
+		buffer[2] = 0x98;
+		buffer[3] = 0x20; /* set TOP AGC */
+		rc = tuner_i2c_xfer_send(&priv->i2c_props, buffer, 4);
+		if (4 != rc)
+			tuner_warn("i2c i/o error: rc == %d (should be 4)\n", rc);
+		break;
+	}
+
 	return 0;
 }
 

Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov <d.belimov@gmail.com>

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-10-27  5:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-23  5:40 [PATCH] FM1216ME_MK3 AUX byte for FM mode Dmitri Belimov
2011-09-18 12:44 ` Mauro Carvalho Chehab
2011-09-20  7:46   ` Dmitri Belimov
2011-09-28  4:43   ` Dmitri Belimov
2011-10-27  5:54   ` Dmitri Belimov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox