From: Sakari Ailus <sakari.ailus@iki.fi>
To: Joe Perches <joe@perches.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Sakari Ailus <sakari.ailus@nokia.com>
Subject: Re: [trivial PATCH] omap24xxcam-dma: Fix logical test
Date: Mon, 28 Nov 2011 18:04:09 +0200 [thread overview]
Message-ID: <20111128160409.GF29805@valkosipuli.localdomain> (raw)
In-Reply-To: <1322422935.27199.3.camel@Joe-Laptop>
On Sun, Nov 27, 2011 at 11:42:15AM -0800, Joe Perches wrote:
> Likely misuse of & vs &&.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Thanks, Joe!
Acked-by: Sakari Ailus <sakari.ailus@iki.fi>
> ---
> drivers/media/video/omap24xxcam-dma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/omap24xxcam-dma.c b/drivers/media/video/omap24xxcam-dma.c
> index 1d54b86..3ea38a8 100644
> --- a/drivers/media/video/omap24xxcam-dma.c
> +++ b/drivers/media/video/omap24xxcam-dma.c
> @@ -506,7 +506,7 @@ int omap24xxcam_sgdma_queue(struct omap24xxcam_sgdma *sgdma,
> unsigned long flags;
> struct sgdma_state *sg_state;
>
> - if ((sglen < 0) || ((sglen > 0) & !sglist))
> + if ((sglen < 0) || ((sglen > 0) && !sglist))
> return -EINVAL;
>
> spin_lock_irqsave(&sgdma->lock, flags);
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi jabber/XMPP/Gmail: sailus@retiisi.org.uk
prev parent reply other threads:[~2011-11-28 16:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-27 19:42 [trivial PATCH] omap24xxcam-dma: Fix logical test Joe Perches
2011-11-28 16:04 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111128160409.GF29805@valkosipuli.localdomain \
--to=sakari.ailus@iki.fi \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=sakari.ailus@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox