* about v4l2_fh_is_singular
@ 2011-12-20 9:29 Scott Jiang
2011-12-20 10:29 ` Sakari Ailus
0 siblings, 1 reply; 2+ messages in thread
From: Scott Jiang @ 2011-12-20 9:29 UTC (permalink / raw)
To: Hans Verkuil, sakari.ailus; +Cc: LMML
Hi Sakari,
Hans recommends me using v4l2_fh_is_singular in first open, but I
found it used list_is_singular(&fh->list).
Should it use &fh->vdev->fh_list or I missed something?
Regards,
Scott
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: about v4l2_fh_is_singular
2011-12-20 9:29 about v4l2_fh_is_singular Scott Jiang
@ 2011-12-20 10:29 ` Sakari Ailus
0 siblings, 0 replies; 2+ messages in thread
From: Sakari Ailus @ 2011-12-20 10:29 UTC (permalink / raw)
To: Scott Jiang; +Cc: Hans Verkuil, LMML
On Tue, Dec 20, 2011 at 05:29:47PM +0800, Scott Jiang wrote:
> Hi Sakari,
>
> Hans recommends me using v4l2_fh_is_singular in first open, but I
> found it used list_is_singular(&fh->list).
> Should it use &fh->vdev->fh_list or I missed something?
Hi, Scott!
I think why Hans is telling you that you should use v4l2_fh_is_singular()
instead of going for list_is_singular() directly, is that how the file
handles are being stored by the V4L2 subdev framework might be changed in
the future. If you use v4l2_fh_is_singular(), you won't need to change your
driver if that happens. Besides that, it's often better not deal with things
you don't really need to.
Regards,
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi jabber/XMPP/Gmail: sailus@retiisi.org.uk
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-20 10:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-20 9:29 about v4l2_fh_is_singular Scott Jiang
2011-12-20 10:29 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox