re: V4L/DVB (12892): DVB-API: add support for ISDB-T and ISDB-Tsb (version 5.1)

re: V4L/DVB (12892): DVB-API: add support for ISDB-T and ISDB-Tsb (version 5.1)

[Dan Carpenter]

Hello Patrick Boettcher,

I know this patch is really old but I was hoping you still might be
able to take a look at it.

The patch b6e760f30975: "V4L/DVB (12892): DVB-API: add support for 
ISDB-T and ISDB-Tsb (version 5.1)" from Aug 3, 2009, leads to the 
following warning:
drivers/media/dvb/dvb-core/dvb_frontend.c:993:9: warning: Initializer entry defined twice
drivers/media/dvb/dvb-core/dvb_frontend.c:1012:9:   also defined here

The following two sections are basically cut and paste except that the
ones in the first section were changed to zeros.  The second set of
initializers over writes the first, so probably we could just remove
the first section?

drivers/media/dvb/dvb-core/dvb_frontend.c

+       _DTV_CMD(DTV_ISDBT_PARTIAL_RECEPTION, 1, 0),
+       _DTV_CMD(DTV_ISDBT_SOUND_BROADCASTING, 1, 0),
+       _DTV_CMD(DTV_ISDBT_SB_SUBCHANNEL_ID, 1, 0),
+       _DTV_CMD(DTV_ISDBT_SB_SEGMENT_IDX, 1, 0),
+       _DTV_CMD(DTV_ISDBT_SB_SEGMENT_COUNT, 1, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERA_FEC, 1, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERA_MODULATION, 1, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERA_SEGMENT_COUNT, 1, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERA_TIME_INTERLEAVING, 1, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERB_FEC, 1, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERB_MODULATION, 1, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERB_SEGMENT_COUNT, 1, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERB_TIME_INTERLEAVING, 1, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERC_FEC, 1, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERC_MODULATION, 1, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERC_SEGMENT_COUNT, 1, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERC_TIME_INTERLEAVING, 1, 0),
+
+       _DTV_CMD(DTV_ISDBT_PARTIAL_RECEPTION, 0, 0),
+       _DTV_CMD(DTV_ISDBT_SOUND_BROADCASTING, 0, 0),
+       _DTV_CMD(DTV_ISDBT_SB_SUBCHANNEL_ID, 0, 0),
+       _DTV_CMD(DTV_ISDBT_SB_SEGMENT_IDX, 0, 0),
+       _DTV_CMD(DTV_ISDBT_SB_SEGMENT_COUNT, 0, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERA_FEC, 0, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERA_MODULATION, 0, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERA_SEGMENT_COUNT, 0, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERA_TIME_INTERLEAVING, 0, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERB_FEC, 0, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERB_MODULATION, 0, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERB_SEGMENT_COUNT, 0, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERB_TIME_INTERLEAVING, 0, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERC_FEC, 0, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERC_MODULATION, 0, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERC_SEGMENT_COUNT, 0, 0),
+       _DTV_CMD(DTV_ISDBT_LAYERC_TIME_INTERLEAVING, 0, 0),

regards,
dan carpenter

Re: V4L/DVB (12892): DVB-API: add support for ISDB-T and ISDB-Tsb (version 5.1)

[Patrick Boettcher]

On Friday 13 January 2012 13:37:57 Dan Carpenter wrote:
> Hello Patrick Boettcher,
> 
> I know this patch is really old but I was hoping you still might be
> able to take a look at it.
> 
> The patch b6e760f30975: "V4L/DVB (12892): DVB-API: add support for
> ISDB-T and ISDB-Tsb (version 5.1)" from Aug 3, 2009, leads to the
> following warning:
> drivers/media/dvb/dvb-core/dvb_frontend.c:993:9: warning: Initializer
> entry defined twice
> drivers/media/dvb/dvb-core/dvb_frontend.c:1012:9:   also defined
> here

How does this thing has lived such a long time without being noticed by 
anyone? Very strange.

Of course this is wrong and it should be fixed by removing the second 
section. IOW, we should keep the section with the 1s. 

> drivers/media/dvb/dvb-core/dvb_frontend.c
> 
> +       _DTV_CMD(DTV_ISDBT_PARTIAL_RECEPTION, 1, 0),
> +       _DTV_CMD(DTV_ISDBT_SOUND_BROADCASTING, 1, 0),
> +       _DTV_CMD(DTV_ISDBT_SB_SUBCHANNEL_ID, 1, 0),
> +       _DTV_CMD(DTV_ISDBT_SB_SEGMENT_IDX, 1, 0),
> +       _DTV_CMD(DTV_ISDBT_SB_SEGMENT_COUNT, 1, 0),
> +       _DTV_CMD(DTV_ISDBT_LAYERA_FEC, 1, 0),
> +       _DTV_CMD(DTV_ISDBT_LAYERA_MODULATION, 1, 0),
> +       _DTV_CMD(DTV_ISDBT_LAYERA_SEGMENT_COUNT, 1, 0),
> +       _DTV_CMD(DTV_ISDBT_LAYERA_TIME_INTERLEAVING, 1, 0),
> +       _DTV_CMD(DTV_ISDBT_LAYERB_FEC, 1, 0),
> +       _DTV_CMD(DTV_ISDBT_LAYERB_MODULATION, 1, 0),
> +       _DTV_CMD(DTV_ISDBT_LAYERB_SEGMENT_COUNT, 1, 0),
> +       _DTV_CMD(DTV_ISDBT_LAYERB_TIME_INTERLEAVING, 1, 0),
> +       _DTV_CMD(DTV_ISDBT_LAYERC_FEC, 1, 0),
> +       _DTV_CMD(DTV_ISDBT_LAYERC_MODULATION, 1, 0),
> +       _DTV_CMD(DTV_ISDBT_LAYERC_SEGMENT_COUNT, 1, 0),
> +       _DTV_CMD(DTV_ISDBT_LAYERC_TIME_INTERLEAVING, 1, 0),

I prepared a patch for this in my repo. I will send a pull-request right 
away.

Thanks for pointing this out.

regards,
--
Patrick.