Re: [PATCH v5 09/35] v4l: Add subdev selections documentation

[Sakari Ailus <sakari.ailus@iki.fi>]

Hi Michael,

Thanks for the comments.

On Wed, Mar 07, 2012 at 09:53:42AM +0100, Michael Jones wrote:
> Hi Sakari,
> 
> Hopefully it's not too late to make a few minor suggestions.
> 
> On 03/06/2012 05:32 PM, Sakari Ailus wrote:
> >Add documentation for V4L2 subdev selection API. This changes also
> >experimental V4L2 subdev API so that scaling now works through selection API
> >only.
> >
> >Signed-off-by: Sakari Ailus<sakari.ailus@iki.fi>
> [snip]
> >+
> >+<para>On sink pads, cropping is applied relatively to the
> 
> s/relatively/relative/
> 
> >+      current pad format. The pad format represents the image size as
> >+      received by the sub-device from the previous block in the
> >+      pipeline, and the crop rectangle represents the sub-image that
> >+      will be transmitted further inside the sub-device for
> >+      processing.</para>
> [snip]
> >+<para>On source pads, cropping is similar to sink pads, with the
> >+      exception that the source size from which the cropping is
> >+      performed, is the COMPOSE rectangle on the sink pad. In both
> >+      sink and source pads, the crop rectangle must be entirely
> >+      containted inside the source image size for the crop
> 
> s/containted/contained/
> 
> >+      operation.</para>
> >+
> >+<para>The drivers should always use the closest possible
> >+      rectangle the user requests on all selection targets, unless
> >+      specificly told otherwise.
> 
> s/specificly/specifically/
> 
> >+<constant>V4L2_SUBDEV_SEL_FLAG_SIZE_GE</constant>  and
> >+<constant>V4L2_SUBDEV_SEL_FLAG_SIZE_LE</constant>  flags may be
> >+      used to round the image size either up or down.<xref
> >+      linkend="v4l2-subdev-selection-flags"></xref></para>
> >+</section>
> 
> [snip]
> 
> >+<constant>V4L2_SUBDEV_SEL_FLAG_KEEP_CONFIG</constant>  flag. This
> >+      flag causes that no propagation of the changes are allowed in
> >+      any circumstances. This may also cause the accessed rectangle to
> 
> "This flag causes that" sounds ungrammatical.  I suggest: "This flag
> causes no propagation of the changes to be allowed under any
> circumstances."

Applied all of them.

Cheers,

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi	jabber/XMPP/Gmail: sailus@retiisi.org.uk