From: Dan Carpenter <dan.carpenter@oracle.com>
To: bcollins@bluecherry.net
Cc: linux-media@vger.kernel.org
Subject: re: Staging: solo6x10: New driver (staging) for Softlogic 6x10
Date: Sat, 9 Jun 2012 11:58:22 +0300 [thread overview]
Message-ID: <20120609085822.GA31637@elgon.mountain> (raw)
Hello Ben Collins,
The patch faa4fd2a0951: "Staging: solo6x10: New driver (staging) for
Softlogic 6x10" from Jun 17, 2010, leads to the following warning:
drivers/staging/media/solo6x10/tw28.c:352 tw2815_setup()
warn: x |= 0
tbl_ntsc_tw2815_common[0x06] |= 0x03 & (DEFAULT_HDELAY_NTSC >> 8);
DEFAULT_HDELAY_NTSC is less than 256 so after the shift we get:
tbl_ntsc_tw2815_common[0x06] |= 0x03 & 0;
Which is a noop. There are several of these complicated noops.
drivers/staging/media/solo6x10/tw28.c:352 tw2815_setup() warn: x |= 0
drivers/staging/media/solo6x10/tw28.c:362 tw2815_setup() warn: x |= 0
drivers/staging/media/solo6x10/tw28.c:367 tw2815_setup() warn: x |= 0
drivers/staging/media/solo6x10/tw28.c:373 tw2815_setup() warn: x |= 0
drivers/staging/media/solo6x10/tw28.c:383 tw2815_setup() warn: x |= 0
regards,
dan carpenter
reply other threads:[~2012-06-09 8:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120609085822.GA31637@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=bcollins@bluecherry.net \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox