* re: Staging: solo6x10: New driver (staging) for Softlogic 6x10
@ 2012-06-09 8:58 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2012-06-09 8:58 UTC (permalink / raw)
To: bcollins; +Cc: linux-media
Hello Ben Collins,
The patch faa4fd2a0951: "Staging: solo6x10: New driver (staging) for
Softlogic 6x10" from Jun 17, 2010, leads to the following warning:
drivers/staging/media/solo6x10/tw28.c:352 tw2815_setup()
warn: x |= 0
tbl_ntsc_tw2815_common[0x06] |= 0x03 & (DEFAULT_HDELAY_NTSC >> 8);
DEFAULT_HDELAY_NTSC is less than 256 so after the shift we get:
tbl_ntsc_tw2815_common[0x06] |= 0x03 & 0;
Which is a noop. There are several of these complicated noops.
drivers/staging/media/solo6x10/tw28.c:352 tw2815_setup() warn: x |= 0
drivers/staging/media/solo6x10/tw28.c:362 tw2815_setup() warn: x |= 0
drivers/staging/media/solo6x10/tw28.c:367 tw2815_setup() warn: x |= 0
drivers/staging/media/solo6x10/tw28.c:373 tw2815_setup() warn: x |= 0
drivers/staging/media/solo6x10/tw28.c:383 tw2815_setup() warn: x |= 0
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-06-09 8:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-09 8:58 Staging: solo6x10: New driver (staging) for Softlogic 6x10 Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox