* [patch 1/2] [media] tuner-xc2028: fix "=" vs "==" typo
@ 2012-07-21 8:32 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2012-07-21 8:32 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Gianluca Gennari, Thomas Meyer, Miroslav Slugen, Thierry Reding,
linux-media, kernel-janitors
We intended to do a compare here, not an assignment.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Static analysis bug. I don't own the hardware.
diff --git a/drivers/media/common/tuners/tuner-xc2028.c b/drivers/media/common/tuners/tuner-xc2028.c
index f88f948..9e60285 100644
--- a/drivers/media/common/tuners/tuner-xc2028.c
+++ b/drivers/media/common/tuners/tuner-xc2028.c
@@ -756,7 +756,7 @@ retry:
* No need to reload base firmware if it matches and if the tuner
* is not at sleep mode
*/
- if ((priv->state = XC2028_ACTIVE) &&
+ if ((priv->state == XC2028_ACTIVE) &&
(((BASE | new_fw.type) & BASE_TYPES) ==
(priv->cur_fw.type & BASE_TYPES))) {
tuner_dbg("BASE firmware not changed.\n");
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-07-21 8:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-21 8:32 [patch 1/2] [media] tuner-xc2028: fix "=" vs "==" typo Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox