* [PATCH, RESEND] ov9640: fix missing break
@ 2012-07-24 15:50 Alan Cox
2012-07-29 13:55 ` Guennadi Liakhovetski
0 siblings, 1 reply; 2+ messages in thread
From: Alan Cox @ 2012-07-24 15:50 UTC (permalink / raw)
To: linux-media, akpm
From: Alan Cox <alan@linux.intel.com>
Without this rev2 ends up behaving as rev3
Reported-by: dcb314@hotmail.com
Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=44081
Signed-off-by: Alan Cox <alan@linux.intel.com>
---
drivers/media/video/ov9640.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/video/ov9640.c b/drivers/media/video/ov9640.c
index 23412de..9ed4ba4 100644
--- a/drivers/media/video/ov9640.c
+++ b/drivers/media/video/ov9640.c
@@ -605,6 +605,7 @@ static int ov9640_video_probe(struct i2c_client *client)
devname = "ov9640";
priv->model = V4L2_IDENT_OV9640;
priv->revision = 2;
+ break;
case OV9640_V3:
devname = "ov9640";
priv->model = V4L2_IDENT_OV9640;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH, RESEND] ov9640: fix missing break
2012-07-24 15:50 [PATCH, RESEND] ov9640: fix missing break Alan Cox
@ 2012-07-29 13:55 ` Guennadi Liakhovetski
0 siblings, 0 replies; 2+ messages in thread
From: Guennadi Liakhovetski @ 2012-07-29 13:55 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-media, akpm
Hi Alan
On Tue, 24 Jul 2012, Alan Cox wrote:
> From: Alan Cox <alan@linux.intel.com>
>
> Without this rev2 ends up behaving as rev3
>
> Reported-by: dcb314@hotmail.com
> Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=44081
> Signed-off-by: Alan Cox <alan@linux.intel.com>
Thanks, I'll push this for 3.6, and will ask Mauro to push this to stable
too.
Thanks
Guennadi
> ---
>
> drivers/media/video/ov9640.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/video/ov9640.c b/drivers/media/video/ov9640.c
> index 23412de..9ed4ba4 100644
> --- a/drivers/media/video/ov9640.c
> +++ b/drivers/media/video/ov9640.c
> @@ -605,6 +605,7 @@ static int ov9640_video_probe(struct i2c_client *client)
> devname = "ov9640";
> priv->model = V4L2_IDENT_OV9640;
> priv->revision = 2;
> + break;
> case OV9640_V3:
> devname = "ov9640";
> priv->model = V4L2_IDENT_OV9640;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-29 13:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-24 15:50 [PATCH, RESEND] ov9640: fix missing break Alan Cox
2012-07-29 13:55 ` Guennadi Liakhovetski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox