* re: [media] s2255drv: remove V4L2_FL_LOCK_ALL_FOPS
@ 2012-08-13 15:23 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2012-08-13 15:23 UTC (permalink / raw)
To: hans.verkuil; +Cc: linux-media
Hello Hans Verkuil,
This is a semi-automatic email about new static checker warnings.
The patch 0e1f0edfdd25: "[media] s2255drv: remove
V4L2_FL_LOCK_ALL_FOPS" from Jun 24, 2012, leads to the following
Smatch complaint:
drivers/media/video/s2255drv.c:1867 s2255_mmap_v4l()
warn: variable dereferenced before check 'fh' (see line 1864)
drivers/media/video/s2255drv.c
1863 struct s2255_fh *fh = file->private_data;
1864 struct s2255_dev *dev = fh->dev;
^^^^^^^
New dereference.
1865 int ret;
1866
1867 if (!fh)
^^^
Old check.
1868 return -ENODEV;
1869 dprintk(4, "%s, vma=0x%08lx\n", __func__, (unsigned long)vma);
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-08-13 15:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-13 15:23 [media] s2255drv: remove V4L2_FL_LOCK_ALL_FOPS Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox