* [media] staging: go7007: fix test for V4L2_STD_SECAM
@ 2013-01-28 14:19 Dan Carpenter
2013-01-28 14:22 ` Hans Verkuil
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-01-28 14:19 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: YAMANE Toshiaki, Wei Yongjun, linux-media, Ross Cohen,
kernel-janitors
The current test doesn't make a lot of sense. It's likely to be true,
which is what we would want in most cases. From looking at how this is
handled in other drivers, I think "&" was intended instead of "*".
It's an easy mistake to make because they are next to each other on the
keyboard.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/media/go7007/wis-saa7113.c b/drivers/staging/media/go7007/wis-saa7113.c
index 8810c1e..891cde7 100644
--- a/drivers/staging/media/go7007/wis-saa7113.c
+++ b/drivers/staging/media/go7007/wis-saa7113.c
@@ -141,7 +141,7 @@ static int wis_saa7113_command(struct i2c_client *client,
} else if (dec->norm & V4L2_STD_PAL) {
write_reg(client, 0x0e, 0x01);
write_reg(client, 0x10, 0x48);
- } else if (dec->norm * V4L2_STD_SECAM) {
+ } else if (dec->norm & V4L2_STD_SECAM) {
write_reg(client, 0x0e, 0x50);
write_reg(client, 0x10, 0x48);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [media] staging: go7007: fix test for V4L2_STD_SECAM
2013-01-28 14:19 [media] staging: go7007: fix test for V4L2_STD_SECAM Dan Carpenter
@ 2013-01-28 14:22 ` Hans Verkuil
0 siblings, 0 replies; 2+ messages in thread
From: Hans Verkuil @ 2013-01-28 14:22 UTC (permalink / raw)
To: Dan Carpenter
Cc: Mauro Carvalho Chehab, YAMANE Toshiaki, Wei Yongjun, linux-media,
Ross Cohen, kernel-janitors
On Mon January 28 2013 15:19:42 Dan Carpenter wrote:
> The current test doesn't make a lot of sense. It's likely to be true,
> which is what we would want in most cases. From looking at how this is
> handled in other drivers, I think "&" was intended instead of "*".
> It's an easy mistake to make because they are next to each other on the
> keyboard.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
For the record, it should indeed be '&'. Nice catch.
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Regards,
Hans
>
> diff --git a/drivers/staging/media/go7007/wis-saa7113.c b/drivers/staging/media/go7007/wis-saa7113.c
> index 8810c1e..891cde7 100644
> --- a/drivers/staging/media/go7007/wis-saa7113.c
> +++ b/drivers/staging/media/go7007/wis-saa7113.c
> @@ -141,7 +141,7 @@ static int wis_saa7113_command(struct i2c_client *client,
> } else if (dec->norm & V4L2_STD_PAL) {
> write_reg(client, 0x0e, 0x01);
> write_reg(client, 0x10, 0x48);
> - } else if (dec->norm * V4L2_STD_SECAM) {
> + } else if (dec->norm & V4L2_STD_SECAM) {
> write_reg(client, 0x0e, 0x50);
> write_reg(client, 0x10, 0x48);
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-28 14:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-28 14:19 [media] staging: go7007: fix test for V4L2_STD_SECAM Dan Carpenter
2013-01-28 14:22 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox